Skip to content

Commit abec715

Browse files
committed
Allow VERSION to have a newline (makes releasing easier)
1 parent 1afc111 commit abec715

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.github/workflows/build.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ jobs:
5454
- name: Setup Environment Variables
5555
shell: bash
5656
run: |
57-
VERSION=$(cat VERSION)
57+
VERSION=$(head -n1 VERSION)
5858
echo "VERSION=$VERSION" >> $GITHUB_ENV
5959
echo "APP_DIR=${{ env.BUILD_DIR }}/${{ env.BINARY_NAME }}_artefacts/${{ env.BUILD_TYPE }}" >> $GITHUB_ENV
6060
echo "ZIP_FILE_NAME=${{ env.BINARY_NAME }}_${{ matrix.name }}.zip" >> $GITHUB_ENV

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
cmake_minimum_required(VERSION 3.15)
22

3-
file(READ VERSION CURRENT_VERSION)
3+
file(STRINGS VERSION CURRENT_VERSION LIMIT_COUNT 1)
44
project(pluginval VERSION ${CURRENT_VERSION})
55

66
if (APPLE)

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ If you have a case you would like tests, please simply write the test in a fork
103103
104104
### Cutting New Releases
105105
106-
* Update VERSION (make sure there's not an extra newline)
106+
* Update VERSION (an extra newline is fine)
107107
* Update CHANGELIST.md
108108
* `git commit -am "Version 1.0.5"`
109109
* `git tag -a v1.0.5 -m "1.0.5 release"`

0 commit comments

Comments
 (0)