Fixed some macOS and Linux build warnings

Author: drowaudio

Source/CommandLine.cpp

@@ -388,7 +388,7 @@ void performCommandLine (CommandLineValidator& validator, const ArgumentList& ar
     cli.addCommand ({ "--validate",
                       "--validate [list]",
                       "Validates the files (or IDs for AUs).", String(),
-                      [&validator] (const auto& args) { validate (validator, args); }});
+                      [&validator] (const auto& validatorArgs) { validate (validator, validatorArgs); }});
     cli.addCommand ({ "--run-tests",
                       "--run-tests",
                       "Runs the internal unit tests.", String(),

Source/CommandLine.h

@@ -21,7 +21,7 @@ struct CommandLineValidator : private ChangeListener,
                               private Validator::Listener
 {
     CommandLineValidator();
-    ~CommandLineValidator();
+    ~CommandLineValidator() override;
 
     void validate (const StringArray& fileOrIDs, PluginTests::Options, bool validateInProcess);
 

Source/Main.cpp

@@ -31,10 +31,10 @@ class PluginValidatorApplication  : public JUCEApplication,
         return *propertiesFile;
     }
 
-    void initialiseSlaveFileLogger()
+    void initialiseChildFileLogger()
     {
-       #if LOG_PIPE_SLAVE_COMMUNICATION
-        fileLogger = std::make_unique<FileLogger> (getPropertiesFileOptions().getDefaultFile().getSiblingFile ("slave_log.txt"),
+       #if LOG_PIPE_CHILD_COMMUNICATION
+        fileLogger = std::make_unique<FileLogger> (getPropertiesFileOptions().getDefaultFile().getSiblingFile ("child_log.txt"),
                                                    getApplicationName() + " v" + getApplicationVersion(), 1024 * 1024);
         Logger::setCurrentLogger (fileLogger.get());
        #endif
@@ -59,7 +59,7 @@ class PluginValidatorApplication  : public JUCEApplication,
             return;
         }
 
-        if (invokeSlaveProcessValidator (commandLine))
+        if (invokeChildProcessValidator (commandLine))
             return;
 
         validator = std::make_unique<Validator>();
@@ -190,7 +190,7 @@ PropertiesFile& getAppPreferences()
     return app->getAppPreferences();
 }
 
-void slaveInitialised()
+void childInitialised()
 {
-    dynamic_cast<PluginValidatorApplication*> (PluginValidatorApplication::getInstance())->initialiseSlaveFileLogger();
+    dynamic_cast<PluginValidatorApplication*> (PluginValidatorApplication::getInstance())->initialiseChildFileLogger();
 }

Source/MainComponent.h

@@ -32,7 +32,7 @@ struct ConnectionStatus : public Component,
         validator.addChangeListener (this);
     }
 
-    ~ConnectionStatus()
+    ~ConnectionStatus() override
     {
         validator.removeListener (this);
         validator.removeChangeListener (this);
@@ -119,7 +119,7 @@ struct ConsoleComponent : public Component,
         editor.setScrollbarThickness (8);
     }
 
-    ~ConsoleComponent()
+    ~ConsoleComponent() override
     {
         validator.removeChangeListener (this);
         validator.removeListener (this);
@@ -222,7 +222,7 @@ class MainComponent   : public Component,
 public:
     //==============================================================================
     MainComponent (Validator&);
-    ~MainComponent();
+    ~MainComponent() override;
 
     //==============================================================================
     void paint (Graphics&) override;

Source/TestUtilities.cpp

@@ -103,6 +103,26 @@ ATTRIBUTE_USED void operator delete[] (void* ptr) noexcept
     std::free (ptr);
 }
 
+#if JUCE_CXX14_IS_AVAILABLE
+void operator delete (void* ptr, size_t) noexcept
+{
+    if (! logAllocationViolationIfNotAllowed())
+        if (thowIfRequiredAndReturnShouldLog())
+            std::cerr << "!!! WARNING: Illegal deletion\n";
+
+    std::free (ptr);
+}
+
+void operator delete[] (void* ptr, size_t) noexcept
+{
+    if (! logAllocationViolationIfNotAllowed())
+        if (thowIfRequiredAndReturnShouldLog())
+            std::cerr << "!!! WARNING: Illegal array deletion\n";
+
+    std::free (ptr);
+}
+#endif
+
 //==============================================================================
 std::atomic<AllocatorInterceptor::ViolationBehaviour> AllocatorInterceptor::violationBehaviour (ViolationBehaviour::logToCerr);