Bug: Switched to using _Exit which correctly sets the exit code without calling static destructors [Fixes #125]

drowaudio · drowaudio · commit ca67c8e7605d · 2024-06-06T11:43:26.000+01:00
diff --git a/CHANGELIST.md b/CHANGELIST.md
@@ -1,5 +1,8 @@
 # pluginval Change List
 
+### 1.0.4
+- Fixed incorrect "ALL TESTS PASSED" message when validating out of process [#125]
+
 ### 1.0.3
 -  Fix VST3 host bus issue
 
diff --git a/Source/CommandLine.cpp b/Source/CommandLine.cpp
@@ -60,8 +60,10 @@ inline void logAndFlush (const juce::String& m)
 #if JUCE_MAC
 static void kill9WithSomeMercy (int signal)
 {
-   juce::Logger::writeToLog ("pluginval received " + juce::String(::strsignal(signal)) + ", exiting immediately");
-   kill (getpid(), SIGKILL);
+    juce::Logger::writeToLog ("pluginval received " + juce::String(::strsignal(signal)) + ", exiting immediately");
+
+    // Use std::_Exit here instead of kill as kill doesn't seem to set the exit code of the process so is picked up as a "pass" in the host process
+    std::_Exit (SIGKILL);
 }
 
 // Avoid showing the macOS crash dialog, which can cause the process to hang

Original file line number	Diff line number	Diff line change
`@@ -60,8 +60,10 @@ inline void logAndFlush (const juce::String& m)`
`60`	`60`	`#if JUCE_MAC`
`61`	`61`	`static void kill9WithSomeMercy (int signal)`
`62`	`62`	`{`
`63`		`- juce::Logger::writeToLog ("pluginval received " + juce::String(::strsignal(signal)) + ", exiting immediately");`
`64`		`- kill (getpid(), SIGKILL);`
	`63`	`+ juce::Logger::writeToLog ("pluginval received " + juce::String(::strsignal(signal)) + ", exiting immediately");`
	`64`	`+`
	`65`	`+ // Use std::_Exit here instead of kill as kill doesn't seem to set the exit code of the process so is picked up as a "pass" in the host process`
	`66`	`+ std::_Exit (SIGKILL);`
`65`	`67`	`}`
`66`	`68`
`67`	`69`	`// Avoid showing the macOS crash dialog, which can cause the process to hang`