LoopingMidiNode: Avoided creating note-on events when the sequence changes as this plays playing notes again even if the new notes are not under the playhead. Instead, notes will only be played when the playhead passes the note-on event which is what most DAWs seem to do anyway.

Author: drowaudio

modules/tracktion_engine/playback/graph/tracktion_LoopingMidiNode.cpp

@@ -1028,7 +1028,7 @@ class LoopedMidiEventGenerator : public MidiGenerator
             generator->setTime (0.0);
         }
 
-        return exhausted();
+        return ! exhausted();
     }
 
     bool exhausted() override
@@ -1171,7 +1171,7 @@ class GeneratorAndNoteList
 
         assert (sequences.size() > 0);
         dynamicOffsetBeats = std::move (dynamicOffsetBeatsToUse);
-        shouldCreateMessagesForTime = clipPropertiesHaveChanged || noteListToUse == nullptr;
+        shouldCreateMessagesForTime = noteListToUse == nullptr;
         activeNoteList = noteListToUse ? std::move (noteListToUse)
                                        : std::make_shared<ActiveNoteList>();