Merge pull request #263 from ruguevara/master

FigBug · web-flow · commit b0c7dd090a56 · 2025-08-22T07:35:09.000-07:00
Fix MIDI timestamp handling in FourOscPlugin for sample-accurate timing
diff --git a/modules/tracktion_engine/plugins/effects/tracktion_FourOscPlugin.cpp b/modules/tracktion_engine/plugins/effects/tracktion_FourOscPlugin.cpp
@@ -1487,7 +1487,7 @@ void FourOscPlugin::applyToBuffer (const PluginRenderContext& fc)
             {
                 for (auto m : *fc.bufferForMidiMessages)
                 {
-                    int midiPos = int (m.getTimeStamp());
+                    int midiPos = juce::roundToInt (m.getTimeStamp() * getSampleRate());
                     if (midiPos >= pos && midiPos < pos + thisBlock)
                         midi.addEvent (m, midiPos - pos);
                 }

Original file line number	Diff line number	Diff line change
`@@ -1487,7 +1487,7 @@ void FourOscPlugin::applyToBuffer (const PluginRenderContext& fc)`
`1487`	`1487`	`{`
`1488`	`1488`	`for (auto m : *fc.bufferForMidiMessages)`
`1489`	`1489`	`{`
`1490`		`- int midiPos = int (m.getTimeStamp());`
	`1490`	`+ int midiPos = juce::roundToInt (m.getTimeStamp() * getSampleRate());`
`1491`	`1491`	`if (midiPos >= pos && midiPos < pos + thisBlock)`
`1492`	`1492`	`midi.addEvent (m, midiPos - pos);`
`1493`	`1493`	`}`