開発者オーバレイの表示と保存処理を修正

Author: TinyKitten

src/components/DevOverlay.test.tsx

@@ -7,6 +7,7 @@ import {
   backgroundLocationTrackingAtom,
   locationAtom,
 } from '~/store/atoms/location';
+import { isLEDThemeAtom } from '~/store/atoms/theme';
 import DevOverlay from './DevOverlay';
 
 jest.mock('jotai', () => {
@@ -91,7 +92,10 @@ describe('DevOverlay', () => {
       if (atom === backgroundLocationTrackingAtom) {
         return backgroundLocationTracking as never;
       }
-      return undefined as never;
+      if (atom === isLEDThemeAtom) {
+        return false as never;
+      }
+      throw new Error(`Unexpected atom mock: ${String(atom)}`);
     });
   };
 

src/components/DevOverlay.tsx

@@ -520,9 +520,7 @@ const DevOverlay: React.FC = () => {
                     <Typography style={styles.chartLabel}>
                       ACCURACY HISTORY
                     </Typography>
-                    <Typography style={[styles.chartValue, chartValueStyle]}>
-                      {accuracyChartBlocks.length === 0 ? '---' : null}
-                    </Typography>
+                    <Typography style={[styles.chartValue, chartValueStyle]} />
                     <Typography
                       style={[styles.chartValue, chartValueStyle]}
                       testID="dev-overlay-accuracy-history"
@@ -592,9 +590,7 @@ const DevOverlay: React.FC = () => {
                 <Typography style={styles.chartLabel}>
                   ACCURACY HISTORY
                 </Typography>
-                <Typography style={[styles.chartValue, chartValueStyle]}>
-                  {accuracyChartBlocks.length === 0 ? '---' : null}
-                </Typography>
+                <Typography style={[styles.chartValue, chartValueStyle]} />
                 <Typography
                   style={[styles.chartValue, chartValueStyle]}
                   testID="dev-overlay-accuracy-history"

src/components/Permitted.tsx

@@ -239,15 +239,28 @@ const PermittedLayout: React.FC<Props> = ({ children }: Props) => {
             devOverlayEnabled ? 'hideDevOverlay' : 'showDevOverlay'
           ),
           handler: async () => {
+            const prevValue = devOverlayEnabled;
             const nextValue = !devOverlayEnabled;
             setTuning((prev) => ({
               ...prev,
               devOverlayEnabled: nextValue,
             }));
-            await AsyncStorage.setItem(
-              ASYNC_STORAGE_KEYS.DEV_OVERLAY_ENABLED,
-              String(nextValue)
-            );
+            try {
+              await AsyncStorage.setItem(
+                ASYNC_STORAGE_KEYS.DEV_OVERLAY_ENABLED,
+                String(nextValue)
+              );
+            } catch (error) {
+              console.error(error);
+              setTuning((prev) => ({
+                ...prev,
+                devOverlayEnabled: prevValue,
+              }));
+              Alert.alert(
+                translate('errorTitle'),
+                translate('failedToSavePreference')
+              );
+            }
           },
         });
       }