チューニング設定の全項目をAsyncStorageで永続化し、テレメトリ有効時の確認アラートを削除 (#5587)

https://claude.ai/code/session_01JR8c8hRFxj73aLTZkFHmcR

Co-authored-by: Claude <noreply@anthropic.com>

Author: TinyKitten

src/components/Permitted.tsx

@@ -306,6 +306,10 @@ const PermittedLayout: React.FC<Props> = ({ children }: Props) => {
         ttsEnabledLanguagesStr,
         telemetryEnabledStr,
         devOverlayEnabledStr,
+        headerTransitionIntervalStr,
+        headerTransitionDelayStr,
+        bottomTransitionIntervalStr,
+        untouchableModeEnabledStr,
       ] = await Promise.all([
         AsyncStorage.getItem(ASYNC_STORAGE_KEYS.PREVIOUS_THEME),
         AsyncStorage.getItem(ASYNC_STORAGE_KEYS.ENABLED_LANGUAGES),
@@ -314,6 +318,10 @@ const PermittedLayout: React.FC<Props> = ({ children }: Props) => {
         AsyncStorage.getItem(ASYNC_STORAGE_KEYS.TTS_ENABLED_LANGUAGES),
         AsyncStorage.getItem(ASYNC_STORAGE_KEYS.TELEMETRY_ENABLED),
         AsyncStorage.getItem(ASYNC_STORAGE_KEYS.DEV_OVERLAY_ENABLED),
+        AsyncStorage.getItem(ASYNC_STORAGE_KEYS.HEADER_TRANSITION_INTERVAL),
+        AsyncStorage.getItem(ASYNC_STORAGE_KEYS.HEADER_TRANSITION_DELAY),
+        AsyncStorage.getItem(ASYNC_STORAGE_KEYS.BOTTOM_TRANSITION_INTERVAL),
+        AsyncStorage.getItem(ASYNC_STORAGE_KEYS.UNTOUCHABLE_MODE_ENABLED),
       ]);
 
       if (prevThemeKey) {
@@ -371,6 +379,39 @@ const PermittedLayout: React.FC<Props> = ({ children }: Props) => {
           devOverlayEnabled: devOverlayEnabledStr === 'true',
         }));
       }
+      if (headerTransitionIntervalStr) {
+        const parsed = Number(headerTransitionIntervalStr);
+        if (!Number.isNaN(parsed)) {
+          setTuning((prev) => ({
+            ...prev,
+            headerTransitionInterval: parsed,
+          }));
+        }
+      }
+      if (headerTransitionDelayStr) {
+        const parsed = Number(headerTransitionDelayStr);
+        if (!Number.isNaN(parsed)) {
+          setTuning((prev) => ({
+            ...prev,
+            headerTransitionDelay: parsed,
+          }));
+        }
+      }
+      if (bottomTransitionIntervalStr) {
+        const parsed = Number(bottomTransitionIntervalStr);
+        if (!Number.isNaN(parsed)) {
+          setTuning((prev) => ({
+            ...prev,
+            bottomTransitionInterval: parsed,
+          }));
+        }
+      }
+      if (untouchableModeEnabledStr) {
+        setTuning((prev) => ({
+          ...prev,
+          untouchableModeEnabled: untouchableModeEnabledStr === 'true',
+        }));
+      }
     };
 
     loadSettings();

src/components/TuningSettings.tsx

@@ -141,31 +141,40 @@ const TuningSettings: React.FC = () => {
   const parseNumberFromText = (prev: number, text: string) =>
     Number.isNaN(Number(text)) ? prev : Number(text);
 
-  const handleHeaderIntervalChange = (text: string) =>
+  const handleHeaderIntervalChange = (text: string) => {
+    const value = parseNumberFromText(settings.headerTransitionInterval, text);
     setSettings((prev) => ({
       ...prev,
-      headerTransitionInterval: parseNumberFromText(
-        prev.headerTransitionInterval,
-        text
-      ),
+      headerTransitionInterval: value,
     }));
-  const handleHeaderDelayChange = (text: string) =>
+    AsyncStorage.setItem(
+      ASYNC_STORAGE_KEYS.HEADER_TRANSITION_INTERVAL,
+      String(value)
+    );
+  };
+  const handleHeaderDelayChange = (text: string) => {
+    const value = parseNumberFromText(settings.headerTransitionDelay, text);
     setSettings((prev) => ({
       ...prev,
-      headerTransitionDelay: parseNumberFromText(
-        prev.headerTransitionDelay,
-        text
-      ),
+      headerTransitionDelay: value,
     }));
+    AsyncStorage.setItem(
+      ASYNC_STORAGE_KEYS.HEADER_TRANSITION_DELAY,
+      String(value)
+    );
+  };
 
-  const handleBottomDelayChange = (text: string) =>
+  const handleBottomDelayChange = (text: string) => {
+    const value = parseNumberFromText(settings.bottomTransitionInterval, text);
     setSettings((prev) => ({
       ...prev,
-      bottomTransitionInterval: parseNumberFromText(
-        prev.bottomTransitionInterval,
-        text
-      ),
+      bottomTransitionInterval: value,
     }));
+    AsyncStorage.setItem(
+      ASYNC_STORAGE_KEYS.BOTTOM_TRANSITION_INTERVAL,
+      String(value)
+    );
+  };
 
   const [voicePickerState, setVoicePickerState] = useState<{
     current: string;
@@ -199,44 +208,40 @@ const TuningSettings: React.FC = () => {
     AsyncStorage.setItem(ASYNC_STORAGE_KEYS.TTS_EN_VOICE_NAME, voice);
   };
 
-  const toggleDevOverlayEnabled = () =>
+  const toggleDevOverlayEnabled = () => {
+    const nextValue = !settings.devOverlayEnabled;
     setSettings((prev) => ({
       ...prev,
-      devOverlayEnabled: !prev.devOverlayEnabled,
+      devOverlayEnabled: nextValue,
     }));
+    AsyncStorage.setItem(
+      ASYNC_STORAGE_KEYS.DEV_OVERLAY_ENABLED,
+      String(nextValue)
+    );
+  };
 
-  const toggleUntouchableModeEnabled = () =>
+  const toggleUntouchableModeEnabled = () => {
+    const nextValue = !settings.untouchableModeEnabled;
     setSettings((prev) => ({
       ...prev,
-      untouchableModeEnabled: !prev.untouchableModeEnabled,
+      untouchableModeEnabled: nextValue,
     }));
+    AsyncStorage.setItem(
+      ASYNC_STORAGE_KEYS.UNTOUCHABLE_MODE_ENABLED,
+      String(nextValue)
+    );
+  };
 
   const toggleTelemetryEnabled = () => {
-    if (settings.telemetryEnabled) {
-      AsyncStorage.setItem(ASYNC_STORAGE_KEYS.TELEMETRY_ENABLED, 'false');
-      setSettings((prev) => ({
-        ...prev,
-        telemetryEnabled: !prev.telemetryEnabled,
-      }));
-      return;
-    }
-
-    Alert.alert(translate('notice'), translate('telemetrySettingWillPersist'), [
-      {
-        text: 'OK',
-        onPress: () => {
-          AsyncStorage.setItem(ASYNC_STORAGE_KEYS.TELEMETRY_ENABLED, 'true');
-          setSettings((prev) => ({
-            ...prev,
-            telemetryEnabled: !prev.telemetryEnabled,
-          }));
-        },
-      },
-      {
-        text: translate('cancel'),
-        style: 'cancel',
-      },
-    ]);
+    const nextValue = !settings.telemetryEnabled;
+    setSettings((prev) => ({
+      ...prev,
+      telemetryEnabled: nextValue,
+    }));
+    AsyncStorage.setItem(
+      ASYNC_STORAGE_KEYS.TELEMETRY_ENABLED,
+      String(nextValue)
+    );
   };
 
   return (

src/constants/asyncStorage.ts

@@ -20,6 +20,10 @@ export const ASYNC_STORAGE_KEYS = {
   DEV_OVERLAY_ENABLED: '@TrainLCD:devOverlayEnabled',
   TTS_JA_VOICE_NAME: '@TrainLCD:ttsJaVoiceName',
   TTS_EN_VOICE_NAME: '@TrainLCD:ttsEnVoiceName',
+  HEADER_TRANSITION_INTERVAL: '@TrainLCD:headerTransitionInterval',
+  HEADER_TRANSITION_DELAY: '@TrainLCD:headerTransitionDelay',
+  BOTTOM_TRANSITION_INTERVAL: '@TrainLCD:bottomTransitionInterval',
+  UNTOUCHABLE_MODE_ENABLED: '@TrainLCD:untouchableModeEnabled',
   WALKTHROUGH_COMPLETED: '@TrainLCD:walkthroughCompleted',
   ROUTE_SEARCH_WALKTHROUGH_COMPLETED:
     '@TrainLCD:routeSearchWalkthroughCompleted',