Merge pull request SDWebImage#3480 from dreampiggy/bugfix/data_copy_crash

dreampiggy · web-flow · commit eecc7e43800d · 2023-02-06T21:50:28.000+08:00
Remove the unused extra copy for `SDAnimatedImage` data initializer
diff --git a/SDWebImage/Core/SDAnimatedImage.m b/SDWebImage/Core/SDAnimatedImage.m
@@ -124,7 +124,6 @@ - (instancetype)initWithData:(NSData *)data scale:(CGFloat)scale options:(SDImag
     if (!data || data.length == 0) {
         return nil;
     }
-    data = [data copy]; // avoid mutable data
     id<SDAnimatedImageCoder> animatedCoder = nil;
     for (id<SDImageCoder>coder in [SDImageCodersManager sharedManager].coders.reverseObjectEnumerator) {
         if ([coder conformsToProtocol:@protocol(SDAnimatedImageCoder)]) {

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,6 @@ - (instancetype)initWithData:(NSData *)data scale:(CGFloat)scale options:(SDImag`
`124`	`124`	`if (!data \|\| data.length == 0) {`
`125`	`125`	`return nil;`
`126`	`126`	`}`
`127`		`- data = [data copy]; // avoid mutable data`
`128`	`127`	`id<SDAnimatedImageCoder> animatedCoder = nil;`
`129`	`128`	`for (id<SDImageCoder>coder in [SDImageCodersManager sharedManager].coders.reverseObjectEnumerator) {`
`130`	`129`	`if ([coder conformsToProtocol:@protocol(SDAnimatedImageCoder)]) {`