Merge pull request #660 from Travelport-Ukraine/master

0.17.1 Hotfix for `uapiErrorHandler`

Author: dchertousov

docs/Terminal.md

@@ -26,13 +26,17 @@ on how to use emulation.
 In case you want to handle some specific errors from uAPI, you can provde `uapiErrorHandler` function
 in options.
 
+Function should return response from retried command or any other command.
+
 Footprint of the functions should be as follows:
 ```javascript
 async (
   executeCommandWithRetry,
   { command, error: err }
 ) => {
   // your code goes here
+  // response is an array of strings (lines of terminal response)
+  return response;
 }
 ```
 

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "uapi-json",
-  "version": "1.17.0",
+  "version": "1.17.1",
   "description": "Travelport Universal API",
   "main": "src/",
   "files": [

package.json

@@ -170,7 +170,7 @@ module.exports = function (settings) {
     } catch (e) {
       if (!isErrorRetriable(e) || times <= 0) {
         if (uapiErrorHandler) {
-          await uapiErrorHandler(
+          return uapiErrorHandler(
             executeCommandWithRetry,
             { command, error: e }
           );

src/Services/Terminal/Terminal.js

@@ -313,12 +313,14 @@ describe('#Terminal', function terminalTest() {
         });
     });
   });
-  describe('Handling uapi errors', () => {
+  describe.only('Handling uapi errors', () => {
     beforeEach(() => {
       // Resetting spies
       getSessionToken.resetHistory();
       executeCommandOk.resetHistory();
       closeSession.resetHistory();
+      erIssues.resetHistory();
+      executeCommandErIssues.resetHistory();
     });
     it('should fail if no handlers provided', async () => {
       const uAPITerminal = terminalErIssues({
@@ -354,7 +356,7 @@ describe('#Terminal', function terminalTest() {
               faultstring: 'String index out of range: 6',
             });
 
-            await executeCommandWithRetry(command, 0);
+            return executeCommandWithRetry(command, 0);
           },
         }
       });