Remove stale and UB winapi compatibility layer (#256)

With the `windows` migration we introduced a `winapi` compatibility
layer to make it easier to use `winapi` types with `gpu-allocator`.  As
most of the ecosystem has switched to `windows` it is now time to sunset
these helpers which are otherwise tedious to test and maintain, not to
mention contain long(er) standing unsoundness bugs.

Author: MarijnS95

.github/workflows/ci.yml

@@ -32,7 +32,7 @@ jobs:
           - os: ubuntu-latest
             features: vulkan,visualizer
           - os: windows-latest
-            features: vulkan,visualizer,d3d12,public-winapi
+            features: vulkan,visualizer,d3d12
           - os: macos-latest
             features: vulkan,visualizer,metal
     runs-on: ${{ matrix.os }}
@@ -59,7 +59,7 @@ jobs:
           - os: ubuntu-latest
             features: vulkan,visualizer
           - os: windows-latest
-            features: vulkan,visualizer,d3d12,public-winapi
+            features: vulkan,visualizer,d3d12
           - os: macos-latest
             features: vulkan,visualizer,metal
     runs-on: ${{ matrix.os }}

Cargo.toml

@@ -47,10 +47,6 @@ objc2-metal = { version = "0.3", default-features = false, features = [
     "std",
 ], optional = true }
 
-[target.'cfg(windows)'.dependencies]
-# Only needed for public-winapi interop helpers
-winapi = { version = "0.3.9", features = ["d3d12", "winerror", "impl-default", "impl-debug"], optional = true }
-
 [target.'cfg(windows)'.dependencies.windows]
 version = ">=0.53, <=0.61"
 features = [
@@ -64,9 +60,6 @@ optional = true
 ash = { version = "0.38", default-features = false, features = ["debug", "loaded"] }
 env_logger = "0.10"
 
-[target.'cfg(windows)'.dev-dependencies]
-winapi = { version = "0.3.9", features = ["d3d12", "d3d12sdklayers", "dxgi1_6", "winerror", "impl-default", "impl-debug", "winuser", "windowsx", "libloaderapi"] }
-
 [target.'cfg(windows)'.dev-dependencies.windows]
 # API-breaks since Windows 0.58 only affect our examples
 version = ">=0.58, <=0.61"
@@ -85,10 +78,6 @@ objc2-metal = { version = "0.3", default-features = false, features = [
 name = "vulkan-buffer"
 required-features = ["vulkan", "ash/loaded"]
 
-[[example]]
-name = "d3d12-buffer"
-required-features = ["d3d12", "public-winapi"]
-
 [[example]]
 name = "d3d12-buffer-winrs"
 required-features = ["d3d12"]
@@ -102,7 +91,5 @@ visualizer = ["dep:egui", "dep:egui_extras"]
 vulkan = ["dep:ash"]
 d3d12 = ["dep:windows"]
 metal = ["dep:objc2", "dep:objc2-metal", "dep:objc2-foundation"]
-# Expose helper functionality for winapi types to interface with gpu-allocator, which is primarily windows-rs driven
-public-winapi = ["dep:winapi"]
 
 default = ["d3d12", "vulkan", "metal"]

README.md

@@ -19,13 +19,6 @@ gpu-allocator = "0.27.0"
 
 This crate provides a fully written in Rust memory allocator for Vulkan, DirectX 12 and Metal.
 
-## [Windows-rs] and [winapi]
-
-`gpu-allocator` recently migrated from [winapi] to [windows-rs] but still provides convenient helpers to convert to and from [winapi] types, enabled when compiling with the `public-winapi` crate feature.
-
-[Windows-rs]: https://github.com/microsoft/windows-rs
-[winapi]: https://github.com/retep998/winapi-rs
-
 ## Setting up the Vulkan memory allocator
 
 ```rust