🪟 Update to windows 0.58 (#236)

* 🪟 Update to `windows 0.58`

* Address `0.58` API-breaks in example code

* Remove release version bump

* Don't lint all targets (i.e. examples) in `minimal-versions` test

Since the `windows 0.58` upgrade our crate still supports `windows` all
the way back to `0.53`, but the examples use some breaking API changes
that require `0.58`.  This means, also because of using `windows` in the
public API, that it must only be paired with `gpu-allocator` on `0.58`.

---------

Co-authored-by: Marijn Suijten <[email protected]>

Author: Jasper-Bekkers

.github/workflows/ci.yml

@@ -79,7 +79,7 @@ jobs:
           # allowing the 0.0.6 release to be used (but not the 1.0.0 release).
           cargo update -p malloc_buf --precise 0.0.6
       - name: Cargo clippy with minimal-versions
-        run: cargo +stable clippy --workspace --all-targets --features ${{ matrix.features }} --no-default-features -- -D warnings
+        run: cargo +stable clippy --workspace --features ${{ matrix.features }} --no-default-features -- -D warnings
 
   doc:
     name: Build documentation

Cargo.toml

@@ -41,7 +41,7 @@ metal = { version = "0.29.0", default-features = false, features = ["link", "dis
 winapi = { version = "0.3.9", features = ["d3d12", "winerror", "impl-default", "impl-debug"], optional = true }
 
 [target.'cfg(windows)'.dependencies.windows]
-version = ">=0.53,<=0.57"
+version = ">=0.53,<=0.58"
 features = [
     "Win32_Graphics_Direct3D12",
     "Win32_Graphics_Dxgi_Common",
@@ -57,7 +57,8 @@ env_logger = "0.10"
 winapi = { version = "0.3.9", features = ["d3d12", "d3d12sdklayers", "dxgi1_6", "winerror", "impl-default", "impl-debug", "winuser", "windowsx", "libloaderapi"] }
 
 [target.'cfg(windows)'.dev-dependencies.windows]
-version = ">=0.53,<=0.57"
+# API-breaks since Windows 0.58 only affect our examples
+version = "0.58"
 features = [
     "Win32_Graphics_Direct3D",
     "Win32_Graphics_Direct3D12",

examples/d3d12-buffer-winrs.rs

@@ -37,8 +37,7 @@ fn create_d3d12_device(dxgi_factory: &IDXGIFactory6) -> Option<ID3D12Device> {
         };
         let adapter4: IDXGIAdapter4 = adapter1.cast().unwrap();
 
-        let mut desc = Default::default();
-        unsafe { adapter4.GetDesc3(&mut desc) }.unwrap();
+        let desc = unsafe { adapter4.GetDesc3() }.unwrap();
         // Skip software adapters
         // Vote for https://github.com/microsoft/windows-rs/issues/793!
         if (desc.Flags & DXGI_ADAPTER_FLAG3_SOFTWARE) == DXGI_ADAPTER_FLAG3_SOFTWARE {
@@ -86,7 +85,9 @@ fn create_d3d12_device(dxgi_factory: &IDXGIFactory6) -> Option<ID3D12Device> {
 fn main() -> Result<()> {
     env_logger::Builder::from_env(env_logger::Env::default().default_filter_or("trace")).init();
 
-    let dxgi_factory = unsafe { CreateDXGIFactory2(0) }?;
+    let dxgi_factory = unsafe {
+        CreateDXGIFactory2(windows::Win32::Graphics::Dxgi::DXGI_CREATE_FACTORY_FLAGS::default())
+    }?;
 
     let device = create_d3d12_device(&dxgi_factory).expect("Failed to create D3D12 device.");