Skip to content

Commit a8895bd

Browse files
authored
Remove host visible but not host coherent "warning" (#137)
* demote warn to info * remove info altogether
1 parent 937e09a commit a8895bd

File tree

1 file changed

+1
-14
lines changed

1 file changed

+1
-14
lines changed

src/vulkan/mod.rs

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ pub use visualizer::AllocatorVisualizer;
88
use super::allocator;
99
use super::allocator::AllocationType;
1010
use ash::vk;
11-
use log::{debug, warn, Level};
11+
use log::{debug, Level};
1212
use std::fmt;
1313

1414
use crate::{
@@ -536,19 +536,6 @@ impl Allocator {
536536
}
537537
}
538538

539-
// NOTE(manon): Test if there is any HOST_VISIBLE memory that does _not_
540-
// have the HOST_COHERENT flag, in that case we want to panic,
541-
// as we want to do cool things that we do not yet support
542-
// with that type of memory :)
543-
let host_visible_not_coherent = memory_types.iter().any(|t| {
544-
let flags = t.property_flags;
545-
flags.contains(vk::MemoryPropertyFlags::HOST_VISIBLE)
546-
&& !flags.contains(vk::MemoryPropertyFlags::HOST_COHERENT)
547-
});
548-
if host_visible_not_coherent {
549-
warn!("There is a memory type that is host visible, but not host coherent. It's time to upgrade our memory allocator to take advantage of this type of memory :)");
550-
}
551-
552539
let memory_types = memory_types
553540
.iter()
554541
.enumerate()

0 commit comments

Comments
 (0)