Skip to content

Commit 8c4fea6

Browse files
krystian-hebelrossphilipson
authored andcommitted
event_log: move definition of ev_log_hash_t to code
It used to be defined in boot.h, even though it isn't expected to be ever needed anywhere but in code for handling event log internally. Signed-off-by: Krystian Hebel <[email protected]>
1 parent fc97d74 commit 8c4fea6

File tree

2 files changed

+14
-13
lines changed

2 files changed

+14
-13
lines changed

event_log.c

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,15 +107,24 @@ typedef struct __packed {
107107
typedef struct __packed {
108108
u32 pcr;
109109
u32 event_type;
110-
u8 digest[20];
110+
u8 digest[SHA1_DIGEST_SIZE];
111111
u32 event_size;
112112
/* u8 event[]; */
113113
} tpm12_event_t;
114114

115+
/* The same as TPML_DIGEST_VALUES but little endian, as event log expects it */
116+
typedef struct __packed {
117+
u32 count;
118+
u16 sha1_id;
119+
u8 sha1_hash[SHA1_DIGEST_SIZE];
120+
u16 sha256_id;
121+
u8 sha256_hash[SHA256_DIGEST_SIZE];
122+
} ev_log_hash_t;
123+
115124
typedef struct __packed {
116125
u32 pcr;
117126
u32 event_type;
118-
ev_log_hash_t digests; /* defined in boot.h */
127+
ev_log_hash_t digests;
119128
u32 event_size;
120129
/* u8 event[]; */
121130
} tpm20_event_t;
@@ -157,7 +166,7 @@ static const tpm20_spec_id_ev_t tpm20_id_struct = {
157166
.el.next_record_offset = sizeof(tpm20_spec_id_ev_t) + sizeof(tpm12_event_t)
158167
};
159168

160-
int log_event_tpm12(u32 pcr, u8 sha1[20], char *event)
169+
int log_event_tpm12(u32 pcr, u8 sha1[SHA1_DIGEST_SIZE], char *event)
161170
{
162171
tpm12_event_t ev;
163172
tpm12_spec_id_ev_t *base = (tpm12_spec_id_ev_t *)
@@ -178,7 +187,8 @@ int log_event_tpm12(u32 pcr, u8 sha1[20], char *event)
178187
return 1;
179188
}
180189

181-
int log_event_tpm20(u32 pcr, u8 sha1[20], u8 sha256[32], char *event)
190+
int log_event_tpm20(u32 pcr, u8 sha1[SHA1_DIGEST_SIZE],
191+
u8 sha256[SHA256_DIGEST_SIZE], char *event)
182192
{
183193
tpm20_event_t ev;
184194
tpm20_spec_id_ev_t *base = (tpm20_spec_id_ev_t *)

include/boot.h

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -56,15 +56,6 @@ typedef struct __packed skl_info {
5656
} skl_info_t;
5757
extern const skl_info_t skl_info;
5858

59-
/* The same as TPML_DIGEST_VALUES but little endian, as event log expects it */
60-
typedef struct __packed ev_log_hash {
61-
u32 count;
62-
u16 sha1_id;
63-
u8 sha1_hash[20];
64-
u16 sha256_id;
65-
u8 sha256_hash[32];
66-
} ev_log_hash_t;
67-
6859
/* Fences */
6960
#define mb() asm volatile("mfence" : : : "memory")
7061
#define rmb() asm volatile("lfence" : : : "memory")

0 commit comments

Comments
 (0)