chore: qol improvements (#141)

Author: erayarslan

.golangci.yml

@@ -1,38 +1,48 @@
-linters-settings:
-  lll:
-    line-length: 140
-  funlen:
-    lines: 70
-
+version: "2"
 linters:
-  disable-all: true
+  default: none
   enable:
     - bodyclose
-    - errcheck
     - dupl
+    - errcheck
     - exhaustive
     - funlen
     - goconst
     - gocritic
     - gocyclo
-    - gosimple
     - govet
-    - gosec
     - ineffassign
     - lll
     - misspell
     - nakedret
-    - gofumpt
+    - prealloc
     - staticcheck
-    - stylecheck
-    - typecheck
     - unconvert
     - unparam
     - unused
     - whitespace
-    - prealloc
-
-service:
-  golangci-lint-version: 1.55.2 # use the fixed version to not introduce new linters unexpectedly
-  prepare:
-    - echo "here I can run custom commands, but no preparation needed for this repo"
+  settings:
+    funlen:
+      lines: 70
+    lll:
+      line-length: 140
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofumpt
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

Makefile

@@ -3,8 +3,8 @@
 default: init
 
 init:
-	go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.55.2
-	go install golang.org/x/tools/go/analysis/passes/fieldalignment/cmd/fieldalignment@v0.15.0
+	go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.3.0
+	go install golang.org/x/tools/go/analysis/passes/fieldalignment/cmd/fieldalignment@v0.35.0
 
 clean:
 	rm -rf ./build

README.md

@@ -18,6 +18,7 @@ by looking at our [docs](docs/index.md).
     + [Kafka Connector](https://github.com/Trendyol/go-dcp-kafka)
     + [Couchbase Connector](https://github.com/Trendyol/go-dcp-couchbase)
     + [SQL Connector](https://github.com/Trendyol/go-dcp-sql)
+    + [MongoDB Connector](https://github.com/Trendyol/go-dcp-mongodb)
 
 ### Example
 

couchbase/lil_membership.go

@@ -3,6 +3,9 @@ package couchbase
 import (
 	"context"
 	"errors"
+	"sort"
+	"time"
+
 	"github.com/Trendyol/go-dcp/config"
 	"github.com/Trendyol/go-dcp/helpers"
 	"github.com/Trendyol/go-dcp/logger"
@@ -12,8 +15,6 @@ import (
 	"github.com/couchbase/gocbcore/v10"
 	"github.com/couchbase/gocbcore/v10/memd"
 	"github.com/google/uuid"
-	"sort"
-	"time"
 )
 
 type lilCbMembership struct {
@@ -28,7 +29,6 @@ type lilCbMembership struct {
 	lastActiveInstances []Instance
 	instanceAll         []byte
 	id                  []byte
-	clusterJoinTime     int64
 	heartbeatRunning    bool
 	monitorRunning      bool
 }
@@ -59,9 +59,9 @@ func (h *lilCbMembership) register() {
 }
 
 func (h *lilCbMembership) createIndex(ctx context.Context, clusterJoinTime int64) error {
-	var id = string(h.id)
+	id := string(h.id)
 
-	var instance = Instance{
+	instance := Instance{
 		ID:              &id,
 		Type:            _type,
 		HeartbeatTime:   clusterJoinTime,
@@ -107,13 +107,16 @@ func (h *lilCbMembership) heartbeat() {
 	ctx, cancel := context.WithTimeout(context.Background(), h.membershipConfig.Timeout)
 	defer cancel()
 
-	var now = time.Now().UnixNano()
+	now := time.Now().UnixNano()
 
 	payload, _ := sonic.Marshal(now)
 
-	var heartbeatPath = append(append(h.id, '.'), []byte(_heartbeatPath)...)
+	heartbeatPath := append(append(h.id, '.'), []byte(_heartbeatPath)...)
 
-	err := CreatePath(ctx, h.client.GetMetaAgent(), h.scopeName, h.collectionName, h.instanceAll, heartbeatPath, payload, memd.SubdocDocFlagMkDoc)
+	err := CreatePath(
+		ctx, h.client.GetMetaAgent(),
+		h.scopeName, h.collectionName, h.instanceAll, heartbeatPath, payload, memd.SubdocDocFlagMkDoc,
+	)
 	if err != nil {
 		logger.Log.Error("error while heartbeat: %v", err)
 		return

couchbase/observer.go

@@ -102,11 +102,7 @@ func (so *observer) needCatchup(seqNo uint64) bool {
 }
 
 func (so *observer) waitRollbackMitigation(seqNo uint64) {
-	for {
-		if so.checkPersistSeqNo(seqNo) {
-			break
-		}
-
+	for !so.checkPersistSeqNo(seqNo) {
 		time.Sleep(so.config.RollbackMitigation.Interval / 5)
 	}
 }

example/go.mod

@@ -1,78 +1,82 @@
 module example
 
-go 1.24
+go 1.24.0
 
-toolchain go1.24.2
+toolchain go1.24.5
 
 replace github.com/Trendyol/go-dcp => ../.
 
 require github.com/Trendyol/go-dcp v0.0.0
 
 require (
-	github.com/andybalholm/brotli v1.1.1 // indirect
-	github.com/ansrivas/fiberprometheus/v2 v2.7.0 // indirect
+	github.com/andybalholm/brotli v1.2.0 // indirect
+	github.com/ansrivas/fiberprometheus/v2 v2.13.0 // indirect
 	github.com/asaskevich/EventBus v0.0.0-20200907212545-49d423059eef // indirect
 	github.com/beorn7/perks v1.0.1 // indirect
-	github.com/bytedance/sonic v1.12.8 // indirect
-	github.com/bytedance/sonic/loader v0.2.2 // indirect
+	github.com/bytedance/sonic v1.14.0 // indirect
+	github.com/bytedance/sonic/loader v0.3.0 // indirect
 	github.com/cespare/xxhash/v2 v2.3.0 // indirect
 	github.com/cloudwego/base64x v0.1.5 // indirect
 	github.com/couchbase/gocbcore/v10 v10.7.1 // indirect
 	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/emicklei/go-restful/v3 v3.11.0 // indirect
-	github.com/go-logr/logr v1.4.1 // indirect
-	github.com/go-openapi/jsonpointer v0.19.6 // indirect
+	github.com/fxamacker/cbor/v2 v2.7.0 // indirect
+	github.com/go-logr/logr v1.4.3 // indirect
+	github.com/go-openapi/jsonpointer v0.21.0 // indirect
 	github.com/go-openapi/jsonreference v0.20.2 // indirect
-	github.com/go-openapi/swag v0.22.3 // indirect
-	github.com/gofiber/fiber/v2 v2.52.5 // indirect
+	github.com/go-openapi/swag v0.23.0 // indirect
+	github.com/gofiber/fiber/v2 v2.52.9 // indirect
 	github.com/gogo/protobuf v1.3.2 // indirect
-	github.com/golang/protobuf v1.5.4 // indirect
 	github.com/golang/snappy v0.0.4 // indirect
-	github.com/google/gnostic-models v0.6.8 // indirect
-	github.com/google/gofuzz v1.2.0 // indirect
+	github.com/google/gnostic-models v0.6.9 // indirect
+	github.com/google/go-cmp v0.7.0 // indirect
 	github.com/google/uuid v1.6.0 // indirect
-	github.com/gorilla/websocket v1.5.3 // indirect
+	github.com/gorilla/websocket v1.5.4-0.20250319132907-e064f32e3674 // indirect
 	github.com/josharian/intern v1.0.0 // indirect
 	github.com/json-iterator/go v1.1.12 // indirect
-	github.com/klauspost/compress v1.17.11 // indirect
+	github.com/klauspost/compress v1.18.0 // indirect
 	github.com/klauspost/cpuid/v2 v2.0.9 // indirect
 	github.com/mailru/easyjson v0.7.7 // indirect
 	github.com/mattn/go-colorable v0.1.13 // indirect
 	github.com/mattn/go-isatty v0.0.20 // indirect
-	github.com/mattn/go-runewidth v0.0.15 // indirect
+	github.com/mattn/go-runewidth v0.0.16 // indirect
 	github.com/mhmtszr/concurrent-swiss-map v1.0.8 // indirect
 	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
 	github.com/modern-go/reflect2 v1.0.2 // indirect
 	github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
-	github.com/prometheus/client_golang v1.20.5 // indirect
+	github.com/pkg/errors v0.9.1 // indirect
+	github.com/prometheus/client_golang v1.22.0 // indirect
 	github.com/prometheus/client_model v0.6.1 // indirect
-	github.com/prometheus/common v0.58.0 // indirect
+	github.com/prometheus/common v0.62.0 // indirect
 	github.com/prometheus/procfs v0.15.1 // indirect
 	github.com/rivo/uniseg v0.4.7 // indirect
 	github.com/sirupsen/logrus v1.9.3 // indirect
 	github.com/twitchyliquid64/golang-asm v0.15.1 // indirect
 	github.com/valyala/bytebufferpool v1.0.0 // indirect
-	github.com/valyala/fasthttp v1.57.0 // indirect
-	github.com/valyala/tcplisten v1.0.0 // indirect
+	github.com/valyala/fasthttp v1.64.0 // indirect
+	github.com/x448/float16 v0.8.4 // indirect
+	go.opentelemetry.io/otel v1.37.0 // indirect
+	go.opentelemetry.io/otel/trace v1.37.0 // indirect
 	golang.org/x/arch v0.0.0-20210923205945-b76863e36670 // indirect
-	golang.org/x/net v0.33.0 // indirect
-	golang.org/x/oauth2 v0.22.0 // indirect
-	golang.org/x/sync v0.10.0 // indirect
-	golang.org/x/sys v0.28.0 // indirect
-	golang.org/x/term v0.27.0 // indirect
-	golang.org/x/text v0.21.0 // indirect
-	golang.org/x/time v0.3.0 // indirect
-	google.golang.org/protobuf v1.36.4 // indirect
+	golang.org/x/net v0.42.0 // indirect
+	golang.org/x/oauth2 v0.27.0 // indirect
+	golang.org/x/sync v0.16.0 // indirect
+	golang.org/x/sys v0.34.0 // indirect
+	golang.org/x/term v0.33.0 // indirect
+	golang.org/x/text v0.27.0 // indirect
+	golang.org/x/time v0.9.0 // indirect
+	google.golang.org/protobuf v1.36.5 // indirect
+	gopkg.in/evanphx/json-patch.v4 v4.12.0 // indirect
 	gopkg.in/inf.v0 v0.9.1 // indirect
-	gopkg.in/yaml.v2 v2.4.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
-	k8s.io/api v0.29.4 // indirect
-	k8s.io/apimachinery v0.29.4 // indirect
-	k8s.io/client-go v0.29.4 // indirect
-	k8s.io/klog/v2 v2.110.1 // indirect
-	k8s.io/kube-openapi v0.0.0-20231010175941-2dd684a91f00 // indirect
-	k8s.io/utils v0.0.0-20230726121419-3b25d923346b // indirect
-	sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect
-	sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect
-	sigs.k8s.io/yaml v1.3.0 // indirect
+	k8s.io/api v0.33.3 // indirect
+	k8s.io/apimachinery v0.33.3 // indirect
+	k8s.io/client-go v0.33.3 // indirect
+	k8s.io/klog/v2 v2.130.1 // indirect
+	k8s.io/kube-openapi v0.0.0-20250318190949-c8a335a9a2ff // indirect
+	k8s.io/utils v0.0.0-20241104100929-3ea5e8cea738 // indirect
+	sigs.k8s.io/json v0.0.0-20241010143419-9aa6b5e7a4b3 // indirect
+	sigs.k8s.io/randfill v1.0.0 // indirect
+	sigs.k8s.io/structured-merge-diff/v4 v4.6.0 // indirect
+	sigs.k8s.io/yaml v1.4.0 // indirect
 )