feat: go upgrade 1.24 (#93)

ugurcanerdogan · web-flow · commit 31f3467f4eb2 · 2026-02-11T15:25:59.000+03:00
diff --git a/.github/workflows/integration-test.yml b/.github/workflows/integration-test.yml
@@ -11,20 +11,20 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
       - name: Set up Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v4
         with:
-          go-version: 1.19
+          go-version: 1.24
 
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Start containers
         run: make integration-compose
 
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Integration Test
         run: go test -timeout=15m -v test/integration/integration_test.go
         env:
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -13,19 +13,19 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
       - run: git tag ${{ github.event.inputs.tag }}
 
       - name: Set up Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v4
         with:
-          go-version: 1.19
+          go-version: 1.24
 
       - name: Run GoReleaser
-        uses: goreleaser/goreleaser-action@v4
+        uses: goreleaser/goreleaser-action@v5
         with:
           version: latest
           args: release --clean
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -11,22 +11,22 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
       - name: Set up Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v4
         with:
-          go-version: 1.19
+          go-version: 1.24
 
       - name: Install dependencies
         run: go get .
 
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.51
+          version: v1.64.8
           args: -c .golangci.yml --timeout=5m -v
 
       - name: Build
diff --git a/.golangci.yml b/.golangci.yml
@@ -8,7 +8,6 @@ linters:
   disable-all: true
   enable:
     - bodyclose
-    - depguard
     - errcheck
     - dupl
     - exhaustive
@@ -37,7 +36,7 @@ linters:
 issues:
   # Excluding configuration per-path, per-linter, per-text and per-source
   exclude-rules:
-    - path: internal/kafka/
+    - path: internal/
       text: "dot-imports"
       linters:
         - revive
@@ -48,8 +47,3 @@ issues:
       linters:
         - errcheck
         - funlen
-
-service:
-  golangci-lint-version: 1.51.x # use the fixed version to not introduce new linters unexpectedly
-  prepare:
-    - echo "here I can run custom commands, but no preparation needed for this repo"
diff --git a/Makefile b/Makefile
@@ -6,7 +6,7 @@ help:
 ## lint: runs golangci lint based on .golangci.yml configuration
 .PHONY: lint
 lint:
-	@if ! test -f `go env GOPATH`/bin/golangci-lint; then go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.0; fi
+	@if ! test -f `go env GOPATH`/bin/golangci-lint; then go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.64.8; fi
 	golangci-lint run -c .golangci.yml --fix -v
 
 ## test: runs tests
diff --git a/examples/multiple-consumer/go.mod b/examples/multiple-consumer/go.mod
@@ -1,6 +1,6 @@
 module multiple-consumer
 
-go 1.19
+go 1.24
 
 replace github.com/Trendyol/kafka-cronsumer => ../..
 
diff --git a/examples/single-consumer-with-backoff-strategy/go.mod b/examples/single-consumer-with-backoff-strategy/go.mod
@@ -1,6 +1,6 @@
 module single-consumer-with-producer
 
-go 1.19
+go 1.24
 
 replace github.com/Trendyol/kafka-cronsumer => ../..
 
diff --git a/examples/single-consumer-with-custom-logger/go.mod b/examples/single-consumer-with-custom-logger/go.mod
@@ -1,6 +1,6 @@
 module single-consumer-with-custom-logger
 
-go 1.19
+go 1.24
 
 replace github.com/Trendyol/kafka-cronsumer => ../..
 
diff --git a/examples/single-consumer-with-deadletter/go.mod b/examples/single-consumer-with-deadletter/go.mod
@@ -1,6 +1,6 @@
 module single-consumer-with-deadletter
 
-go 1.19
+go 1.24
 
 replace github.com/Trendyol/kafka-cronsumer => ../..
 
diff --git a/examples/single-consumer-with-header-filter-function/go.mod b/examples/single-consumer-with-header-filter-function/go.mod
@@ -1,6 +1,6 @@
 module single-consumer
 
-go 1.19
+go 1.24
 
 replace github.com/Trendyol/kafka-cronsumer => ../..
 
diff --git a/examples/single-consumer-with-metric-collector/go.mod b/examples/single-consumer-with-metric-collector/go.mod
@@ -1,6 +1,6 @@
 module single-consumer-with-custom-logger
 
-go 1.19
+go 1.24
 
 replace github.com/Trendyol/kafka-cronsumer => ../..
 
diff --git a/examples/single-consumer-with-producer/go.mod b/examples/single-consumer-with-producer/go.mod
@@ -1,6 +1,6 @@
 module single-consumer-with-producer
 
-go 1.19
+go 1.24
 
 replace github.com/Trendyol/kafka-cronsumer => ../..
 
diff --git a/examples/single-consumer/go.mod b/examples/single-consumer/go.mod
@@ -1,6 +1,6 @@
 module single-consumer
 
-go 1.19
+go 1.24
 
 replace github.com/Trendyol/kafka-cronsumer => ../..
 
diff --git a/go.mod b/go.mod
@@ -1,6 +1,6 @@
 module github.com/Trendyol/kafka-cronsumer
 
-go 1.19
+go 1.24
 
 require (
 	github.com/prometheus/client_golang v1.16.0
diff --git a/internal/cronsumer_client_test.go b/internal/cronsumer_client_test.go
@@ -23,7 +23,7 @@ func Test_GetMetricsCollector(t *testing.T) {
 			LogLevel: "info",
 		}
 
-		var firstConsumerFn kafka.ConsumeFn = func(message kafka.Message) error {
+		var firstConsumerFn kafka.ConsumeFn = func(_ kafka.Message) error {
 			return nil
 		}
 
@@ -52,7 +52,7 @@ func Test_GetMetricsCollector(t *testing.T) {
 			LogLevel: "info",
 		}
 
-		var firstConsumerFn kafka.ConsumeFn = func(message kafka.Message) error {
+		var firstConsumerFn kafka.ConsumeFn = func(_ kafka.Message) error {
 			return nil
 		}
 
@@ -81,7 +81,7 @@ func Test_GetMetricsCollector(t *testing.T) {
 			LogLevel: "info",
 		}
 
-		var firstConsumerFn kafka.ConsumeFn = func(message kafka.Message) error {
+		var firstConsumerFn kafka.ConsumeFn = func(_ kafka.Message) error {
 			return nil
 		}
 
diff --git a/internal/cronsumer_test.go b/internal/cronsumer_test.go
@@ -25,7 +25,7 @@ func Test_Produce_Max_Retry_Count_Reach(t *testing.T) {
 		Logger:   logger.New("info"),
 	}
 
-	var firstConsumerFn kafka.ConsumeFn = func(message kafka.Message) error {
+	var firstConsumerFn kafka.ConsumeFn = func(_ kafka.Message) error {
 		return nil
 	}
 	c := &cronsumer{
@@ -60,7 +60,7 @@ func Test_Produce_Max_Retry_Count_Reach(t *testing.T) {
 func Test_Produce_Max_Retry_Count_Reach_Dead_Letter_Topic_Feature_Enabled(t *testing.T) {
 	// Given
 
-	var firstConsumerFn kafka.ConsumeFn = func(message kafka.Message) error {
+	var firstConsumerFn kafka.ConsumeFn = func(_ kafka.Message) error {
 		return nil
 	}
 	c := &cronsumer{
@@ -108,7 +108,7 @@ func Test_Produce_With_Retry(t *testing.T) {
 		Logger:   logger.New("info"),
 	}
 
-	var firstConsumerFn kafka.ConsumeFn = func(message kafka.Message) error {
+	var firstConsumerFn kafka.ConsumeFn = func(_ kafka.Message) error {
 		return nil
 	}
 	producer := newMockProducer()
@@ -155,7 +155,7 @@ func Test_Recover_Message(t *testing.T) {
 		Logger:   logger.New("info"),
 	}
 
-	var firstConsumerFn kafka.ConsumeFn = func(message kafka.Message) error {
+	var firstConsumerFn kafka.ConsumeFn = func(_ kafka.Message) error {
 		return nil
 	}
 	producer := newMockProducer()
@@ -196,7 +196,7 @@ type mockConsumer struct{}
 func (c mockConsumer) Stop() {
 }
 
-func (c mockConsumer) ReadMessage(ctx context.Context) (*segmentio.Message, error) {
+func (c mockConsumer) ReadMessage(_ context.Context) (*segmentio.Message, error) {
 	return &segmentio.Message{}, nil
 }
 
@@ -220,15 +220,15 @@ func newMockProducer() mockProducer {
 	}
 }
 
-func (k *mockProducer) ProduceWithRetryOption(message MessageWrapper, increaseRetry bool, increaseRetryAttempt bool) error {
+func (k *mockProducer) ProduceWithRetryOption(_ MessageWrapper, _ bool, _ bool) error {
 	return nil
 }
 
-func (k *mockProducer) Produce(m kafka.Message) error {
+func (k *mockProducer) Produce(_ kafka.Message) error {
 	return nil
 }
 
-func (k *mockProducer) ProduceBatch(messages []kafka.Message) error {
+func (k *mockProducer) ProduceBatch(_ []kafka.Message) error {
 	return nil
 }
 
diff --git a/pkg/kafka/config.go b/pkg/kafka/config.go
@@ -92,6 +92,9 @@ type ProducerConfig struct {
 type SkipMessageByHeaderFn func(headers []Header) bool
 
 func (c *Config) SetDefaults() {
+	if c.Logger == nil {
+		c.Logger = logger.New(c.LogLevel)
+	}
 	if c.Consumer.MaxRetry == 0 {
 		c.Consumer.MaxRetry = 3
 	}
diff --git a/pkg/kafka/config_test.go b/pkg/kafka/config_test.go
@@ -68,8 +68,8 @@ func TestConfig_SetDefaults(t *testing.T) {
 			if !reflect.DeepEqual(tt.expected.Producer, k.Producer) {
 				t.Errorf("Expected: %+v, Actual: %+v", tt.expected.Producer, k.Producer)
 			}
-			if !reflect.DeepEqual(tt.expected.Logger, k.Logger) {
-				t.Errorf("Expected: %+v, Actual: %+v", tt.expected.Logger, k.Logger)
+			if k.Logger == nil {
+				t.Errorf("Expected Logger to be initialized, but got nil")
 			}
 			if !reflect.DeepEqual(tt.expected.LogLevel, k.LogLevel) {
 				t.Errorf("Expected: %+v, Actual: %+v", tt.expected.LogLevel, k.LogLevel)
diff --git a/test/integration/go.mod b/test/integration/go.mod
@@ -1,6 +1,6 @@
 module integration-test-example
 
-go 1.19
+go 1.24
 
 replace github.com/Trendyol/kafka-consumer => ../..
 

-Original file line number
+Diff line change
@@ @@ -1,6 +1,6 @@ @@
 module multiple-consumer
 -go 1.19
 +go 1.24
 replace github.com/Trendyol/kafka-cronsumer => ../..