remake doesn't build with gcc-15

[dkogan]

Hi. There's a build failure with a new compiler:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1097786

Because gcc-15 treats void f(); as void f(void);

Here we're redeclaring getcwd(), and the new behavior makes it look different. I patched it to not redeclare getcwd() at all:

https://salsa.debian.org/debian/remake/-/blob/master/debian/patches/do-not-redeclare-getcwd.patch?ref_type=heads

Probably we shouldn't be redeclaring it.

Thanks

[rocky]

Thanks for reporting and fixing. A couple of things. First, using #ifndef is cleaner than #ifdef #else. Second, the more recent version of remake targets GNU make 4.4 rather than GNU make 4.3. Please consider upgrading to using the 4.4 branch.

Actually, I'll mention one more thing. One difference in this code over GNU make is that we do not attempt to support Vax VMS (much to the annoyance of some vocal Vax VMS users). Therefore, any place we have # ifdefs for VMS can be removed. (I see a few more there, but I left that in for now.)

[bjornfor]

I think this issue can be closed, since the above referenced PRs have been merged.

However, it'd be nice if you can make a release, to more easily fix remake in distros that have upgrade to gcc15.

[rocky]

I think this issue can be closed, since the above referenced PRs have been merged.

However, it'd be nice if you can make a release, to more easily fix remake in distros that have upgrade to gcc15.

@bjornfor Are you the release manager for a particular distro? If so, which one(s)?

Nowadays, I need to be more careful about where I spend the limited time I have on my growing number of projects. So, while in my experience it isn't common for "downstream" people to tag their requests with context and motivation, this kind of thing is often important in helping me decide what to focus on.

I'll mention that the other thing nowadays that motivates me to update projects I work on is giving a talk or workshop at a conference I am attending.

(Pssst..... Tell your conference organizer friends if you aren't one yourself :-))

[bjornfor]

@bjornfor Are you the release manager for a particular distro?

No, I'm just a user/packager of https://github.com/nixos/nixpkgs. I noticed that remake fails to build after nixpkgs switched to gcc15, and came to check what the upstream status was.

I don't know how much time it takes to create a remake release, but you'll save multiple distros from having to manually find and patch the package to keep it building. (nixpkgs has a bot that submits a PR when an upstream makes a new release.)