chore: replace aws-sdk with @types/aws-sdk2-types

This is a second attempt at fixing aws#417. The first attempt was aws#425,
which moved `aws-sdk` from `dependencies` to `devDependencies`. That
change was reverted by aws#535.

The `aws-sdk` dependency is only being used for TypeScript types.
Including it in `dependencies` rather than `devDependencies` ensures
that those types are available to package consumers, at the expense of
bringing in a 100MB+ dependency.

The solution here is to replace the `aws-sdk` dependency with
`@types/aws-sdk2-types`, which is a relatively lightweight 2.3MB. These
types should be identical, as they were pulled directly from `aws-sdk`:
DefinitelyTyped/DefinitelyTyped#64111

I considered inlining the types with dts-bundle-generator, which would
allow `@types/aws-sdk2-types` to be moved to `devDependencies`, but this
turned out to be impractical with the current export structure, since
the types would have to be inlined separately in each `.d.ts` file that
uses them. I would recommend that solution if the package moves to
having a single defined entrypoint in the future (perhaps in the next
major version).

Author: TrevorBurnham

package-lock.json

@@ -40,8 +40,8 @@
         "@opentelemetry/sdk-logs": "^0.200.0",
         "@opentelemetry/sdk-metrics": "^2.0.1",
         "@smithy/node-http-handler": "^4.0.4",
+        "@types/aws-sdk2-types": "^0.0.5",
         "ajv": "^8.17.1",
-        "aws-sdk": "^2.1692.0",
         "hpagent": "^1.2.0",
         "jose": "^5.9.6",
         "mac-ca": "^3.1.1",

runtimes/package.json

@@ -98,8 +98,8 @@ import {
 import { IdentityManagement } from '../server-interface/identity-management'
 import { WebBase64Encoding } from './encoding'
 import { LoggingServer } from './lsp/router/loggingServer'
-import { Service } from 'aws-sdk'
-import { ServiceConfigurationOptions } from 'aws-sdk/lib/service'
+import { Service } from 'aws-sdk2-types'
+import { ServiceConfigurationOptions } from 'aws-sdk2-types/lib/service'
 import { getClientInitializeParamsHandlerFactory } from './util/lspCacheUtil'
 import { newAgent } from './agent'
 import { ShowSaveFileDialogRequestType, CheckDiagnosticsRequestType } from '../protocol/window'

runtimes/runtimes/base-runtime.ts

@@ -87,8 +87,8 @@ import { getServerDataDirPath } from './util/serverDataDirPath'
 import { ProxyConfigManager } from './util/standalone/experimentalProxyUtil'
 import { Encoding } from './encoding'
 import { LoggingServer } from './lsp/router/loggingServer'
-import { Service } from 'aws-sdk'
-import { ServiceConfigurationOptions } from 'aws-sdk/lib/service'
+import { Service } from 'aws-sdk2-types'
+import { ServiceConfigurationOptions } from 'aws-sdk2-types/lib/service'
 import { getTelemetryLspServer } from './util/telemetryLspServer'
 import { getClientInitializeParamsHandlerFactory } from './util/lspCacheUtil'
 import { makeProxyConfigv2Standalone, makeProxyConfigv3Standalone } from './util/standalone/proxyUtil'

runtimes/runtimes/standalone.ts

@@ -7,7 +7,7 @@ import { readFileSync } from 'node:fs'
 import * as tls from 'node:tls'
 import { Agent as HttpsAgent } from 'node:https'
 import { X509Certificate } from 'node:crypto'
-import { ConfigurationOptions } from 'aws-sdk'
+import { ConfigurationOptions } from 'aws-sdk2-types'
 import { HttpsProxyAgent } from 'hpagent'
 import { NodeHttpHandler } from '@smithy/node-http-handler'
 import { readMacosCertificates, readLinuxCertificates, readWindowsCertificates } from './certificatesReaders'

runtimes/runtimes/util/standalone/experimentalProxyUtil.ts

@@ -1,6 +1,6 @@
 import { Workspace } from '../../../server-interface'
 
-import { ConfigurationOptions } from 'aws-sdk'
+import { ConfigurationOptions } from 'aws-sdk2-types'
 import { HttpsProxyAgent } from 'hpagent'
 import { NodeHttpHandler } from '@smithy/node-http-handler'