chore: move aws-sdk to devDependencies (again)

This is a second attempt at aws#425, which fixes aws#417 and was reverted by

The reason for the revert was this claim from @suprajaven:

> The package is currently not declaring a dependency but it is actually
> using aws-sdk. The overall impact is not noted because when used in
> conjunction with language servers package ( which has this dependency
> present) the overall build is not broken.

I believe this is a misunderstanding. The reason the dependency can be
safely moved to `devDependencies` is that all of the references to that
package are actually just importing types, which means they aren't used
at runtime. Here I've made that explicit by changing the `import`
statements to `import type`.

As long as the typechecker doesn't complain about those `import type`
statements, you can feel confident that `aws-sdk` is not needed as a
dependency.

Author: TrevorBurnham

package-lock.json

@@ -41,7 +41,6 @@
         "@opentelemetry/sdk-metrics": "^2.0.1",
         "@smithy/node-http-handler": "^4.0.4",
         "ajv": "^8.17.1",
-        "aws-sdk": "^2.1692.0",
         "hpagent": "^1.2.0",
         "jose": "^5.9.6",
         "mac-ca": "^3.1.1",
@@ -58,6 +57,7 @@
         "@types/node": "^22.15.17",
         "@types/node-forge": "^1.3.11",
         "assert": "^2.0.0",
+        "aws-sdk": "^2.1692.0",
         "copyfiles": "^2.4.1",
         "husky": "^9.1.7",
         "json-schema-to-typescript": "^15.0.4",

runtimes/package.json

@@ -98,7 +98,7 @@ import {
 import { IdentityManagement } from '../server-interface/identity-management'
 import { WebBase64Encoding } from './encoding'
 import { LoggingServer } from './lsp/router/loggingServer'
-import { Service } from 'aws-sdk'
+import type { Service } from 'aws-sdk'
 import { ServiceConfigurationOptions } from 'aws-sdk/lib/service'
 import { getClientInitializeParamsHandlerFactory } from './util/lspCacheUtil'
 import { newAgent } from './agent'

runtimes/runtimes/base-runtime.ts

@@ -87,7 +87,7 @@ import { getServerDataDirPath } from './util/serverDataDirPath'
 import { ProxyConfigManager } from './util/standalone/experimentalProxyUtil'
 import { Encoding } from './encoding'
 import { LoggingServer } from './lsp/router/loggingServer'
-import { Service } from 'aws-sdk'
+import type { Service } from 'aws-sdk'
 import { ServiceConfigurationOptions } from 'aws-sdk/lib/service'
 import { getTelemetryLspServer } from './util/telemetryLspServer'
 import { getClientInitializeParamsHandlerFactory } from './util/lspCacheUtil'

runtimes/runtimes/standalone.ts

@@ -7,7 +7,7 @@ import { readFileSync } from 'node:fs'
 import * as tls from 'node:tls'
 import { Agent as HttpsAgent } from 'node:https'
 import { X509Certificate } from 'node:crypto'
-import { ConfigurationOptions } from 'aws-sdk'
+import type { ConfigurationOptions } from 'aws-sdk'
 import { HttpsProxyAgent } from 'hpagent'
 import { NodeHttpHandler } from '@smithy/node-http-handler'
 import { readMacosCertificates, readLinuxCertificates, readWindowsCertificates } from './certificatesReaders'

runtimes/runtimes/util/standalone/experimentalProxyUtil.ts

@@ -1,6 +1,6 @@
 import { Workspace } from '../../../server-interface'
 
-import { ConfigurationOptions } from 'aws-sdk'
+import type { ConfigurationOptions } from 'aws-sdk'
 import { HttpsProxyAgent } from 'hpagent'
 import { NodeHttpHandler } from '@smithy/node-http-handler'
 

runtimes/runtimes/util/standalone/proxyUtil.ts

@@ -1,4 +1,4 @@
-import { Service } from 'aws-sdk'
+import type { Service } from 'aws-sdk'
 import { ServiceConfigurationOptions } from 'aws-sdk/lib/service'
 
 // aws sdk v2 clients constructor type

runtimes/server-interface/sdk-initializator.ts

@@ -30,7 +30,7 @@ import {
     InitializeParams,
 } from '../protocol'
 import { IdentityManagement } from '../server-interface/identity-management'
-import { Service } from 'aws-sdk'
+import type { Service } from 'aws-sdk'
 import { ServiceConfigurationOptions } from 'aws-sdk/lib/service'
 
 /**