Skip to content

Commit 4655307

Browse files
committed
Merge remote-tracking branch 'origin/feature/typeorm-count-performance' into feature/typeorm-count-performance
2 parents c252b2a + 1b09f2d commit 4655307

File tree

9 files changed

+12
-8
lines changed

9 files changed

+12
-8
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11

2+
# [5.1.0-alpha.1](https://github.com/TriPSs/nestjs-query/compare/v5.1.0-alpha.0...v5.1.0-alpha.1) (2024-02-12)
3+
4+
5+
26
# [5.1.0-alpha.0](https://github.com/TriPSs/nestjs-query/compare/v5.0.0...v5.1.0-alpha.0) (2024-02-12)
37

48

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nestjs-query",
3-
"version": "5.1.0-alpha.0",
3+
"version": "5.1.0-alpha.1",
44
"private": true,
55
"workspaces": [
66
"packages/**"

packages/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@ptc-org/nestjs-query-core",
3-
"version": "5.1.0-alpha.0",
3+
"version": "5.1.0-alpha.1",
44
"description": "Base query package",
55
"author": "doug-martin <[email protected]>",
66
"homepage": "https://github.com/tripss/nestjs-query#readme",

packages/query-graphql/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@ptc-org/nestjs-query-graphql",
3-
"version": "5.1.0-alpha.0",
3+
"version": "5.1.0-alpha.1",
44
"description": "Nestjs graphql query adapter",
55
"author": "doug-martin <[email protected]>",
66
"homepage": "https://github.com/tripss/nestjs-query#readme",

packages/query-mongoose/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@ptc-org/nestjs-query-mongoose",
3-
"version": "5.1.0-alpha.0",
3+
"version": "5.1.0-alpha.1",
44
"description": "Mongoose adapter for @ptc-org/nestjs-query-core",
55
"author": "doug-martin <[email protected]>",
66
"homepage": "https://github.com/tripss/nestjs-query#readme",

packages/query-sequelize/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@ptc-org/nestjs-query-sequelize",
3-
"version": "5.1.0-alpha.0",
3+
"version": "5.1.0-alpha.1",
44
"description": "Sequelize adapter for @ptc-org/nestjs-query-core",
55
"author": "doug-martin <[email protected]>",
66
"homepage": "https://github.com/tripss/nestjs-query#readme",

packages/query-typegoose/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@ptc-org/nestjs-query-typegoose",
3-
"version": "5.1.0-alpha.0",
3+
"version": "5.1.0-alpha.1",
44
"description": "Typegoose adapter for @ptc-org/nestjs-query-core",
55
"author": "john mcinall<[email protected]>",
66
"homepage": "https://github.com/tripss/nestjs-query#readme",

packages/query-typeorm/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@ptc-org/nestjs-query-typeorm",
3-
"version": "5.1.0-alpha.0",
3+
"version": "5.1.0-alpha.1",
44
"description": "Typeorm adapter for @ptc-org/nestjs-query-core",
55
"author": "doug-martin <[email protected]>",
66
"homepage": "https://github.com/tripss/nestjs-query#readme",

packages/query-typeorm/src/services/typeorm-query.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ export class TypeOrmQueryService<Entity>
115115
qb.withDeleted()
116116
}
117117

118-
// Check if we have any relation that could cause the same record to be returned twice, if not than we create
118+
// Check if we have any relation that could cause the same record to be returned twice, if not then we create
119119
// our own count as TypeORM still decides to add "DISTINCT" to it, which makes it slow
120120
if (qb.expressionMap.joinAttributes.some((join) => join.isMany)) {
121121
// If we have relations than do what TypeORM does

0 commit comments

Comments
 (0)