Skip to content

Commit 58b94a9

Browse files
committed
fix: Explicitly mark types in the assemblers files
BREAKING CHANGE: The methods convertToDTO, convertToEntity, convertToCreateEntity, and convertToUpdateEntity now require casting the return value.
1 parent b5c761b commit 58b94a9

File tree

6 files changed

+9
-9
lines changed

6 files changed

+9
-9
lines changed

examples/auth/src/todo-item/todo-item.assembler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { TodoItemEntity } from './todo-item.entity'
66
@Assembler(TodoItemDTO, TodoItemEntity)
77
export class TodoItemAssembler extends ClassTransformerAssembler<TodoItemDTO, TodoItemEntity> {
88
convertToDTO(entity: TodoItemEntity): TodoItemDTO {
9-
const dto = super.convertToDTO(entity)
9+
const dto = super.convertToDTO(entity) as TodoItemDTO
1010
dto.age = Date.now() - entity.created.getMilliseconds()
1111
return dto
1212
}

examples/mongoose/src/todo-item/todo-item.assembler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { TodoItemEntity } from './todo-item.entity'
66
@Assembler(TodoItemDTO, TodoItemEntity)
77
export class TodoItemAssembler extends ClassTransformerAssembler<TodoItemDTO, TodoItemEntity> {
88
convertToDTO(entity: TodoItemEntity): TodoItemDTO {
9-
const dto = super.convertToDTO(entity)
9+
const dto = super.convertToDTO(entity) as TodoItemDTO
1010
dto.age = Date.now() - entity.createdAt.getMilliseconds()
1111
return dto
1212
}

examples/sequelize/src/todo-item/todo-item.assembler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { TodoItemEntity } from './entity/todo-item.entity'
66
@Assembler(TodoItemDTO, TodoItemEntity)
77
export class TodoItemAssembler extends ClassTransformerAssembler<TodoItemDTO, TodoItemEntity> {
88
convertToDTO(entity: TodoItemEntity): TodoItemDTO {
9-
const dto = super.convertToDTO(entity)
9+
const dto = super.convertToDTO(entity) as TodoItemDTO
1010
dto.age = Date.now() - entity.created.getMilliseconds()
1111
return dto
1212
}

examples/typegoose/src/todo-item/todo-item.assembler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { TodoItemEntity } from './todo-item.entity'
66
@Assembler(TodoItemDTO, TodoItemEntity)
77
export class TodoItemAssembler extends ClassTransformerAssembler<TodoItemDTO, TodoItemEntity> {
88
convertToDTO(entity: TodoItemEntity): TodoItemDTO {
9-
const dto = super.convertToDTO(entity)
9+
const dto = super.convertToDTO(entity) as TodoItemDTO
1010
dto.age = Date.now() - entity.createdAt.getMilliseconds()
1111
return dto
1212
}

examples/typeorm/src/todo-item/todo-item.assembler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { TodoItemEntity } from './todo-item.entity'
66
@Assembler(TodoItemDTO, TodoItemEntity)
77
export class TodoItemAssembler extends ClassTransformerAssembler<TodoItemDTO, TodoItemEntity> {
88
convertToDTO(entity: TodoItemEntity): TodoItemDTO {
9-
const dto = super.convertToDTO(entity)
9+
const dto = super.convertToDTO(entity) as TodoItemDTO
1010
dto.age = Date.now() - entity.created.getMilliseconds()
1111
return dto
1212
}

packages/core/src/assemblers/class-transformer.assembler.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ export abstract class ClassTransformerAssembler<DTO, Entity extends DeepPartial<
1717
DeepPartial<DTO>,
1818
DeepPartial<Entity>
1919
> {
20-
public convertToDTO(entity: Entity): DTO {
20+
public convertToDTO(entity: Entity): DTO | Promise<DTO> {
2121
return this.convert(this.DTOClass, this.toPlain(entity))
2222
}
2323

24-
public convertToEntity(dto: DTO): Entity {
24+
public convertToEntity(dto: DTO): Entity | Promise<Entity> {
2525
return this.convert(this.EntityClass, this.toPlain(dto))
2626
}
2727

@@ -37,11 +37,11 @@ export abstract class ClassTransformerAssembler<DTO, Entity extends DeepPartial<
3737
return aggregate as unknown as AggregateResponse<DTO>
3838
}
3939

40-
public convertToCreateEntity(create: DeepPartial<DTO>): DeepPartial<Entity> {
40+
public convertToCreateEntity(create: DeepPartial<DTO>): DeepPartial<Entity> | Promise<DeepPartial<Entity>> {
4141
return this.convert(this.EntityClass, create)
4242
}
4343

44-
public convertToUpdateEntity(create: DeepPartial<DTO>): DeepPartial<Entity> {
44+
public convertToUpdateEntity(create: DeepPartial<DTO>): DeepPartial<Entity> | Promise<DeepPartial<Entity>> {
4545
return this.convert(this.EntityClass, create)
4646
}
4747

0 commit comments

Comments
 (0)