fix: Fix isValidPaging

Author: ValentinVignal

examples/fetch-all-with-negative/e2e/todo-cursor-fetch-all-disable.resolver.spec.ts

@@ -9,7 +9,7 @@ import { TodoItemCursorFetchWithNegativeDisableDTO } from '../src/todo-item/dto/
 import { refresh } from './fixtures'
 import { cursorPageInfoField, edgeNodes, todoItemFields } from './graphql-fragments'
 
-describe('TodoItemResolver (cursor paginatino - fetch all with negative disabled)', () => {
+describe('TodoItemResolver (cursor pagination - fetch all with negative disabled)', () => {
   let app: INestApplication
 
   beforeAll(async () => {

examples/fetch-all-with-negative/e2e/todo-cursor-fetch-all-enable.resolver.spec.ts

@@ -9,7 +9,7 @@ import { TodoItemCursorFetchWithNegativeEnableDTO } from '../src/todo-item/dto/t
 import { refresh, todoItems } from './fixtures'
 import { cursorPageInfoField, edgeNodes, todoItemFields } from './graphql-fragments'
 
-describe('TodoItemResolver (cursor paginatino - fetch all with negative enabled)', () => {
+describe('TodoItemResolver (cursor pagination - fetch all with negative enabled)', () => {
   let app: INestApplication
 
   beforeAll(async () => {

examples/init-scripts/mysql/init-fetch-all-with-negative.sql

@@ -0,0 +1,5 @@
+CREATE
+USER fetch_all_with_negative;
+CREATE
+DATABASE fetch_all_with_negative;
+GRANT ALL PRIVILEGES ON fetch_all_with_negative.* TO fetch_all_with_negative;

packages/query-graphql/src/types/connection/cursor/pager/pager.ts

@@ -37,11 +37,16 @@ export class CursorPager<DTO> implements Pager<DTO, CursorPagerResult<DTO>> {
 
   private isValidPaging(pagingMeta: PagingMeta<DTO, CursorPagingOpts<DTO>>): boolean {
     const minimumLimit = this.enableFetchAllWithNegative ? -1 : 1
+    const hasLimit = 'limit' in pagingMeta.opts && pagingMeta.opts.limit !== null
     const isValidLimit = pagingMeta.opts.limit >= minimumLimit
+    if (hasLimit && !isValidLimit) {
+      return false
+    }
+
     if ('offset' in pagingMeta.opts) {
-      return pagingMeta.opts.offset > 0 && isValidLimit
+      return pagingMeta.opts.offset > 0 || hasLimit
     }
-    return isValidLimit
+    return hasLimit
   }
 
   private async runQuery<Q extends Query<DTO>>(