Skip to content

Commit a8b2b04

Browse files
authored
fix(strapi): Use peerDependencies for @strapi/strapi versioning (#401)
- Updated `strapiVersion` to reference `peerDependencies` instead of `dependencies`. - Moved `@strapi/strapi` from `dependencies` to `peerDependencies` in `package.json`. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated the Strapi version used by the project to 4.25.24. * Switched Strapi from a bundled runtime dependency to a peer dependency to improve dependency management. * Added Strapi to dev tooling to ensure consistent development environment. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
2 parents d10437c + 1f32ea4 commit a8b2b04

File tree

4 files changed

+1348
-1038
lines changed

4 files changed

+1348
-1038
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@
5858
"@nx/webpack": "21.6.4",
5959
"@pulumi/gcp": "^9.3.0",
6060
"@pulumi/pulumi": "^3.201.0",
61+
"@strapi/strapi": "4.25.24",
6162
"@types/jest": "30.0.0",
6263
"@types/node": "22.9.3",
6364
"@types/shelljs": "^0.8.16",

packages/strapi/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@
1616
"license": "MIT",
1717
"main": "src/index.js",
1818
"dependencies": {
19-
"@strapi/generate-new": "4.25.23",
20-
"@strapi/strapi": "4.25.11"
19+
"@strapi/generate-new": "4.25.23"
2120
},
2221
"peerDependencies": {
23-
"@nx/devkit": "^21.0.0"
22+
"@nx/devkit": "^21.0.0",
23+
"@strapi/strapi": "^4.25.24"
2424
},
2525
"builders": "./executors.json",
2626
"generators": "./generators.json"

packages/strapi/src/generators/init/init.impl.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ import * as path from 'path'
1616

1717
import type { StrapiGeneratorSchema } from './schema'
1818

19-
import packageJson from '../../../package.json'
20-
2119
// Base off https://github.com/strapi/strapi/blob/main/packages/generators/app/src/index.ts#L19
2220
function generateStrapi(options: NormalizedSchema) {
2321
return generateNew({
@@ -26,7 +24,7 @@ function generateStrapi(options: NormalizedSchema) {
2624
// disable quickstart run app after creation
2725
runQuickstartApp: false,
2826
// use package.json version as strapiVersion (all packages have the same version);
29-
strapiVersion: packageJson.dependencies['@strapi/strapi'],
27+
strapiVersion: '4.25.24',
3028
debug: false,
3129
quick: true,
3230
packageJsonStrapi: {

0 commit comments

Comments
 (0)