Skip to content

Commit 8bd4b82

Browse files
authored
Merge pull request kubernetes-sigs#452 from yurrriq/helm-extra-args
Add support for --extra-tags to Helm chart
2 parents 65a4517 + e302bc4 commit 8bd4b82

File tree

5 files changed

+32
-7
lines changed

5 files changed

+32
-7
lines changed

charts/aws-fsx-csi-driver/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# Helm chart
22

3+
# v1.12.1
4+
* Parameterize controller.extraTags
5+
36
# v1.12.0
47
* Use driver image 1.5.0
58

charts/aws-fsx-csi-driver/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
appVersion: "1.5.0"
33
name: aws-fsx-csi-driver
44
description: A Helm chart for AWS FSx for Lustre CSI Driver
5-
version: 1.12.0
5+
version: 1.12.1
66
kubeVersion: ">=1.17.0-0"
77
home: https://github.com/kubernetes-sigs/aws-fsx-csi-driver
88
sources:

charts/aws-fsx-csi-driver/templates/_helpers.tpl

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,3 +54,16 @@ app.kubernetes.io/name: {{ include "aws-fsx-csi-driver.name" . }}
5454
app.kubernetes.io/instance: {{ .Release.Name }}
5555
{{- end }}
5656
{{- end -}}
57+
58+
{{/*
59+
Prepare the `--extra-tags` controller flag from a map.
60+
*/}}
61+
{{- define "aws-fsx-csi-driver.extra-tags" -}}
62+
{{- $extraTags := list -}}
63+
{{- range $key, $value := .Values.controller.extraTags -}}
64+
{{- $extraTags = printf "%s=%v" $key $value | append $extraTags -}}
65+
{{- end -}}
66+
{{- if $extraTags -}}
67+
{{- printf "- \"--extra-tags=%s\"" (join "," $extraTags) -}}
68+
{{- end -}}
69+
{{- end -}}

charts/aws-fsx-csi-driver/templates/controller-deployment.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@ spec:
4444
args:
4545
- --mode={{ .Values.controller.mode }}
4646
- --endpoint=$(CSI_ENDPOINT)
47+
{{- if .Values.controller.extraTags }}
48+
{{- include "aws-fsx-csi-driver.extra-tags" . | nindent 12 }}
49+
{{- end }}
4750
- --logging-format={{ .Values.controller.loggingFormat }}
4851
- --v={{ .Values.controller.logLevel }}
4952
env:

charts/aws-fsx-csi-driver/values.yaml

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ sidecars:
3131
tag: v2.13.0-eks-1-33-9
3232
pullPolicy: IfNotPresent
3333
logLevel: 2
34-
resources:
34+
resources:
3535
requests:
3636
cpu: 10m
3737
memory: 32Mi
@@ -46,7 +46,7 @@ sidecars:
4646
tag: v5.2.0-eks-1-33-9
4747
pullPolicy: IfNotPresent
4848
logLevel: 2
49-
resources:
49+
resources:
5050
requests:
5151
cpu: 10m
5252
memory: 32Mi
@@ -61,7 +61,7 @@ sidecars:
6161
tag: v1.13.2-eks-1-33-9
6262
pullPolicy: IfNotPresent
6363
logLevel: 2
64-
resources:
64+
resources:
6565
requests:
6666
cpu: 10m
6767
memory: 32Mi
@@ -133,11 +133,17 @@ controller:
133133
# - maxSkew: 1
134134
# topologyKey: kubernetes.io/hostname
135135
# whenUnsatisfiable: ScheduleAnyway
136-
topologySpreadConstraints: []
136+
topologySpreadConstraints: []
137137
podDisruptionBudget:
138138
# Warning: Disabling PodDisruptionBudget may lead to delays in stateful workloads starting due to controller
139139
# pod restarts or evictions.
140140
enabled: true
141+
# Extra tags to attach to each dynamically provisioned file system.
142+
# ---
143+
# extraTags:
144+
# key1: value1
145+
# key2: value2
146+
extraTags: {}
141147

142148
node:
143149
mode: node
@@ -193,8 +199,8 @@ node:
193199
operator: NotIn
194200
values:
195201
- fargate
196-
- hybrid
197-
202+
- hybrid
203+
198204
nameOverride: ""
199205
fullnameOverride: ""
200206

0 commit comments

Comments
 (0)