feat(code): proper search for read-only notes

Author: eliandoran

apps/client/src/widgets/find.ts

@@ -247,16 +247,16 @@ export default class FindWidget extends NoteContextAwareWidget {
     }
 
     async getHandler() {
-        if (this.note?.type === "render") {
-            return this.htmlHandler;
-        }
-
-        const readOnly = await this.noteContext?.isReadOnly();
-
-        if (readOnly) {
-            return this.htmlHandler;
-        } else {
-            return this.note?.type === "code" ? this.codeHandler : this.textHandler;
+        switch (this.note?.type) {
+            case "render":
+                return this.htmlHandler;
+            case "code":
+                return this.codeHandler;
+            case "text":
+                return this.textHandler;
+            default:
+                const readOnly = await this.noteContext?.isReadOnly();
+                return readOnly ? this.htmlHandler : this.textHandler;
         }
     }
 

apps/client/src/widgets/type_widgets/abstract_code_type_widget.ts

@@ -99,6 +99,16 @@ export default class AbstractCodeTypeWidget extends TypeWidget {
         }
     }
 
+    async executeWithCodeEditorEvent({ resolve, ntxId }: EventData<"executeWithCodeEditor">) {
+        if (!this.isNoteContext(ntxId)) {
+            return;
+        }
+
+        await this.initialized;
+
+        resolve(this.codeEditor);
+    }
+
     async entitiesReloadedEvent({ loadResults }: EventData<"entitiesReloaded">) {
         if (loadResults.isOptionReloaded("codeNoteTheme")) {
             const themeId = options.get("codeNoteTheme");

apps/client/src/widgets/type_widgets/editable_code.ts

@@ -71,16 +71,6 @@ export default class EditableCodeTypeWidget extends AbstractCodeTypeWidget {
         };
     }
 
-    async executeWithCodeEditorEvent({ resolve, ntxId }: EventData<"executeWithCodeEditor">) {
-        if (!this.isNoteContext(ntxId)) {
-            return;
-        }
-
-        await this.initialized;
-
-        resolve(this.codeEditor);
-    }
-
     buildTouchBarCommand({ TouchBar, buildIcon }: CommandListenerData<"buildTouchBar">) {
         const items: TouchBarItem[] = [];
         const note = this.note;