Skip to content
This repository was archived by the owner on Jun 24, 2025. It is now read-only.

Commit 4adaf97

Browse files
committed
feat(signing): improve error logging in case of error
1 parent 1abcf72 commit 4adaf97

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

apps/desktop/electron-forge/sign-windows.cjs

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,14 @@ module.exports = function (filePath) {
1717
}
1818

1919
const command = `${WINDOWS_SIGN_EXECUTABLE} --executable "${filePath}"`;
20-
console.log(`[Sign] ${command}`);
20+
console.log(`[Sign] Running ${command}`);
2121

22-
const output = child_process.execSync(command);
23-
console.log(`[Sign] ${output}`);
22+
try {
23+
child_process.execSync(command);
24+
} catch (e) {
25+
console.warn(`[Sign] Unable to sign ${filePath} due to:\n${e.stdout.toString("utf-8")})}`)
26+
return;
27+
}
28+
29+
console.log(`[Sign] Signed ${filePath} successfully.`);
2430
}

0 commit comments

Comments
 (0)