fix(tab_manager): correct order when reopening tabs

SiriusXT · SiriusXT · commit 4afea27fa526 · 2025-11-17T21:00:27.000+08:00
diff --git a/apps/client/src/widgets/tab_row.ts b/apps/client/src/widgets/tab_row.ts
@@ -820,12 +820,15 @@ export default class TabRowWidget extends BasicWidget {
     }
 
     contextsReopenedEvent({ mainNtxId, tabPosition }: EventData<"contextsReopened">) {
-        if (!mainNtxId || !tabPosition) {
+        if (!mainNtxId || tabPosition < 0) {
             // no tab reopened
             return;
         }
         const tabEl = this.getTabById(mainNtxId)[0];
-        tabEl.parentNode?.insertBefore(tabEl, this.tabEls[tabPosition]);
+
+        if ( tabEl && tabEl.parentNode ){
+            tabEl.parentNode.insertBefore(tabEl, this.tabEls[tabPosition]);
+        }
     }
 
     updateTabById(ntxId: string | null) {

Original file line number	Diff line number	Diff line change
`@@ -820,12 +820,15 @@ export default class TabRowWidget extends BasicWidget {`
`820`	`820`	`}`
`821`	`821`
`822`	`822`	`contextsReopenedEvent({ mainNtxId, tabPosition }: EventData<"contextsReopened">) {`
`823`		`- if (!mainNtxId \|\| !tabPosition) {`
	`823`	`+ if (!mainNtxId \|\| tabPosition < 0) {`
`824`	`824`	`// no tab reopened`
`825`	`825`	`return;`
`826`	`826`	`}`
`827`	`827`	`const tabEl = this.getTabById(mainNtxId)[0];`
`828`		`- tabEl.parentNode?.insertBefore(tabEl, this.tabEls[tabPosition]);`
	`828`	`+`
	`829`	`+ if ( tabEl && tabEl.parentNode ){`
	`830`	`+ tabEl.parentNode.insertBefore(tabEl, this.tabEls[tabPosition]);`
	`831`	`+ }`
`829`	`832`	`}`
`830`	`833`
`831`	`834`	`updateTabById(ntxId: string \| null) {`