fix(note_autocomplete): fix attributes not linking

Author: Jakob Schlanstedt

apps/client/src/services/note_autocomplete.ts

@@ -463,65 +463,103 @@ function initNoteAutocomplete($el: JQuery<HTMLElement>, options?: Options) {
 
     // TODO: Types fail due to "autocomplete:selected" not being registered in type definitions.
     ($el as any).on("autocomplete:selected", async (event: Event, suggestion: Suggestion) => {
+        $el.setSelectedNotePath(suggestion.notePath);
+        $el.setSelectedExternalLink(null);
+        $el.autocomplete("val", suggestion.noteTitle);
+
         switch (suggestion.action) {
             case SuggestionAction.Command: {
-                $el.autocomplete("close");
-                $el.trigger("autocomplete:commandselected", [suggestion]);
                 break;
             }
 
             case SuggestionAction.ExternalLink: {
-                $el.setSelectedNotePath(null);
-                $el.setSelectedExternalLink(suggestion.externalLink);
-                $el.autocomplete("val", suggestion.externalLink);
-                $el.autocomplete("close");
-                $el.trigger("autocomplete:externallinkselected", [suggestion]);
                 break;
             }
 
-            case SuggestionAction.CreateNoteIntoInbox:
-            case SuggestionAction.CreateAndLinkNoteIntoInbox: {
+            // --- CREATE NOTE INTO INBOX ---
+            case SuggestionAction.CreateNoteIntoInbox: {
                 const { note } = await noteCreateService.createNote(
                     {
                         target: "inbox",
                         title: suggestion.noteTitle,
                         activate: true,
                         promptForType: true,
-                    } as CreateNoteIntoInboxOpts
+                    }
                 );
 
-                if (!note) return;
+                if (!note)
+                    break;
 
                 const hoistedNoteId = appContext.tabManager.getActiveContext()?.hoistedNoteId;
                 suggestion.notePath = note?.getBestNotePathString(hoistedNoteId);
-
-                $el.trigger("autocomplete:noteselected", [suggestion]);
-                $el.autocomplete("close");
                 break;
             }
 
-            case SuggestionAction.CreateNoteIntoPath:
-            case SuggestionAction.CreateAndLinkNoteIntoPath: {
-                if (!suggestion.parentNoteId) return;
+            case SuggestionAction.CreateAndLinkNoteIntoInbox: {
+                const { note } = await noteCreateService.createNote(
+                    {
+                        target: "inbox",
+                        title: suggestion.noteTitle,
+                        activate: false,
+                        promptForType: true,
+                    }
+                );
+
+                if (!note)
+                    break;
+
+                const hoistedNoteId = appContext.tabManager.getActiveContext()?.hoistedNoteId;
+                suggestion.notePath = note?.getBestNotePathString(hoistedNoteId);
+
+                $el.autocomplete("close");
+                $el.trigger("autocomplete:noteselected", [suggestion]);
+                return;
+            }
 
+            case SuggestionAction.CreateNoteIntoPath: {
+                if (!suggestion.parentNoteId) {
+                    console.warn("Missing parentNoteId for CreateNoteIntoPath");
+                    return;
+                }
                 const { note } = await noteCreateService.createNote(
                     {
-                        parentNoteUrl: suggestion.parentNoteId,
                         target: "into",
+                        parentNoteUrl: suggestion.parentNoteId,
                         title: suggestion.noteTitle,
                         activate: true,
                         promptForType: true,
                     },
                 );
 
-                if (!note) return;
+                if (!note) break;
 
                 const hoistedNoteId = appContext.tabManager.getActiveContext()?.hoistedNoteId;
                 suggestion.notePath = note?.getBestNotePathString(hoistedNoteId);
+                break;
+            }
 
-                $el.trigger("autocomplete:noteselected", [suggestion]);
+            case SuggestionAction.CreateAndLinkNoteIntoPath: {
+                if (!suggestion.parentNoteId) {
+                    console.warn("Missing parentNoteId for CreateNoteIntoPath");
+                    return;
+                }
+                const { note } = await noteCreateService.createNote(
+                    {
+                        target: "into",
+                        parentNoteUrl: suggestion.parentNoteId,
+                        title: suggestion.noteTitle,
+                        activate: false,
+                        promptForType: true,
+                    }
+                );
+
+                if (!note) break;
+
+                const hoistedNoteId = appContext.tabManager.getActiveContext()?.hoistedNoteId;
+                suggestion.notePath = note?.getBestNotePathString(hoistedNoteId);
                 $el.autocomplete("close");
-                break;
+                $el.trigger("autocomplete:noteselected", [suggestion]);
+                return;
             }
 
             case SuggestionAction.SearchNotes: {
@@ -531,13 +569,12 @@ function initNoteAutocomplete($el: JQuery<HTMLElement>, options?: Options) {
             }
 
             default: {
-                $el.setSelectedNotePath(suggestion.notePath);
-                $el.setSelectedExternalLink(null);
-                $el.autocomplete("val", suggestion.noteTitle);
-                $el.autocomplete("close");
-                $el.trigger("autocomplete:noteselected", [suggestion]);
             }
         }
+        if (suggestion.notePath) {
+            $el.trigger("autocomplete:noteselected", [suggestion]);
+        }
+        $el.autocomplete("close");
     });
 
     $el.on("autocomplete:closed", () => {

apps/client/src/widgets/ribbon/components/AttributeEditor.tsx

@@ -258,26 +258,26 @@ export default function AttributeEditor({ api, note, componentId, notePath, ntxI
             parentNotePath: string | undefined,
             action: CreateNoteAction
         ): Promise<string> => {
-            if (!parentNotePath) {
-                console.warn("Missing parentNotePath in createNoteFromCkEditor()");
-                return "";
-            }
-
             switch (action) {
                 case CreateNoteAction.CreateNoteIntoInbox:
                 case CreateNoteAction.CreateAndLinkNoteIntoInbox: {
                     const { note } = await note_create.createNote(
                         {
                             target: "inbox",
                             title,
-                            activate: false
+                            activate: false,
+                            promptForType: true,
                         }
                     );
                     return note?.getBestNotePathString() ?? "";
                 }
 
                 case CreateNoteAction.CreateNoteIntoPath:
                 case CreateNoteAction.CreateAndLinkNoteIntoPath: {
+                    if (!parentNotePath) {
+                        console.warn("Missing parentNotePath in createNoteFromCkEditor()");
+                        return "";
+                    }
                     const resp = await note_create.createNote(
                         {
                             target: "into",

apps/client/src/widgets/type_widgets/editable_text.ts

@@ -500,42 +500,6 @@ export default class EditableTextTypeWidget extends AbstractTextTypeWidget {
     ): Promise<string> {
         try {
             switch (action) {
-                // --- Create note INTO inbox ---
-                case CreateNoteAction.CreateNoteIntoInbox: {
-                    const { note } = await note_create.createNote(
-                        {
-                            target: "inbox",
-                            title,
-                            activate: true,
-                            promptForType: true,
-                        }
-                    );
-
-                    return note?.getBestNotePathString() ?? "";
-                }
-
-                // --- Create note INTO current path ---
-                case CreateNoteAction.CreateNoteIntoPath: {
-                    // This should be impossible but we must specify it anyways
-                    // because it might cause bugs, which the type-check from
-                    // createNote already catches
-                    if (!parentNotePath) {
-                        console.error("Cannot create note: parentNotePath is undefined.");
-                        return "";
-                    }
-                    const { note } = await note_create.createNote(
-                        {
-                            target: "into",
-                            parentNoteUrl: parentNotePath,
-                            title,
-                            activate: true,
-                            promptForType: true,
-                        }
-                    )
-
-                    return note?.getBestNotePathString() ?? "";
-                }
-
                 // --- Create & link note INTO inbox ---
                 case CreateNoteAction.CreateAndLinkNoteIntoInbox: {
                     const { note } = await noteCreateService.createNote(
@@ -570,7 +534,7 @@ export default class EditableTextTypeWidget extends AbstractTextTypeWidget {
                 }
 
                 default:
-                    console.warn("Unknown CreateNoteAction:", action);
+                    console.warn("impossible CreateNoteAction state:", action);
                     return "";
             }
         } catch (err) {