feat(board/promoted_attributes): render non-promoted attribute defs too

Author: eliandoran

apps/client/src/entities/fnote.ts

@@ -839,8 +839,7 @@ export default class FNote {
             return [];
         }
 
-        const promotedAttrs = this.getAttributes()
-            .filter((attr) => attr.isDefinition())
+        const promotedAttrs = this.getAttributeDefinitions()
             .filter((attr) => {
                 const def = attr.getDefinition();
 
@@ -860,6 +859,11 @@ export default class FNote {
         return promotedAttrs;
     }
 
+    getAttributeDefinitions() {
+        return this.getAttributes()
+            .filter((attr) => attr.isDefinition());
+    }
+
     hasAncestor(ancestorNoteId: string, followTemplates = false, visitedNoteIds: Set<string> | null = null) {
         if (this.noteId === ancestorNoteId) {
             return true;

apps/client/src/widgets/attribute_widgets/PromotedAttributesDisplay.tsx

@@ -91,7 +91,7 @@ function formatRelation(attr: AttributeWithDefinitions): ComponentChildren {
 }
 
 function getAttributesWithDefinitions(note: FNote, attributesToIgnore: string[] = []): AttributeWithDefinitions[] {
-    const promotedDefinitionAttributes = note.getPromotedDefinitionAttributes();
+    const promotedDefinitionAttributes = note.getAttributeDefinitions();
     const result: AttributeWithDefinitions[] = [];
     for (const attr of promotedDefinitionAttributes) {
         const def = attr.getDefinition();