fix(export/share): assets incorrectly rewritten

eliandoran · eliandoran · commit ba26c478d6aa · 2025-10-26T12:15:35.000+02:00
diff --git a/apps/server/src/services/export/zip/share_theme.ts b/apps/server/src/services/export/zip/share_theme.ts
@@ -52,7 +52,10 @@ export default class ShareThemeExportProvider extends ZipExportProvider {
         if (note) {
             content = renderNoteForExport(note, branch, basePath, noteMeta.notePath.slice(0, -1));
             if (typeof content === "string") {
-                content = content.replace(/href="[^"]*\.\/([a-zA-Z0-9_\/]{12})[^"]*"/g, "href=\"#root/$1\"");
+                content = content.replace(/href="[^"]*\.\/([a-zA-Z0-9_\/]{12})[^"]*"/g, (match, id) => {
+                    if (match.includes("/assets/")) return match;
+                    return `href="#root/${id}"`;
+                });
                 content = this.rewriteFn(content, noteMeta);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,10 @@ export default class ShareThemeExportProvider extends ZipExportProvider {`
`52`	`52`	`if (note) {`
`53`	`53`	`content = renderNoteForExport(note, branch, basePath, noteMeta.notePath.slice(0, -1));`
`54`	`54`	`if (typeof content === "string") {`
`55`		`- content = content.replace(/href="[^"]\.\/([a-zA-Z0-9_\/]{12})[^"]"/g, "href=\"#root/$1\"");`
	`55`	`+ content = content.replace(/href="[^"]\.\/([a-zA-Z0-9_\/]{12})[^"]"/g, (match, id) => {`
	`56`	`+ if (match.includes("/assets/")) return match;`
	`57`	+ return `href="#root/${id}"`;
	`58`	`+ });`
`56`	`59`	`content = this.rewriteFn(content, noteMeta);`
`57`	`60`	`}`
`58`	`61`	`}`