fix(collections): children warning stuck when changing view mode

eliandoran · eliandoran · commit d1d1d05ce7da · 2025-11-18T08:39:58.000+02:00
diff --git a/apps/client/src/widgets/type_widgets/Book.tsx b/apps/client/src/widgets/type_widgets/Book.tsx
@@ -16,7 +16,7 @@ export default function Book({ note }: TypeWidgetProps) {
         setShouldDisplayNoChildrenWarning(!note.hasChildren() && VIEW_TYPES.includes(viewType ?? ""));
     }
 
-    useEffect(refresh, [ note ]);
+    useEffect(refresh, [ note, viewType ]);
     useTriliumEvent("entitiesReloaded", ({ loadResults }) => {
         if (loadResults.getBranchRows().some(branchRow => branchRow.parentNoteId === note.noteId)) {
             refresh();

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ export default function Book({ note }: TypeWidgetProps) {`
`16`	`16`	`setShouldDisplayNoChildrenWarning(!note.hasChildren() && VIEW_TYPES.includes(viewType ?? ""));`
`17`	`17`	`}`
`18`	`18`
`19`		`- useEffect(refresh, [ note ]);`
	`19`	`+ useEffect(refresh, [ note, viewType ]);`
`20`	`20`	`useTriliumEvent("entitiesReloaded", ({ loadResults }) => {`
`21`	`21`	`if (loadResults.getBranchRows().some(branchRow => branchRow.parentNoteId === note.noteId)) {`
`22`	`22`	`refresh();`