fix(share): HTML tags displayed escaped in headings

Author: eliandoran

apps/server/src/services/utils.ts

@@ -497,7 +497,7 @@ export function formatSize(size: number | null | undefined) {
     }
 }
 
-export function slugify(text: string) {
+function slugify(text: string) {
     return text
         .normalize("NFKD") // handles accents like é → e
         .toLowerCase()
@@ -540,6 +540,7 @@ export default {
     safeExtractMessageAndStackFromError,
     sanitizeSqlIdentifier,
     stripTags,
+    slugify,
     timeLimit,
     toBase64,
     toMap,

apps/server/src/share/routes.ts

@@ -14,7 +14,7 @@ import log from "../services/log.js";
 import type SNote from "./shaca/entities/snote.js";
 import type SBranch from "./shaca/entities/sbranch.js";
 import type SAttachment from "./shaca/entities/sattachment.js";
-import utils, { isDev, safeExtractMessageAndStackFromError, slugify } from "../services/utils.js";
+import utils, { isDev, safeExtractMessageAndStackFromError } from "../services/utils.js";
 import options from "../services/options.js";
 import { t } from "i18next";
 import ejs from "ejs";
@@ -176,7 +176,7 @@ function register(router: Router) {
             showLoginInShareTheme,
             t,
             isDev,
-            slugify
+            utils
         };
         let useDefaultView = true;
 

packages/share-theme/src/templates/page.ejs

@@ -91,7 +91,8 @@ const themeClass = currentTheme === "light" ? " theme-light" : " theme-dark";
 const headingRe = /(<h[1-6]>)(.+?)(<\/h[1-6]>)/g;
 const headingMatches = [...content.matchAll(headingRe)];
 content = content.replaceAll(headingRe, (...match) => {
-    match[0] = match[0].replace(match[3], `<a id="${slugify(match[2])}" class="toc-anchor" name="${slugify(match[2])}" href="#${slugify(match[2])}">#</a>${match[3]}`);
+    const slug = utils.slugify(utils.stripTags(match[2]));
+    match[0] = match[0].replace(match[3], `<a id="${slug}" class="toc-anchor" name="${slug}" href="#${slug}">#</a>${match[3]}`);
     return match[0];
 });
 %>

packages/share-theme/src/templates/toc_item.ejs

@@ -1,11 +1,11 @@
 <%
-const slug = slugify(entry.name);
+const strippedName = utils.stripTags(entry.name);
+const slug = utils.slugify(strippedName);
 %>
 
-
 <li>
     <a href="#<%= slug %>">
-        <span><%= entry.name %></span>
+        <span><%= strippedName %></span>
     </a>
 
     <% if (entry.children.length) { %>