-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
client/pageurl: migrate note origin to info bar #7734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8024b28 to
6fe0b20
Compare
6fe0b20 to
5aec922
Compare
|
@SiriusXT Showing pageUrl always is a bad move. You are stealing scarce vertical space on a desktop with no gain in a return. |
|
@contributor In the original ribbon, having a page URL would take up vertical space by default. |
@SiriusXT In your PR, it is displayed on EVERY tab of the ribbon
It still consumes space when you don't scroll. Update: hiding it when with scroll is good one, I was too quick with "no gain" statement |
|
Aha, it seems you prefer the original way. |
Last time I've checked there's no ribbon on mobile. |
Rigth.The screenshots are from my build. No ribbon in the official release, but there is no reason not to have one. I could send a PR |
|
@contributor This CSS is quite helpful: When Note Info is displayed, the Info bar becomes fixed. |
|
By the way, current Edit Note bar already has the same problem (even worse) of losing context/scroll position as new pageUrl will have. Here is the problem: You reading a long read-only note, found a small type, want to fix, and… Now you can't. Or rather don't want to bother with going up, turning on edit mode, and the FINDING the place to edit. I'm getting “atlassian confluence" flashbacks, when you were supposed to used it on a work, but UX was unbearable exactly because of this friction to turn on edit mode and then go back and find the place you wanted to edit in a huge document/table Previous floating edit button was perfect. Maybe even unique in this regard with its scroll to previous (almost exact) position feature. Heck, even github does n't have this, which kinda forces me to keep an issue text or comment small enough to have New bar is not good for all of the cases:
|
|
The existence of two ribbon tabs that both use an info icon is confusing, and it’s an issue that should be addressed. This could be resolved either by using an info bar, as @SiriusXT suggested, or by moving it to the “Note Info” tab. I don’t see any reason for the origin URL to have its own dedicated ribbon tab. |
The previous floating edit button had a flaw. For new users, it wasn’t immediately clear that a note was read-only, how to edit it, or why it had become read-only in the first place. That’s why I introduced the Edit Note bar. And yes, I agree the current implementation can cause you to lose context or scroll position when you try to tap the edit button. I had planned to make the floating edit button reappear when the bar moved out of the viewport, but I didn’t manage to work on that before the last release. I’m still deciding on the best way to keep the info bar accessible from any scroll position without making it intrusive. One option is to have the bar reappear when you slightly scroll up from your current position. This could be useful for other info bars as well, such as the one showing the note origin. |
|
I think this PR can be merged once the info bars can be accessed without losing context or scroll position. |
This UI will be clean and functional:
|
And not only for mobile. I never find Similar notes tab to be usable, and would gladly filter it out on desktop |
In this particular case, you can just change the Note Type from Text to Collection. This more clearly specifies the intent of a container.
I believe it already is, since there are two different messages depending on whether it was auto read-only or manually set. |
|
@contributor, thank you for your suggestions. The bar will be updated in the future releases to become less intrusive and to improve the UX as well. Meanwhile, it's safe for you to hide it on the desktop client with some custom CSS. The “Edit note” command is always present in the (three dots) note menu. |







Remove Info from the ribbon, since the Info tab only contained the note origin before.
Instead, directly delete it and migrate the note source URL to the Info bar.
Before:
After: