Scripts/Commands: Replaced lowguid printing in command output with ToString() formatted guid

Shauren · Shauren · commit 5f6974c17047 · 2025-09-29T14:33:53.000+02:00
(cherry picked from commit b10d3cd)
diff --git a/sql/updates/world/3.3.5/2025_09_29_00_world_2014_10_22_00_world.sql b/sql/updates/world/3.3.5/2025_09_29_00_world_2014_10_22_00_world.sql
@@ -0,0 +1,23 @@
+UPDATE `trinity_string` SET `content_default`='New ArenaTeam created [Name: "%s"][Id: %u][Type: %u][Captain: %s]' WHERE `entry`=864;
+UPDATE `trinity_string` SET `content_default`='Name:"%s"[%s] - PR: %u - %s' WHERE `entry`=869;
+UPDATE `trinity_string` SET `content_default`='SetData performed on [%s, name: %s] Field: %u, Data: %u, with %s' WHERE `entry`=555;
+UPDATE `trinity_string` SET `content_default`='| %80s | %20s | %15s (%10u) | %19s |' WHERE `entry`=1017;
+UPDATE `trinity_string` SET `content_default`='%s Name: %s Account: %s (%u) Date: %s' WHERE `entry`=1026;
+UPDATE `trinity_string` SET `content_default`='Character ''%s'' (%s Account %u) can''t be restored: account not exist!' WHERE `entry`=1023;
+UPDATE `trinity_string` SET `content_default`='Character ''%s'' (%s Account %u) can''t be restored: account character list full!' WHERE `entry`=1024;
+UPDATE `trinity_string` SET `content_default`='Character ''%s'' (%s Account %u) can''t be restored: new name already used!' WHERE `entry`=1025;
+UPDATE `trinity_string` SET `content_default`='Forced rename for player %s (%s) will be requested at next login.' WHERE `entry`=254;
+UPDATE `trinity_string` SET `content_default`='Customization for Player %s (%s) will be requested at next login.' WHERE `entry`=346;
+UPDATE `trinity_string` SET `content_default`='Player %s (%s) Account %s (Id: %u) deleted.' WHERE `entry`=1009;
+UPDATE `trinity_string` SET `content_default`='GameObject (GUID: %u) is referenced by nonexisting %s, can''t be deleted.' WHERE `entry`=274;
+UPDATE `trinity_string` SET `content_default`='id: %d %s effmask: %d charges: %d stack: %d slot %d duration: %d maxduration: %d %s %s caster: %s %s' WHERE `entry`=468;
+UPDATE `trinity_string` SET `content_default`='Mail List Info: # of mails: %u, Player: %s (%s)' WHERE `entry`=1151;
+UPDATE `trinity_string` SET `content_default`='Name: %s (%s), Zone: %s, Phase: %u, %s, Flags: %s, Roles: %s' WHERE `entry`=1150;
+UPDATE `trinity_string` SET `content_default`='Object %s' WHERE `entry`=201;
+UPDATE `trinity_string` SET `content_default`='│Player %s %s (%s)' WHERE `entry`=453;
+UPDATE `trinity_string` SET `content_default`='The value index %u is too big for %s (count: %u).' WHERE `entry`=564;
+UPDATE `trinity_string` SET `content_default`='You set %s field: %u to uint32 value: %u' WHERE `entry`=566;
+UPDATE `trinity_string` SET `content_default`='You set %s field: %u to float value: %f' WHERE `entry`=568;
+UPDATE `trinity_string` SET `content_default`='The uint32 value of %s in %u is: %u' WHERE `entry`=570;
+UPDATE `trinity_string` SET `content_default`='The float of %s value in %u is: %f' WHERE `entry`=572;
+UPDATE `trinity_string` SET `content_default`='| Guild Master: %s (%s)' WHERE `entry`=1178;
diff --git a/src/server/scripts/Commands/cs_arena.cpp b/src/server/scripts/Commands/cs_arena.cpp
@@ -90,7 +90,7 @@ class arena_commandscript : public CommandScript
         }
 
         sArenaTeamMgr->AddArenaTeam(arena);
-        handler->PSendSysMessage(LANG_ARENA_CREATE, arena->GetName().c_str(), arena->GetId(), arena->GetType(), arena->GetCaptain().GetCounter());
+        handler->PSendSysMessage(LANG_ARENA_CREATE, arena->GetName().c_str(), arena->GetId(), arena->GetType(), arena->GetCaptain().ToString().c_str());
 
         return true;
     }
@@ -216,7 +216,7 @@ class arena_commandscript : public CommandScript
 
         handler->PSendSysMessage(LANG_ARENA_INFO_HEADER, arena->GetName().c_str(), arena->GetId(), arena->GetRating(), arena->GetType(), arena->GetType());
         for (ArenaTeam::MemberList::iterator itr = arena->m_membersBegin(); itr != arena->m_membersEnd(); ++itr)
-            handler->PSendSysMessage(LANG_ARENA_INFO_MEMBERS, itr->Name.c_str(), itr->Guid.GetCounter(), itr->PersonalRating, (arena->GetCaptain() == itr->Guid ? "- Captain" : ""));
+            handler->PSendSysMessage(LANG_ARENA_INFO_MEMBERS, itr->Name.c_str(), itr->Guid.ToString().c_str(), itr->PersonalRating, (arena->GetCaptain() == itr->Guid ? " - Captain" : ""));
 
         return true;
     }
diff --git a/src/server/scripts/Commands/cs_character.cpp b/src/server/scripts/Commands/cs_character.cpp
@@ -180,11 +180,11 @@ class character_commandscript : public CommandScript
 
             if (!handler->GetSession())
                 handler->PSendSysMessage(LANG_CHARACTER_DELETED_LIST_LINE_CONSOLE,
-                    itr->guid.GetCounter(), itr->name.c_str(), itr->accountName.empty() ? "<Not existing>" : itr->accountName.c_str(),
+                    itr->guid.ToString().c_str(), itr->name.c_str(), itr->accountName.empty() ? "<Not existing>" : itr->accountName.c_str(),
                     itr->accountId, dateStr.c_str());
             else
                 handler->PSendSysMessage(LANG_CHARACTER_DELETED_LIST_LINE_CHAT,
-                    itr->guid.GetCounter(), itr->name.c_str(), itr->accountName.empty() ? "<Not existing>" : itr->accountName.c_str(),
+                    itr->guid.ToString().c_str(), itr->name.c_str(), itr->accountName.empty() ? "<Not existing>" : itr->accountName.c_str(),
                     itr->accountId, dateStr.c_str());
         }
 
@@ -206,21 +206,21 @@ class character_commandscript : public CommandScript
     {
         if (delInfo.accountName.empty())                    // account does not exist
         {
-            handler->PSendSysMessage(LANG_CHARACTER_DELETED_SKIP_ACCOUNT, delInfo.name.c_str(), delInfo.guid.GetCounter(), delInfo.accountId);
+            handler->PSendSysMessage(LANG_CHARACTER_DELETED_SKIP_ACCOUNT, delInfo.name.c_str(), delInfo.guid.ToString().c_str(), delInfo.accountId);
             return;
         }
 
         // check character count
         uint32 charcount = AccountMgr::GetCharactersCount(delInfo.accountId);
         if (charcount >= 10)
         {
-            handler->PSendSysMessage(LANG_CHARACTER_DELETED_SKIP_FULL, delInfo.name.c_str(), delInfo.guid.GetCounter(), delInfo.accountId);
+            handler->PSendSysMessage(LANG_CHARACTER_DELETED_SKIP_FULL, delInfo.name.c_str(), delInfo.guid.ToString().c_str(), delInfo.accountId);
             return;
         }
 
         if (!sCharacterCache->GetCharacterGuidByName(delInfo.name).IsEmpty())
         {
-            handler->PSendSysMessage(LANG_CHARACTER_DELETED_SKIP_NAME, delInfo.name.c_str(), delInfo.guid.GetCounter(), delInfo.accountId);
+            handler->PSendSysMessage(LANG_CHARACTER_DELETED_SKIP_NAME, delInfo.name.c_str(), delInfo.guid.ToString().c_str(), delInfo.accountId);
             return;
         }
 
@@ -378,7 +378,7 @@ class character_commandscript : public CommandScript
                 if (handler->HasLowerSecurity(nullptr, player->GetGUID()))
                     return false;
 
-                handler->PSendSysMessage(LANG_RENAME_PLAYER_GUID, handler->playerLink(*player).c_str(), player->GetGUID().GetCounter());
+                handler->PSendSysMessage(LANG_RENAME_PLAYER_GUID, handler->playerLink(*player).c_str(), player->GetGUID().ToString().c_str());
 
                 CharacterDatabasePreparedStatement* stmt = CharacterDatabase.GetPreparedStatement(CHAR_UPD_ADD_AT_LOGIN_FLAG);
                 stmt->setUInt16(0, uint16(AT_LOGIN_RENAME));
@@ -405,7 +405,7 @@ class character_commandscript : public CommandScript
         }
         else
         {
-            handler->PSendSysMessage(LANG_CUSTOMIZE_PLAYER_GUID, handler->playerLink(*player).c_str(), player->GetGUID().GetCounter());
+            handler->PSendSysMessage(LANG_CUSTOMIZE_PLAYER_GUID, handler->playerLink(*player).c_str(), player->GetGUID().ToString().c_str());
             CharacterDatabasePreparedStatement* stmt = CharacterDatabase.GetPreparedStatement(CHAR_UPD_ADD_AT_LOGIN_FLAG);
             stmt->setUInt16(0, static_cast<uint16>(AT_LOGIN_CUSTOMIZE));
             stmt->setUInt32(1, player->GetGUID().GetCounter());
@@ -447,7 +447,7 @@ class character_commandscript : public CommandScript
         }
         else
         {
-            handler->PSendSysMessage(LANG_CUSTOMIZE_PLAYER_GUID, handler->playerLink(*player).c_str(), player->GetGUID().GetCounter());
+            handler->PSendSysMessage(LANG_CUSTOMIZE_PLAYER_GUID, handler->playerLink(*player).c_str(), player->GetGUID().ToString().c_str());
             CharacterDatabasePreparedStatement* stmt = CharacterDatabase.GetPreparedStatement(CHAR_UPD_ADD_AT_LOGIN_FLAG);
             stmt->setUInt16(0, uint16(AT_LOGIN_CHANGE_FACTION));
             stmt->setUInt32(1, player->GetGUID().GetCounter());
@@ -471,7 +471,7 @@ class character_commandscript : public CommandScript
         }
         else
         {
-            handler->PSendSysMessage(LANG_CUSTOMIZE_PLAYER_GUID, handler->playerLink(*player).c_str(), player->GetGUID().GetCounter());
+            handler->PSendSysMessage(LANG_CUSTOMIZE_PLAYER_GUID, handler->playerLink(*player).c_str(), player->GetGUID().ToString().c_str());
             CharacterDatabasePreparedStatement* stmt = CharacterDatabase.GetPreparedStatement(CHAR_UPD_ADD_AT_LOGIN_FLAG);
             stmt->setUInt16(0, uint16(AT_LOGIN_CHANGE_RACE));
             stmt->setUInt32(1, player->GetGUID().GetCounter());
@@ -749,7 +749,7 @@ class character_commandscript : public CommandScript
         AccountMgr::GetName(accountId, accountName);
 
         Player::DeleteFromDB(player, accountId, true, true);
-        handler->PSendSysMessage(LANG_CHARACTER_DELETED, player.GetName().c_str(), player.GetGUID().GetCounter(), accountName.c_str(), accountId);
+        handler->PSendSysMessage(LANG_CHARACTER_DELETED, player.GetName().c_str(), player.GetGUID().ToString().c_str(), accountName.c_str(), accountId);
 
         return true;
     }
diff --git a/src/server/scripts/Commands/cs_debug.cpp b/src/server/scripts/Commands/cs_debug.cpp
@@ -1157,19 +1157,19 @@ class debug_commandscript : public CommandScript
 
         if (index >= target->GetValuesCount())
         {
-            handler->PSendSysMessage(LANG_TOO_BIG_INDEX, index, target->GetGUID().GetCounter(), target->GetValuesCount());
+            handler->PSendSysMessage(LANG_TOO_BIG_INDEX, index, target->GetGUID().ToString().c_str(), target->GetValuesCount());
             return false;
         }
 
         if (value.holds_alternative<uint32>())
         {
             target->SetUInt32Value(index, value.get<uint32>());
-            handler->PSendSysMessage(LANG_SET_UINT_FIELD, target->GetGUID().GetCounter(), index, value.get<uint32>());
+            handler->PSendSysMessage(LANG_SET_UINT_FIELD, target->GetGUID().ToString().c_str(), index, value.get<uint32>());
         }
         else if (value.holds_alternative<float>())
         {
             target->SetFloatValue(index, value.get<float>());
-            handler->PSendSysMessage(LANG_SET_FLOAT_FIELD, target->GetGUID().GetCounter(), index, value.get<float>());
+            handler->PSendSysMessage(LANG_SET_FLOAT_FIELD, target->GetGUID().ToString().c_str(), index, value.get<float>());
         }
 
         return true;
@@ -1189,19 +1189,19 @@ class debug_commandscript : public CommandScript
 
         if (index >= target->GetValuesCount())
         {
-            handler->PSendSysMessage(LANG_TOO_BIG_INDEX, index, guid.GetCounter(), target->GetValuesCount());
+            handler->PSendSysMessage(LANG_TOO_BIG_INDEX, index, guid.ToString().c_str(), target->GetValuesCount());
             return false;
         }
 
         if (isInt)
         {
             uint32 value = target->GetUInt32Value(index);
-            handler->PSendSysMessage(LANG_GET_UINT_FIELD, guid.GetCounter(), index, value);
+            handler->PSendSysMessage(LANG_GET_UINT_FIELD, guid.ToString().c_str(), index, value);
         }
         else
         {
             float value = target->GetFloatValue(index);
-            handler->PSendSysMessage(LANG_GET_FLOAT_FIELD, guid.GetCounter(), index, value);
+            handler->PSendSysMessage(LANG_GET_FLOAT_FIELD, guid.ToString().c_str(), index, value);
         }
 
         return true;
@@ -1211,7 +1211,7 @@ class debug_commandscript : public CommandScript
     {
         if (index >= handler->GetPlayer()->GetValuesCount())
         {
-            handler->PSendSysMessage(LANG_TOO_BIG_INDEX, index, handler->GetPlayer()->GetGUID().GetCounter(), handler->GetPlayer()->GetValuesCount());
+            handler->PSendSysMessage(LANG_TOO_BIG_INDEX, index, handler->GetPlayer()->GetGUID().ToString().c_str(), handler->GetPlayer()->GetValuesCount());
             return false;
         }
 
diff --git a/src/server/scripts/Commands/cs_gobject.cpp b/src/server/scripts/Commands/cs_gobject.cpp
@@ -308,7 +308,7 @@ class gobject_commandscript : public CommandScript
                 Unit* owner = ObjectAccessor::GetUnit(*player, ownerGuid);
                 if (!owner || !ownerGuid.IsPlayer())
                 {
-                    handler->PSendSysMessage(LANG_COMMAND_DELOBJREFERCREATURE, ownerGuid.GetCounter(), spawnId);
+                    handler->PSendSysMessage(LANG_COMMAND_DELOBJREFERCREATURE, *spawnId, ownerGuid.ToString().c_str());
                     handler->SetSentErrorMessage(true);
                     return false;
                 }
diff --git a/src/server/scripts/Commands/cs_group.cpp b/src/server/scripts/Commands/cs_group.cpp
@@ -513,7 +513,7 @@ class group_commandscript : public CommandScript
 
             // Now we can print those informations for every single member of each group!
             handler->PSendSysMessage(LANG_GROUP_PLAYER_NAME_GUID, slot.name.c_str(), onlineState,
-                zoneName, phase, slot.guid.GetCounter(), flags.c_str(),
+                zoneName, phase, slot.guid.ToString().c_str(), flags.c_str(),
                 lfg::GetRolesString(slot.roles).c_str());
         }
 
diff --git a/src/server/scripts/Commands/cs_guild.cpp b/src/server/scripts/Commands/cs_guild.cpp
@@ -281,7 +281,7 @@ class guild_commandscript : public CommandScript
 
         std::string guildMasterName;
         if (sCharacterCache->GetCharacterNameByGuid(guild->GetLeaderGUID(), guildMasterName))
-            handler->PSendSysMessage(LANG_GUILD_INFO_GUILD_MASTER, guildMasterName.c_str(), guild->GetLeaderGUID().GetCounter()); // Guild Master
+            handler->PSendSysMessage(LANG_GUILD_INFO_GUILD_MASTER, guildMasterName.c_str(), guild->GetLeaderGUID().ToString().c_str()); // Guild Master
 
         // Format creation date
         char createdDateStr[20];
diff --git a/src/server/scripts/Commands/cs_list.cpp b/src/server/scripts/Commands/cs_list.cpp
@@ -486,7 +486,7 @@ class list_commandscript : public CommandScript
                 aurApp->GetEffectMask(), aura->GetCharges(), aura->GetStackAmount(), aurApp->GetSlot(),
                 aura->GetDuration(), aura->GetMaxDuration(), (aura->IsPassive() ? passiveStr : ""),
                 (talent ? talentStr : ""), aura->GetCasterGUID().IsPlayer() ? "player" : "creature",
-                aura->GetCasterGUID().GetCounter());
+                aura->GetCasterGUID().ToString().c_str());
         }
 
         for (uint16 i = 0; i < TOTAL_AURAS; ++i)
@@ -546,7 +546,7 @@ class list_commandscript : public CommandScript
             uint32 countMail    = fields[0].GetUInt64();
 
             std::string nameLink = handler->playerLink(player->GetName());
-            handler->PSendSysMessage(LANG_LIST_MAIL_HEADER, countMail, nameLink.c_str(), player->GetGUID().GetCounter());
+            handler->PSendSysMessage(LANG_LIST_MAIL_HEADER, countMail, nameLink.c_str(), player->GetGUID().ToString().c_str());
             handler->PSendSysMessage(LANG_ACCOUNT_LIST_BAR);
 
             stmt = CharacterDatabase.GetPreparedStatement(CHAR_SEL_MAIL_LIST_INFO);
diff --git a/src/server/scripts/Commands/cs_misc.cpp b/src/server/scripts/Commands/cs_misc.cpp
@@ -1840,7 +1840,7 @@ class misc_commandscript : public CommandScript
 
         // Initiate output
         // Output I. LANG_PINFO_PLAYER
-        handler->PSendSysMessage(LANG_PINFO_PLAYER, target ? "" : handler->GetTrinityString(LANG_OFFLINE), nameLink.c_str(), lowguid);
+        handler->PSendSysMessage(LANG_PINFO_PLAYER, target ? "" : handler->GetTrinityString(LANG_OFFLINE), nameLink.c_str(), targetGuid.ToString().c_str());
 
         // Output II. LANG_PINFO_GM_ACTIVE if character is gamemaster
         if (target && target->IsGameMaster())
diff --git a/src/server/scripts/Commands/cs_npc.cpp b/src/server/scripts/Commands/cs_npc.cpp
@@ -431,7 +431,7 @@ class npc_commandscript : public CommandScript
 
         creature->AI()->SetData(data_1, data_2);
         std::string AIorScript = !creature->GetAIName().empty() ? "AI type: " + creature->GetAIName() : (!creature->GetScriptName().empty() ? "Script Name: " + creature->GetScriptName() : "No AI or Script Name Set");
-        handler->PSendSysMessage(LANG_NPC_SETDATA, creature->GetGUID().GetCounter(), creature->GetEntry(), creature->GetName().c_str(), data_1, data_2, AIorScript.c_str());
+        handler->PSendSysMessage(LANG_NPC_SETDATA, creature->GetGUID().ToString().c_str(), creature->GetName().c_str(), data_1, data_2, AIorScript.c_str());
         return true;
     }
 
diff --git a/src/server/scripts/World/action_ip_logger.cpp b/src/server/scripts/World/action_ip_logger.cpp
@@ -275,8 +275,6 @@ class CharacterDeleteActionIpLogger : public PlayerScript
         // Action IP Logger is only intialized if config is set up
         // Else, this script isn't loaded in the first place: We require no config check.
 
-        // We declare all the required variables
-        ObjectGuid::LowType characterGuid = guid.GetCounter(); // We have no access to any member function of Player* or WorldSession*. So use old-fashioned way.
         uint32 realmId = realm.Id.Realm;
         // Query playerGuid/accountId, as we only have characterGuid
         std::string systemNote = "ERROR"; // "ERROR" is a placeholder here. We change it later.
@@ -302,7 +300,7 @@ class CharacterDeleteActionIpLogger : public PlayerScript
         LoginDatabasePreparedStatement* stmt = LoginDatabase.GetPreparedStatement(LOGIN_INS_ALDL_IP_LOGGING);
 
         stmt->setUInt32(0, playerGuid);
-        stmt->setUInt64(1, characterGuid);
+        stmt->setUInt64(1, guid.GetCounter());
         stmt->setUInt32(2, realmId);
         stmt->setUInt8(3, aType);
         stmt->setUInt32(4, playerGuid);

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ class arena_commandscript : public CommandScript`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`sArenaTeamMgr->AddArenaTeam(arena);`
`93`		`- handler->PSendSysMessage(LANG_ARENA_CREATE, arena->GetName().c_str(), arena->GetId(), arena->GetType(), arena->GetCaptain().GetCounter());`
	`93`	`+ handler->PSendSysMessage(LANG_ARENA_CREATE, arena->GetName().c_str(), arena->GetId(), arena->GetType(), arena->GetCaptain().ToString().c_str());`
`94`	`94`
`95`	`95`	`return true;`
`96`	`96`	`}`
`@@ -216,7 +216,7 @@ class arena_commandscript : public CommandScript`
`216`	`216`
`217`	`217`	`handler->PSendSysMessage(LANG_ARENA_INFO_HEADER, arena->GetName().c_str(), arena->GetId(), arena->GetRating(), arena->GetType(), arena->GetType());`
`218`	`218`	`for (ArenaTeam::MemberList::iterator itr = arena->m_membersBegin(); itr != arena->m_membersEnd(); ++itr)`
`219`		`- handler->PSendSysMessage(LANG_ARENA_INFO_MEMBERS, itr->Name.c_str(), itr->Guid.GetCounter(), itr->PersonalRating, (arena->GetCaptain() == itr->Guid ? "- Captain" : ""));`
	`219`	`+ handler->PSendSysMessage(LANG_ARENA_INFO_MEMBERS, itr->Name.c_str(), itr->Guid.ToString().c_str(), itr->PersonalRating, (arena->GetCaptain() == itr->Guid ? " - Captain" : ""));`
`220`	`220`
`221`	`221`	`return true;`
`222`	`222`	`}`
Original file line number	Diff line number	Diff line change
`@@ -180,11 +180,11 @@ class character_commandscript : public CommandScript`
`180`	`180`
`181`	`181`	`if (!handler->GetSession())`
`182`	`182`	`handler->PSendSysMessage(LANG_CHARACTER_DELETED_LIST_LINE_CONSOLE,`
`183`		`- itr->guid.GetCounter(), itr->name.c_str(), itr->accountName.empty() ? "<Not existing>" : itr->accountName.c_str(),`
	`183`	`+ itr->guid.ToString().c_str(), itr->name.c_str(), itr->accountName.empty() ? "<Not existing>" : itr->accountName.c_str(),`
`184`	`184`	`itr->accountId, dateStr.c_str());`
`185`	`185`	`else`
`186`	`186`	`handler->PSendSysMessage(LANG_CHARACTER_DELETED_LIST_LINE_CHAT,`
`187`		`- itr->guid.GetCounter(), itr->name.c_str(), itr->accountName.empty() ? "<Not existing>" : itr->accountName.c_str(),`
	`187`	`+ itr->guid.ToString().c_str(), itr->name.c_str(), itr->accountName.empty() ? "<Not existing>" : itr->accountName.c_str(),`
`188`	`188`	`itr->accountId, dateStr.c_str());`
`189`	`189`	`}`
`190`	`190`
`@@ -206,21 +206,21 @@ class character_commandscript : public CommandScript`
`206`	`206`	`{`
`207`	`207`	`if (delInfo.accountName.empty()) // account does not exist`
`208`	`208`	`{`
`209`		`- handler->PSendSysMessage(LANG_CHARACTER_DELETED_SKIP_ACCOUNT, delInfo.name.c_str(), delInfo.guid.GetCounter(), delInfo.accountId);`
	`209`	`+ handler->PSendSysMessage(LANG_CHARACTER_DELETED_SKIP_ACCOUNT, delInfo.name.c_str(), delInfo.guid.ToString().c_str(), delInfo.accountId);`
`210`	`210`	`return;`
`211`	`211`	`}`
`212`	`212`
`213`	`213`	`// check character count`
`214`	`214`	`uint32 charcount = AccountMgr::GetCharactersCount(delInfo.accountId);`
`215`	`215`	`if (charcount >= 10)`
`216`	`216`	`{`
`217`		`- handler->PSendSysMessage(LANG_CHARACTER_DELETED_SKIP_FULL, delInfo.name.c_str(), delInfo.guid.GetCounter(), delInfo.accountId);`
	`217`	`+ handler->PSendSysMessage(LANG_CHARACTER_DELETED_SKIP_FULL, delInfo.name.c_str(), delInfo.guid.ToString().c_str(), delInfo.accountId);`
`218`	`218`	`return;`
`219`	`219`	`}`
`220`	`220`
`221`	`221`	`if (!sCharacterCache->GetCharacterGuidByName(delInfo.name).IsEmpty())`
`222`	`222`	`{`
`223`		`- handler->PSendSysMessage(LANG_CHARACTER_DELETED_SKIP_NAME, delInfo.name.c_str(), delInfo.guid.GetCounter(), delInfo.accountId);`
	`223`	`+ handler->PSendSysMessage(LANG_CHARACTER_DELETED_SKIP_NAME, delInfo.name.c_str(), delInfo.guid.ToString().c_str(), delInfo.accountId);`
`224`	`224`	`return;`
`225`	`225`	`}`
`226`	`226`
`@@ -378,7 +378,7 @@ class character_commandscript : public CommandScript`
`378`	`378`	`if (handler->HasLowerSecurity(nullptr, player->GetGUID()))`
`379`	`379`	`return false;`
`380`	`380`
`381`		`- handler->PSendSysMessage(LANG_RENAME_PLAYER_GUID, handler->playerLink(*player).c_str(), player->GetGUID().GetCounter());`
	`381`	`+ handler->PSendSysMessage(LANG_RENAME_PLAYER_GUID, handler->playerLink(*player).c_str(), player->GetGUID().ToString().c_str());`
`382`	`382`
`383`	`383`	`CharacterDatabasePreparedStatement* stmt = CharacterDatabase.GetPreparedStatement(CHAR_UPD_ADD_AT_LOGIN_FLAG);`
`384`	`384`	`stmt->setUInt16(0, uint16(AT_LOGIN_RENAME));`
`@@ -405,7 +405,7 @@ class character_commandscript : public CommandScript`
`405`	`405`	`}`
`406`	`406`	`else`
`407`	`407`	`{`
`408`		`- handler->PSendSysMessage(LANG_CUSTOMIZE_PLAYER_GUID, handler->playerLink(*player).c_str(), player->GetGUID().GetCounter());`
	`408`	`+ handler->PSendSysMessage(LANG_CUSTOMIZE_PLAYER_GUID, handler->playerLink(*player).c_str(), player->GetGUID().ToString().c_str());`
`409`	`409`	`CharacterDatabasePreparedStatement* stmt = CharacterDatabase.GetPreparedStatement(CHAR_UPD_ADD_AT_LOGIN_FLAG);`
`410`	`410`	`stmt->setUInt16(0, static_cast<uint16>(AT_LOGIN_CUSTOMIZE));`
`411`	`411`	`stmt->setUInt32(1, player->GetGUID().GetCounter());`
`@@ -447,7 +447,7 @@ class character_commandscript : public CommandScript`
`447`	`447`	`}`
`448`	`448`	`else`
`449`	`449`	`{`
`450`		`- handler->PSendSysMessage(LANG_CUSTOMIZE_PLAYER_GUID, handler->playerLink(*player).c_str(), player->GetGUID().GetCounter());`
	`450`	`+ handler->PSendSysMessage(LANG_CUSTOMIZE_PLAYER_GUID, handler->playerLink(*player).c_str(), player->GetGUID().ToString().c_str());`
`451`	`451`	`CharacterDatabasePreparedStatement* stmt = CharacterDatabase.GetPreparedStatement(CHAR_UPD_ADD_AT_LOGIN_FLAG);`
`452`	`452`	`stmt->setUInt16(0, uint16(AT_LOGIN_CHANGE_FACTION));`
`453`	`453`	`stmt->setUInt32(1, player->GetGUID().GetCounter());`
`@@ -471,7 +471,7 @@ class character_commandscript : public CommandScript`
`471`	`471`	`}`
`472`	`472`	`else`
`473`	`473`	`{`
`474`		`- handler->PSendSysMessage(LANG_CUSTOMIZE_PLAYER_GUID, handler->playerLink(*player).c_str(), player->GetGUID().GetCounter());`
	`474`	`+ handler->PSendSysMessage(LANG_CUSTOMIZE_PLAYER_GUID, handler->playerLink(*player).c_str(), player->GetGUID().ToString().c_str());`
`475`	`475`	`CharacterDatabasePreparedStatement* stmt = CharacterDatabase.GetPreparedStatement(CHAR_UPD_ADD_AT_LOGIN_FLAG);`
`476`	`476`	`stmt->setUInt16(0, uint16(AT_LOGIN_CHANGE_RACE));`
`477`	`477`	`stmt->setUInt32(1, player->GetGUID().GetCounter());`
`@@ -749,7 +749,7 @@ class character_commandscript : public CommandScript`
`749`	`749`	`AccountMgr::GetName(accountId, accountName);`
`750`	`750`
`751`	`751`	`Player::DeleteFromDB(player, accountId, true, true);`
`752`		`- handler->PSendSysMessage(LANG_CHARACTER_DELETED, player.GetName().c_str(), player.GetGUID().GetCounter(), accountName.c_str(), accountId);`
	`752`	`+ handler->PSendSysMessage(LANG_CHARACTER_DELETED, player.GetName().c_str(), player.GetGUID().ToString().c_str(), accountName.c_str(), accountId);`
`753`	`753`
`754`	`754`	`return true;`
`755`	`755`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1157,19 +1157,19 @@ class debug_commandscript : public CommandScript`
`1157`	`1157`
`1158`	`1158`	`if (index >= target->GetValuesCount())`
`1159`	`1159`	`{`
`1160`		`- handler->PSendSysMessage(LANG_TOO_BIG_INDEX, index, target->GetGUID().GetCounter(), target->GetValuesCount());`
	`1160`	`+ handler->PSendSysMessage(LANG_TOO_BIG_INDEX, index, target->GetGUID().ToString().c_str(), target->GetValuesCount());`
`1161`	`1161`	`return false;`
`1162`	`1162`	`}`
`1163`	`1163`
`1164`	`1164`	`if (value.holds_alternative<uint32>())`
`1165`	`1165`	`{`
`1166`	`1166`	`target->SetUInt32Value(index, value.get<uint32>());`
`1167`		`- handler->PSendSysMessage(LANG_SET_UINT_FIELD, target->GetGUID().GetCounter(), index, value.get<uint32>());`
	`1167`	`+ handler->PSendSysMessage(LANG_SET_UINT_FIELD, target->GetGUID().ToString().c_str(), index, value.get<uint32>());`
`1168`	`1168`	`}`
`1169`	`1169`	`else if (value.holds_alternative<float>())`
`1170`	`1170`	`{`
`1171`	`1171`	`target->SetFloatValue(index, value.get<float>());`
`1172`		`- handler->PSendSysMessage(LANG_SET_FLOAT_FIELD, target->GetGUID().GetCounter(), index, value.get<float>());`
	`1172`	`+ handler->PSendSysMessage(LANG_SET_FLOAT_FIELD, target->GetGUID().ToString().c_str(), index, value.get<float>());`
`1173`	`1173`	`}`
`1174`	`1174`
`1175`	`1175`	`return true;`
`@@ -1189,19 +1189,19 @@ class debug_commandscript : public CommandScript`
`1189`	`1189`
`1190`	`1190`	`if (index >= target->GetValuesCount())`
`1191`	`1191`	`{`
`1192`		`- handler->PSendSysMessage(LANG_TOO_BIG_INDEX, index, guid.GetCounter(), target->GetValuesCount());`
	`1192`	`+ handler->PSendSysMessage(LANG_TOO_BIG_INDEX, index, guid.ToString().c_str(), target->GetValuesCount());`
`1193`	`1193`	`return false;`
`1194`	`1194`	`}`
`1195`	`1195`
`1196`	`1196`	`if (isInt)`
`1197`	`1197`	`{`
`1198`	`1198`	`uint32 value = target->GetUInt32Value(index);`
`1199`		`- handler->PSendSysMessage(LANG_GET_UINT_FIELD, guid.GetCounter(), index, value);`
	`1199`	`+ handler->PSendSysMessage(LANG_GET_UINT_FIELD, guid.ToString().c_str(), index, value);`
`1200`	`1200`	`}`
`1201`	`1201`	`else`
`1202`	`1202`	`{`
`1203`	`1203`	`float value = target->GetFloatValue(index);`
`1204`		`- handler->PSendSysMessage(LANG_GET_FLOAT_FIELD, guid.GetCounter(), index, value);`
	`1204`	`+ handler->PSendSysMessage(LANG_GET_FLOAT_FIELD, guid.ToString().c_str(), index, value);`
`1205`	`1205`	`}`
`1206`	`1206`
`1207`	`1207`	`return true;`
`@@ -1211,7 +1211,7 @@ class debug_commandscript : public CommandScript`
`1211`	`1211`	`{`
`1212`	`1212`	`if (index >= handler->GetPlayer()->GetValuesCount())`
`1213`	`1213`	`{`
`1214`		`- handler->PSendSysMessage(LANG_TOO_BIG_INDEX, index, handler->GetPlayer()->GetGUID().GetCounter(), handler->GetPlayer()->GetValuesCount());`
	`1214`	`+ handler->PSendSysMessage(LANG_TOO_BIG_INDEX, index, handler->GetPlayer()->GetGUID().ToString().c_str(), handler->GetPlayer()->GetValuesCount());`
`1215`	`1215`	`return false;`
`1216`	`1216`	`}`
`1217`	`1217`
Original file line number	Diff line number	Diff line change
`@@ -308,7 +308,7 @@ class gobject_commandscript : public CommandScript`
`308`	`308`	`Unit* owner = ObjectAccessor::GetUnit(*player, ownerGuid);`
`309`	`309`	`if (!owner \|\| !ownerGuid.IsPlayer())`
`310`	`310`	`{`
`311`		`- handler->PSendSysMessage(LANG_COMMAND_DELOBJREFERCREATURE, ownerGuid.GetCounter(), spawnId);`
	`311`	`+ handler->PSendSysMessage(LANG_COMMAND_DELOBJREFERCREATURE, *spawnId, ownerGuid.ToString().c_str());`
`312`	`312`	`handler->SetSentErrorMessage(true);`
`313`	`313`	`return false;`
`314`	`314`	`}`
Original file line number	Diff line number	Diff line change
`@@ -513,7 +513,7 @@ class group_commandscript : public CommandScript`
`513`	`513`
`514`	`514`	`// Now we can print those informations for every single member of each group!`
`515`	`515`	`handler->PSendSysMessage(LANG_GROUP_PLAYER_NAME_GUID, slot.name.c_str(), onlineState,`
`516`		`- zoneName, phase, slot.guid.GetCounter(), flags.c_str(),`
	`516`	`+ zoneName, phase, slot.guid.ToString().c_str(), flags.c_str(),`
`517`	`517`	`lfg::GetRolesString(slot.roles).c_str());`
`518`	`518`	`}`
`519`	`519`
Original file line number	Diff line number	Diff line change
`@@ -431,7 +431,7 @@ class npc_commandscript : public CommandScript`
`431`	`431`
`432`	`432`	`creature->AI()->SetData(data_1, data_2);`
`433`	`433`	`std::string AIorScript = !creature->GetAIName().empty() ? "AI type: " + creature->GetAIName() : (!creature->GetScriptName().empty() ? "Script Name: " + creature->GetScriptName() : "No AI or Script Name Set");`
`434`		`- handler->PSendSysMessage(LANG_NPC_SETDATA, creature->GetGUID().GetCounter(), creature->GetEntry(), creature->GetName().c_str(), data_1, data_2, AIorScript.c_str());`
	`434`	`+ handler->PSendSysMessage(LANG_NPC_SETDATA, creature->GetGUID().ToString().c_str(), creature->GetName().c_str(), data_1, data_2, AIorScript.c_str());`
`435`	`435`	`return true;`
`436`	`436`	`}`
`437`	`437`