Scripts/RazorfenDowns: Modernize scripts (#31145)

Author: offl

sql/updates/world/3.3.5/2025_09_04_01_world.sql

@@ -0,0 +1,18 @@
+--
+DELETE FROM `creature_text` WHERE `CreatureID` = 7358;
+INSERT INTO `creature_text` (`CreatureID`, `GroupID`, `ID`, `Text`, `Type`, `Language`, `Probability`, `Emote`, `Duration`, `Sound`, `BroadcastTextId`, `TextRange`, `comment`) VALUES
+(7358,0,0,"You'll never leave this place alive.",14,0,100,0,0,5825,6187,0,"amnennar SAY_AGGRO"),
+(7358,1,0,"Too easy.",12,0,100,0,0,5826,6188,0,"amnennar SAY_SLAY"),
+(7358,2,0,"I am the hand of the Lich King!",14,0,100,0,0,5827,6192,0,"amnennar SAY_HEALTH_75"),
+(7358,3,0,"To me, my servants!",14,0,100,0,0,5828,6189,0,"amnennar SAY_SUMMON_60"),
+(7358,4,0,"Come, spirits - attend your master!",14,0,100,0,0,5829,6190,0,"amnennar SAY_SUMMON_30"),
+(7358,5,0,"%s begins to summon wraiths out of the freezing cold air!",16,0,100,0,0,0,4483,0,"amnennar EMOTE_SUMMON");
+
+DELETE FROM `conditions` WHERE `SourceTypeOrReferenceId` = 13 AND `SourceEntry` = 12660;
+INSERT INTO `conditions` (`SourceTypeOrReferenceId`,`SourceGroup`,`SourceEntry`,`SourceId`,`ElseGroup`,`ConditionTypeOrReference`,`ConditionTarget`,`ConditionValue1`,`ConditionValue2`,`ConditionValue3`,`NegativeCondition`,`ErrorType`,`ErrorTextId`,`ScriptName`,`Comment`) VALUES
+(13,1,12660,0,0,31,0,3,8585,0,0,0,0,"","Group 0: Spell 'Banish Frost Spectres' (Effect 0) targets creature 'Frost Spectre'");
+
+DELETE FROM `smart_scripts` WHERE `entryorguid` = 8585 AND `source_type` = 0;
+INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`event_param5`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_param4`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
+(8585,0,0,0,37,0,100,0,0,0,0,0,0,116,4,0,0,0,0,0,1,0,0,0,0,0,0,0,0,"Frost Spectre - On AI Initialize - Set Corpse Delay"),
+(8585,0,1,0,8,0,100,0,12660,0,0,0,0,11,3617,0,0,0,0,0,1,0,0,0,0,0,0,0,0,"Frost Spectre - On Spellhit 'Banish Frost Spectres' - Cast 'Quiet Suicide'");

src/server/scripts/Kalimdor/RazorfenDowns/boss_amnennar_the_coldbringer.cpp

@@ -15,147 +15,171 @@
  * with this program. If not, see <http://www.gnu.org/licenses/>.
  */
 
+/*
+ * Timers requires update
+ * Guardians are despawned in core, that should not happen here
+ */
+
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"
 #include "razorfen_downs.h"
 
-enum Say
+enum AmnennarTexts
 {
-    SAY_AGGRO               = 0,
-    SAY_SUMMON60            = 1,
-    SAY_SUMMON30            = 2,
-    SAY_HP                  = 3,
-    SAY_KILL                = 4
+    SAY_AGGRO                      = 0,
+    SAY_SLAY                       = 1,
+    SAY_HEALTH_75                  = 2,
+    SAY_SUMMON_60                  = 3,
+    SAY_SUMMON_30                  = 4,
+    EMOTE_SUMMON                   = 5
 };
 
-enum Spells
+enum AmnennarSpells
 {
-    SPELL_AMNENNARSWRATH    = 13009,
-    SPELL_FROSTBOLT         = 15530,
-    SPELL_FROST_NOVA        = 15531,
-    SPELL_FROST_SPECTRES    = 12642
+    SPELL_AMNENNARS_WRATH          = 13009,
+    SPELL_FROSTBOLT                = 15530,
+    SPELL_FROST_NOVA               = 15531,
+    SPELL_SUMMON_FROST_SPECTRES    = 12642,
+    SPELL_BANISH_FROST_SPECTRES    = 12660
 };
 
-enum Events
+enum AmnennarEvents
 {
-    EVENT_AMNENNARSWRATH    = 1,
-    EVENT_FROSTBOLT         = 2,
-    EVENT_FROST_NOVA        = 3
+    EVENT_AMNENNARS_WRATH          = 1,
+    EVENT_FROSTBOLT,
+    EVENT_FROST_NOVA,
+
+    EVENT_HEALTH_75,
+    EVENT_HEALTH_60,
+    EVENT_HEALTH_30
 };
 
-class boss_amnennar_the_coldbringer : public CreatureScript
+enum AmnennarPhases : uint8
 {
-public:
-    boss_amnennar_the_coldbringer() : CreatureScript("boss_amnennar_the_coldbringer") { }
+    PHASE_NONE                     = 0,
+    PHASE_HEALTH_75,
+    PHASE_HEALTH_60,
+    PHASE_HEALTH_30
+};
 
-    struct boss_amnennar_the_coldbringerAI : public BossAI
+// 7358 - Amnennar the Coldbringer
+struct boss_amnennar_the_coldbringer : public BossAI
+{
+    boss_amnennar_the_coldbringer(Creature* creature) : BossAI(creature, DATA_AMNENNAR_THE_COLD_BRINGER), _phase(PHASE_NONE) { }
+
+    void Reset() override
     {
-        boss_amnennar_the_coldbringerAI(Creature* creature) : BossAI(creature, DATA_AMNENNAR_THE_COLD_BRINGER)
-        {
-            Initialize();
-        }
+        _Reset();
+        _phase = PHASE_NONE;
+    }
 
-        void Initialize()
-        {
-            hp60Spectrals = false;
-            hp30Spectrals = false;
-            hp50 = false;
-        }
+    void JustEngagedWith(Unit* who) override
+    {
+        BossAI::JustEngagedWith(who);
+        events.ScheduleEvent(EVENT_AMNENNARS_WRATH, 8s);
+        events.ScheduleEvent(EVENT_FROSTBOLT, 0s);
+        events.ScheduleEvent(EVENT_FROST_NOVA, 10s, 15s);
+        Talk(SAY_AGGRO);
+    }
 
-        void Reset() override
+    void DamageTaken(Unit* /*attacker*/, uint32& damage, DamageEffectType /*damageType*/, SpellInfo const* /*spellInfo = nullptr*/) override
+    {
+        if (_phase < PHASE_HEALTH_75 && me->HealthBelowPctDamaged(75, damage))
         {
-            _Reset();
-            Initialize();
+            _phase++;
+            events.ScheduleEvent(EVENT_HEALTH_75, 0s);
         }
 
-        void JustEngagedWith(Unit* who) override
+        if (_phase < PHASE_HEALTH_60 && me->HealthBelowPctDamaged(60, damage))
         {
-            BossAI::JustEngagedWith(who);
-            events.ScheduleEvent(EVENT_AMNENNARSWRATH, 8s);
-            events.ScheduleEvent(EVENT_FROSTBOLT, 1s);
-            events.ScheduleEvent(EVENT_FROST_NOVA, 10s, 15s);
-            Talk(SAY_AGGRO);
+            _phase++;
+            events.ScheduleEvent(EVENT_HEALTH_60, 0s);
         }
 
-        void KilledUnit(Unit* who) override
+        if (_phase < PHASE_HEALTH_30 && me->HealthBelowPctDamaged(30, damage))
         {
-            if (who->GetTypeId() == TYPEID_PLAYER)
-                Talk(SAY_KILL);
+            _phase++;
+            events.ScheduleEvent(EVENT_HEALTH_30, 0s);
         }
+    }
 
-        void JustDied(Unit* /*killer*/) override
-        {
-            _JustDied();
-        }
+    void KilledUnit(Unit* who) override
+    {
+        if (who->GetTypeId() == TYPEID_PLAYER)
+            Talk(SAY_SLAY);
+    }
 
-        void UpdateAI(uint32 diff) override
-        {
-            if (!UpdateVictim())
-                return;
+    // Despawn is handled by spell, don't store anything
+    void JustSummoned(Creature* /*summon*/) override { }
 
-            events.Update(diff);
+    void EnterEvadeMode(EvadeReason why) override
+    {
+        DoCastSelf(SPELL_BANISH_FROST_SPECTRES, true);
+        BossAI::EnterEvadeMode(why);
+    }
 
-            if (me->HasUnitState(UNIT_STATE_CASTING))
-                return;
+    void JustDied(Unit* /*killer*/) override
+    {
+        _JustDied();
+        DoCastSelf(SPELL_BANISH_FROST_SPECTRES, true);
+    }
 
-            while (uint32 eventId = events.ExecuteEvent())
-            {
-                switch (eventId)
-                {
-                    case EVENT_AMNENNARSWRATH:
-                        DoCastVictim(SPELL_AMNENNARSWRATH);
-                        events.ScheduleEvent(EVENT_AMNENNARSWRATH, 12s);
-                        break;
-                    case EVENT_FROSTBOLT:
-                        DoCastVictim(SPELL_FROSTBOLT);
-                        events.ScheduleEvent(EVENT_FROSTBOLT, 8s);
-                        break;
-                    case EVENT_FROST_NOVA:
-                        DoCast(me, SPELL_FROST_NOVA);
-                        events.ScheduleEvent(EVENT_FROST_NOVA, 15s);
-                        break;
-                }
-
-                if (me->HasUnitState(UNIT_STATE_CASTING))
-                    return;
-            }
+    void UpdateAI(uint32 diff) override
+    {
+        if (!UpdateVictim())
+            return;
 
-            if (!hp60Spectrals && HealthBelowPct(60))
-            {
-                Talk(SAY_SUMMON60);
-                DoCastVictim(SPELL_FROST_SPECTRES);
-                hp60Spectrals = true;
-            }
+        events.Update(diff);
 
-            if (!hp50 && HealthBelowPct(50))
-            {
-                Talk(SAY_HP);
-                hp50 = true;
-            }
+        if (me->HasUnitState(UNIT_STATE_CASTING))
+            return;
 
-            if (!hp30Spectrals && HealthBelowPct(30))
+        while (uint32 eventId = events.ExecuteEvent())
+        {
+            switch (eventId)
             {
-                Talk(SAY_SUMMON30);
-                DoCastVictim(SPELL_FROST_SPECTRES);
-                hp30Spectrals = true;
+                case EVENT_AMNENNARS_WRATH:
+                    DoCastVictim(SPELL_AMNENNARS_WRATH);
+                    events.Repeat(12s);
+                    break;
+                case EVENT_FROSTBOLT:
+                    DoCastVictim(SPELL_FROSTBOLT);
+                    events.Repeat(8s);
+                    break;
+                case EVENT_FROST_NOVA:
+                    DoCastSelf(SPELL_FROST_NOVA);
+                    events.Repeat(15s);
+                    break;
+
+                case EVENT_HEALTH_75:
+                    Talk(SAY_HEALTH_75);
+                    break;
+                case EVENT_HEALTH_60:
+                    Talk(EMOTE_SUMMON);
+                    Talk(SAY_SUMMON_60);
+                    DoCastSelf(SPELL_SUMMON_FROST_SPECTRES);
+                    break;
+                case EVENT_HEALTH_30:
+                    Talk(EMOTE_SUMMON);
+                    Talk(SAY_SUMMON_30);
+                    DoCastSelf(SPELL_SUMMON_FROST_SPECTRES);
+                    break;
+                default:
+                    break;
             }
 
-            DoMeleeAttackIfReady();
+            if (me->HasUnitState(UNIT_STATE_CASTING))
+                return;
         }
 
-    private:
-        bool hp60Spectrals;
-        bool hp30Spectrals;
-        bool hp50;
-    };
-
-    CreatureAI* GetAI(Creature* creature) const override
-    {
-        return GetRazorfenDownsAI<boss_amnennar_the_coldbringerAI>(creature);
+        DoMeleeAttackIfReady();
     }
+
+private:
+    uint8 _phase;
 };
 
 void AddSC_boss_amnennar_the_coldbringer()
 {
-    new boss_amnennar_the_coldbringer();
+    RegisterRazorfenDownsCreatureAI(boss_amnennar_the_coldbringer);
 }