Update RuboCop Configuration and lint code

Updated the .rubocop_todo.yml file to reflect the latest RuboCop version and adjusted exclusions for various cops. Added files with lint changes.

Author: JustShah

.rubocop_todo.yml

@@ -1,36 +1,61 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2020-09-23 14:11:08 UTC using RuboCop version 0.91.1.
+# on 2025-02-27 09:58:25 UTC using RuboCop version 1.73.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 3
+# Configuration parameters: EnforcedStyle, AllowedGems, Include.
+# SupportedStyles: Gemfile, gems.rb, gemspec
+# Include: **/*.gemspec, **/Gemfile, **/gems.rb
+Gemspec/DevelopmentDependencies:
+  Exclude:
+    - 'solidus_easypost.gemspec'
+
 # Offense count: 1
+Lint/DuplicateMethods:
+  Exclude:
+    - 'lib/solidus_easypost.rb'
+
+# Offense count: 1
+# Configuration parameters: IgnoredMetadata.
 RSpec/DescribeClass:
   Exclude:
-    - 'spec/features/**/*'
     - 'spec/integration/order_shipping_spec.rb'
 
-# Offense count: 3
+# Offense count: 1
+RSpec/LetSetup:
+  Exclude:
+    - 'spec/controllers/spree/admin/postage_labels_controller_spec.rb'
+
+# Offense count: 13
 RSpec/MultipleExpectations:
   Max: 3
 
 # Offense count: 4
+# Configuration parameters: AllowSubject.
+RSpec/MultipleMemoizedHelpers:
+  Max: 6
+
+# Offense count: 3
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: scientific, engineering, integral
 Style/ExponentialNotation:
   Exclude:
     - 'spec/integration/checkout_spec.rb'
 
 # Offense count: 1
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: respond_to_missing?
 Style/OptionalBooleanParameter:
   Exclude:
     - 'lib/solidus_easypost/estimator.rb'
 
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, SplitStrings.
 # URISchemes: http, https
 Layout/LineLength:
-  Max: 137
+  Max: 130

lib/generators/solidus_easypost/install/install_generator.rb

@@ -20,7 +20,8 @@ def add_javascripts
       end
 
       def run_migrations
-        run_migrations = options[:auto_run_migrations] || ['', 'y', 'Y'].include?(ask('Would you like to run the migrations now? [Y/n]'))
+        run_migrations = options[:auto_run_migrations] || ['', 'y',
+                                                           'Y'].include?(ask('Would you like to run the migrations now? [Y/n]'))
         if run_migrations
           run 'bin/rails db:migrate'
         else

lib/solidus_easypost/tracker_webhook_handler.rb

@@ -8,7 +8,8 @@ def self.call(payload)
       carton = ::Spree::Carton.find_by(easy_post_tracker_id: payload['result']['id'])
       return unless carton
 
-      ::SolidusSupport::LegacyEventCompat::Bus.publish :'solidus_easypost.tracker.updated', carton: carton, payload: payload
+      ::SolidusSupport::LegacyEventCompat::Bus.publish :'solidus_easypost.tracker.updated', carton: carton,
+        payload: payload
     end
   end
 end

spec/controllers/spree/admin/postage_labels_controller_spec.rb

@@ -5,7 +5,7 @@
   let(:shipment) { order.shipments.first }
 
   let!(:easypost_setup) do
-    easypost_config_setup(true)
+    easypost_config_setup(purchase_labels: true)
   end
 
   before do

spec/features/admin/postage_labels_spec.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# rubocop:disable RSpec/DescribeClass
 RSpec.describe 'Postage labels' do
   stub_authorization!
 
@@ -16,3 +17,4 @@
     expect(page).to have_content(I18n.t('spree.open_postage_label'))
   end
 end
+# rubocop:enable RSpec/DescribeClass

spec/integration/checkout_spec.rb

@@ -1,6 +1,6 @@
 RSpec.describe 'Checkout' do
   it 'retrieves the rates from EasyPost', vcr: { cassette_name: 'integration/checkout' } do
-    easypost_config_setup(true)
+    easypost_config_setup(purchase_labels: true)
 
     order = Spree::TestingSupport::OrderWalkthrough.up_to(:complete)
     shipment = order.shipments.first

spec/integration/order_shipping_spec.rb

@@ -1,5 +1,6 @@
 RSpec.describe 'Order shipping' do
-  context 'with purchase_labels set to true', vcr: { cassette_name: 'integration/order_shipping/with_purchase_labels' } do
+  context 'with purchase_labels set to true',
+    vcr: { cassette_name: 'integration/order_shipping/with_purchase_labels' } do
     it 'buys the rate in EasyPost' do
       stub_easypost_config(purchase_labels: true)
       stub_spree_preferences(require_payment_to_ship: false, track_inventory_levels: false)
@@ -15,7 +16,8 @@
     end
   end
 
-  context 'with purchase_labels set to false', vcr: { cassette_name: 'integration/order_shipping/without_purchase_labels' } do
+  context 'with purchase_labels set to false',
+    vcr: { cassette_name: 'integration/order_shipping/without_purchase_labels' } do
     it 'does not buy the rate in EasyPost' do
       stub_easypost_config(purchase_labels: false)
       stub_spree_preferences(require_payment_to_ship: false, track_inventory_levels: false)

spec/models/spree/shipment_spec.rb

@@ -19,7 +19,7 @@
     context 'when a shipping rate was selected' do
       it 'returns the shipment associated with the shipping rate' do
         VCR.use_cassette('shipment/return_easypost_shipment') do
-          easypost_config_setup(true)
+          easypost_config_setup(purchase_labels: true)
           expect(shipment.easypost_shipment).to be_present
         end
       end
@@ -30,7 +30,7 @@
     context 'when purchase_labels is true' do
       it 'buys the selected rate' do
         VCR.use_cassette('shipment/with_selected_shipping_rates') do
-          easypost_config_setup(true)
+          easypost_config_setup(purchase_labels: true)
           shipment.ship!
           expect(shipment.easypost_shipment).to be_present
           expect(shipment.shipping_rates.where(selected: true).count).to eq(1)
@@ -41,7 +41,7 @@
     context 'when purchase_labels is false' do
       it 'does not buy rates automatically' do
         VCR.use_cassette('shipment/disabled_purchase_labels') do
-          easypost_config_setup
+          easypost_config_setup(purchase_labels: false)
           shipment.ship!
           selected_rate = shipment.shipping_rates.where(selected: true).last
           expect(shipment.easypost_shipment).to be_present

spec/solidus_easypost/shipping_method_selector_spec.rb

@@ -7,7 +7,7 @@
   let(:selector) { described_class.new }
 
   before do
-    easypost_config_setup(true)
+    easypost_config_setup(purchase_labels: true)
   end
 
   describe '#shipping_method_for' do

spec/solidus_easypost/shipping_rate_calculator_spec.rb

@@ -6,7 +6,7 @@
     let(:calculator) { described_class.new }
 
     before do
-      easypost_config_setup(true)
+      easypost_config_setup(purchase_labels: true)
     end
 
     it 'returns the amount on the EasyPost rate' do