chore: Remove superfluous calls & type annotations

Author: jan-ferdinand

tasm-lib/src/traits/accessor.rs

@@ -99,12 +99,7 @@ where
     }
 
     fn test(&self) {
-        for corner_case in self
-            .accessor
-            .borrow()
-            .corner_case_initial_states()
-            .into_iter()
-        {
+        for corner_case in self.accessor.borrow().corner_case_initial_states() {
             let stdin = vec![];
             let nd = NonDeterminism::default().with_ram(corner_case.memory);
             test_rust_equivalence_given_complete_state(
@@ -118,14 +113,12 @@ where
         }
 
         let num_states = 10;
-        let seed: [u8; 32] = thread_rng().gen();
-        let mut rng = StdRng::from_seed(seed);
+        let mut rng = StdRng::from_seed(random());
         for _ in 0..num_states {
-            let seed: [u8; 32] = rng.gen();
             let AccessorInitialState { stack, memory } = self
                 .accessor
                 .borrow()
-                .pseudorandom_initial_state(seed, None);
+                .pseudorandom_initial_state(rng.gen(), None);
 
             let stdin = vec![];
             let nd = NonDeterminism::default().with_ram(memory);

tasm-lib/src/traits/algorithm.rs

@@ -122,12 +122,7 @@ where
     }
 
     fn test(&self) {
-        for corner_case in self
-            .algorithm
-            .borrow()
-            .corner_case_initial_states()
-            .into_iter()
-        {
+        for corner_case in self.algorithm.borrow().corner_case_initial_states() {
             let stdin = vec![];
             test_rust_equivalence_given_complete_state(
                 self,

tasm-lib/src/traits/basic_snippet.rs

@@ -100,14 +100,14 @@ pub trait BasicSnippet {
         code
     }
 
-    /// Intial stack on program start, when the snippet runs in isolation.
+    /// Initial stack on program start, when the snippet runs in isolation.
     fn init_stack_for_isolated_run(&self) -> Vec<BFieldElement> {
         let code = self.link_for_isolated_run();
         let program = Program::new(&code);
         let program_digest = program.hash();
         [
             program_digest.reversed().values().to_vec(),
-            vec![BFieldElement::zero(); NUM_OP_STACK_REGISTERS - tip5::Digest::LEN],
+            vec![BFieldElement::zero(); NUM_OP_STACK_REGISTERS - Digest::LEN],
         ]
         .concat()
     }

tasm-lib/src/traits/mem_preserver.rs

@@ -110,12 +110,7 @@ where
     }
 
     fn test(&self) {
-        for corner_case in self
-            .mem_preserver
-            .borrow()
-            .corner_case_initial_states()
-            .into_iter()
-        {
+        for corner_case in self.mem_preserver.borrow().corner_case_initial_states() {
             let stdin: Vec<_> = corner_case.public_input.into();
 
             test_rust_equivalence_given_complete_state(
@@ -129,10 +124,8 @@ where
         }
 
         let num_states = 10;
-        let seed: [u8; 32] = thread_rng().gen();
-        let mut rng = StdRng::from_seed(seed);
+        let mut rng = StdRng::from_seed(random());
         for _ in 0..num_states {
-            let seed: [u8; 32] = rng.gen();
             let MemPreserverInitialState {
                 stack,
                 public_input,
@@ -141,7 +134,7 @@ where
             } = self
                 .mem_preserver
                 .borrow()
-                .pseudorandom_initial_state(seed, None);
+                .pseudorandom_initial_state(rng.gen(), None);
 
             let stdin: Vec<_> = public_input.into();
             test_rust_equivalence_given_complete_state(

tasm-lib/src/traits/read_only_algorithm.rs

@@ -109,7 +109,6 @@ where
             .read_only_algorithm
             .borrow()
             .corner_case_initial_states()
-            .into_iter()
         {
             let stdin = vec![];
             test_rust_equivalence_given_complete_state(
@@ -123,17 +122,15 @@ where
         }
 
         let num_states = 10;
-        let seed: [u8; 32] = thread_rng().gen();
-        let mut rng = StdRng::from_seed(seed);
+        let mut rng = StdRng::from_seed(random());
         for _ in 0..num_states {
-            let seed: [u8; 32] = rng.gen();
             let ReadOnlyAlgorithmInitialState {
                 stack,
                 nondeterminism,
             } = self
                 .read_only_algorithm
                 .borrow()
-                .pseudorandom_initial_state(seed, None);
+                .pseudorandom_initial_state(rng.gen(), None);
 
             let stdin = vec![];
             test_rust_equivalence_given_complete_state(