Skip to content

Commit 52a8ba3

Browse files
committed
refactor(TasmObject): Don't panic asserting sizes
Previously, the implementations of `TasmObject`'s function `compute_size_and_assert_valid_size_indicator` for “primitive types” like `u32`, `Digest`, etc., panicked, claiming a statically known size as the reason. Now, the statically know length is produced. Also, improve code formatting and a tiny bit of assembly.
1 parent bc6c301 commit 52a8ba3

File tree

3 files changed

+171
-205
lines changed

3 files changed

+171
-205
lines changed

tasm-lib/benchmarks/tasmlib_structure_verify_nd_si_integrity___ProofCollectionLookalike.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
{
33
"name": "tasmlib_structure_verify_nd_si_integrity___ProofCollectionLookalike",
44
"benchmark_result": {
5-
"clock_cycle_count": 205,
6-
"hash_table_height": 234,
5+
"clock_cycle_count": 203,
6+
"hash_table_height": 228,
77
"u32_table_height": 150,
88
"op_stack_table_height": 136,
99
"ram_table_height": 16
@@ -13,10 +13,10 @@
1313
{
1414
"name": "tasmlib_structure_verify_nd_si_integrity___ProofCollectionLookalike",
1515
"benchmark_result": {
16-
"clock_cycle_count": 289,
17-
"hash_table_height": 234,
16+
"clock_cycle_count": 284,
17+
"hash_table_height": 228,
1818
"u32_table_height": 212,
19-
"op_stack_table_height": 196,
19+
"op_stack_table_height": 190,
2020
"ram_table_height": 22
2121
},
2222
"case": "WorstCase"

tasm-lib/benchmarks/tasmlib_structure_verify_nd_si_integrity___TransactionKernelLookalike.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
{
33
"name": "tasmlib_structure_verify_nd_si_integrity___TransactionKernelLookalike",
44
"benchmark_result": {
5-
"clock_cycle_count": 278,
5+
"clock_cycle_count": 282,
66
"hash_table_height": 390,
77
"u32_table_height": 240,
8-
"op_stack_table_height": 184,
8+
"op_stack_table_height": 180,
99
"ram_table_height": 15
1010
},
1111
"case": "CommonCase"
@@ -16,7 +16,7 @@
1616
"clock_cycle_count": 244,
1717
"hash_table_height": 390,
1818
"u32_table_height": 212,
19-
"op_stack_table_height": 164,
19+
"op_stack_table_height": 160,
2020
"ram_table_height": 14
2121
},
2222
"case": "WorstCase"

0 commit comments

Comments
 (0)