refactor!: Remove DeprecatedSnippet impl

Implement `BasicSnippet` for `MemCpy` directly instead.

changelog: ignore

Author: jan-ferdinand

tasm-lib/benchmarks/tasmlib_list_higher_order_u32_filter_test_hash_xfield_element_lsb.json

@@ -2,21 +2,21 @@
   {
     "name": "tasmlib_list_higher_order_u32_filter_test_hash_xfield_element_lsb",
     "benchmark_result": {
-      "clock_cycle_count": 923,
-      "hash_table_height": 338,
+      "clock_cycle_count": 1011,
+      "hash_table_height": 302,
       "u32_table_height": 667,
-      "op_stack_table_height": 862,
+      "op_stack_table_height": 846,
       "ram_table_height": 62
     },
     "case": "CommonCase"
   },
   {
     "name": "tasmlib_list_higher_order_u32_filter_test_hash_xfield_element_lsb",
     "benchmark_result": {
-      "clock_cycle_count": 554,
-      "hash_table_height": 286,
+      "clock_cycle_count": 620,
+      "hash_table_height": 250,
       "u32_table_height": 363,
-      "op_stack_table_height": 504,
+      "op_stack_table_height": 492,
       "ram_table_height": 40
     },
     "case": "WorstCase"

tasm-lib/benchmarks/tasmlib_list_split_off_xfe.json

@@ -2,21 +2,21 @@
   {
     "name": "tasmlib_list_split_off_xfe",
     "benchmark_result": {
-      "clock_cycle_count": 509,
-      "hash_table_height": 144,
+      "clock_cycle_count": 471,
+      "hash_table_height": 102,
       "u32_table_height": 297,
-      "op_stack_table_height": 551,
+      "op_stack_table_height": 477,
       "ram_table_height": 305
     },
     "case": "CommonCase"
   },
   {
     "name": "tasmlib_list_split_off_xfe",
     "benchmark_result": {
-      "clock_cycle_count": 8489,
-      "hash_table_height": 144,
+      "clock_cycle_count": 7881,
+      "hash_table_height": 102,
       "u32_table_height": 7064,
-      "op_stack_table_height": 9671,
+      "op_stack_table_height": 8457,
       "ram_table_height": 6005
     },
     "case": "WorstCase"

tasm-lib/benchmarks/tasmlib_memory_memcpy.json

@@ -2,21 +2,21 @@
   {
     "name": "tasmlib_memory_memcpy",
     "benchmark_result": {
-      "clock_cycle_count": 85,
-      "hash_table_height": 84,
+      "clock_cycle_count": 91,
+      "hash_table_height": 48,
       "u32_table_height": 49,
-      "op_stack_table_height": 83,
+      "op_stack_table_height": 69,
       "ram_table_height": 34
     },
     "case": "CommonCase"
   },
   {
     "name": "tasmlib_memory_memcpy",
     "benchmark_result": {
-      "clock_cycle_count": 2834,
-      "hash_table_height": 84,
+      "clock_cycle_count": 2626,
+      "hash_table_height": 48,
       "u32_table_height": 2034,
-      "op_stack_table_height": 3229,
+      "op_stack_table_height": 2815,
       "ram_table_height": 2000
     },
     "case": "WorstCase"

tasm-lib/src/list/higher_order/filter.rs

@@ -178,7 +178,6 @@ mod tests {
             let input_type = self.f.domain();
 
             let element_size = self.f.domain().stack_size();
-            let memcpy = MemCpy::rust_shadowing;
             let safety_offset = LIST_METADATA_SIZE;
 
             let list_pointer = stack.pop().unwrap();
@@ -193,7 +192,7 @@ mod tests {
 
             // set length
             stack.push(output_list);
-            stack.push(BFieldElement::new(len as u64));
+            stack.push(bfe!(len));
             SetLength.rust_shadow(stack, memory);
             stack.pop();
 
@@ -214,27 +213,17 @@ mod tests {
 
                 // maybe copy
                 if satisfied {
-                    stack.push(
-                        list_pointer
-                            + BFieldElement::new(
-                                safety_offset as u64 + i as u64 * element_size as u64,
-                            ),
-                    ); // read source
-                    stack.push(
-                        output_list
-                            + BFieldElement::new(
-                                safety_offset as u64 + output_index as u64 * element_size as u64,
-                            ),
-                    ); // write dest
-                    stack.push(BFieldElement::new(element_size as u64)); // number of words
-                    memcpy(&MemCpy, stack, vec![], vec![], memory);
+                    stack.push(list_pointer + bfe!(safety_offset + i * element_size)); // read source
+                    stack.push(output_list + bfe!(safety_offset + output_index * element_size)); // write dest
+                    stack.push(bfe!(element_size)); // number of words
+                    MemCpy.rust_shadow(stack, memory);
                     output_index += 1;
                 }
             }
 
             // set length
             stack.push(output_list);
-            stack.push(BFieldElement::new(output_index as u64));
+            stack.push(bfe!(output_index));
             SetLength.rust_shadow(stack, memory);
         }