Skip to content

Commit 53c86a5

Browse files
authored
chore(ACL-225): v3 endpoints used for Payments API (#327)
1 parent ed12e5c commit 53c86a5

File tree

5 files changed

+15
-10
lines changed

5 files changed

+15
-10
lines changed

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
plugins {
22
id 'java-library'
33
// to unleash the lombok magic
4-
id "io.freefair.lombok" version "8.10.2"
4+
id "io.freefair.lombok" version "8.11"
55
// to make our tests output more fancy
66
id 'com.adarshr.test-logger' version '4.0.0'
77
// to publish packages

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Main properties
22
group=com.truelayer
33
archivesBaseName=truelayer-java
4-
version=16.0.0
4+
version=16.0.1
55

66
# Artifacts properties
77
sonatype_repository_url=https://s01.oss.sonatype.org/service/local/

src/main/java/com/truelayer/java/Environment.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.truelayer.java;
22

33
import java.net.URI;
4+
import java.text.MessageFormat;
45
import lombok.*;
56

67
@RequiredArgsConstructor(access = AccessLevel.PRIVATE)
@@ -13,14 +14,16 @@ public class Environment {
1314

1415
private final URI hppUri;
1516

17+
private static final String PAYMENTS_API_DEFAULT_VERSION = "v3";
18+
1619
/**
1720
* Builder for development environment
1821
* @return a development environment object
1922
*/
2023
public static Environment development() {
2124
return new Environment(
2225
URI.create("https://auth.t7r.dev"),
23-
URI.create("https://api.t7r.dev"),
26+
URI.create(MessageFormat.format("https://api.t7r.dev/{0}/", PAYMENTS_API_DEFAULT_VERSION)),
2427
URI.create("https://payment.t7r.dev"));
2528
}
2629

@@ -31,7 +34,8 @@ public static Environment development() {
3134
public static Environment sandbox() {
3235
return new Environment(
3336
URI.create("https://auth.truelayer-sandbox.com"),
34-
URI.create("https://api.truelayer-sandbox.com"),
37+
URI.create(
38+
MessageFormat.format("https://api.truelayer-sandbox.com/{0}/", PAYMENTS_API_DEFAULT_VERSION)),
3539
URI.create("https://payment.truelayer-sandbox.com"));
3640
}
3741

@@ -42,7 +46,7 @@ public static Environment sandbox() {
4246
public static Environment live() {
4347
return new Environment(
4448
URI.create("https://auth.truelayer.com"),
45-
URI.create("https://api.truelayer.com"),
49+
URI.create(MessageFormat.format("https://api.truelayer.com/{0}/", PAYMENTS_API_DEFAULT_VERSION)),
4650
URI.create("https://payment.truelayer.com"));
4751
}
4852

src/test/java/com/truelayer/java/EnvironmentTests.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public void shouldCreateALiveEnvironment() {
1515

1616
assertEquals("https://auth.truelayer.com", environment.getAuthApiUri().toString());
1717
assertEquals(
18-
"https://api.truelayer.com", environment.getPaymentsApiUri().toString());
18+
"https://api.truelayer.com/v3/", environment.getPaymentsApiUri().toString());
1919
assertEquals("https://payment.truelayer.com", environment.getHppUri().toString());
2020
}
2121

@@ -25,7 +25,7 @@ public void shouldCreateADevelopmentEnvironment() {
2525
Environment environment = Environment.development();
2626

2727
assertEquals("https://auth.t7r.dev", environment.getAuthApiUri().toString());
28-
assertEquals("https://api.t7r.dev", environment.getPaymentsApiUri().toString());
28+
assertEquals("https://api.t7r.dev/v3/", environment.getPaymentsApiUri().toString());
2929
assertEquals("https://payment.t7r.dev", environment.getHppUri().toString());
3030
}
3131

@@ -38,7 +38,7 @@ public void shouldCreateASandboxEnvironment() {
3838
"https://auth.truelayer-sandbox.com",
3939
environment.getAuthApiUri().toString());
4040
assertEquals(
41-
"https://api.truelayer-sandbox.com",
41+
"https://api.truelayer-sandbox.com/v3/",
4242
environment.getPaymentsApiUri().toString());
4343
assertEquals(
4444
"https://payment.truelayer-sandbox.com", environment.getHppUri().toString());

src/test/java/com/truelayer/java/acceptance/PaymentsAcceptanceTests.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
import com.truelayer.java.versioninfo.LibraryInfoLoader;
4040
import java.net.URI;
4141
import java.nio.charset.StandardCharsets;
42+
import java.text.MessageFormat;
4243
import java.time.LocalDate;
4344
import java.util.*;
4445
import java.util.concurrent.ThreadLocalRandom;
@@ -824,8 +825,8 @@ private static AuthorizationFlowResponse startAuthorizationFlowWithRetry(String
824825
String requestJsonString = mapper.writeValueAsString(jsonNode);
825826

826827
// build url
827-
HttpUrl url = HttpUrl.parse(String.format(
828-
"%s/payments/%s/authorization-flow",
828+
HttpUrl url = HttpUrl.parse(MessageFormat.format(
829+
"{0}payments/{1}/authorization-flow",
829830
Environment.sandbox().getPaymentsApiUri().toString(), paymentId));
830831

831832
RequestBody body = RequestBody.create(requestJsonString, MediaType.parse("application/json; charset=utf-8"));

0 commit comments

Comments
 (0)