Update workflows for lief

Signed-off-by: Beat Buesser <[email protected]>

Author: beat-buesser

.github/workflows/ci-lingvo.yml

@@ -50,7 +50,7 @@ jobs:
           sudo apt-get update
           sudo apt-get -y -q install ffmpeg libavcodec-extra
           python -m pip install --upgrade pip setuptools wheel
-          pip install -q -r <(sed '/^scipy/d;/^matplotlib/d;/^pandas/d;/^statsmodels/d;/^numba/d;/^jax/d;/^h5py/d;/^Pillow/d;/^pytest/d;/^pytest-mock/d;/^torch/d;/^torchaudio/d;/^torchvision/d;/^xgboost/d;/^requests/d;/^tensorflow/d;/^keras/d;/^kornia/d;/^librosa/d;/^tqdm/d;/^timm/d;/^catboost/d;/^scikit-learn/d;/^GPy/d' requirements_test.txt)
+          pip install -q -r <(sed '/^scipy/d;/^matplotlib/d;/^pandas/d;/^statsmodels/d;/^numba/d;/^jax/d;/^h5py/d;/^Pillow/d;/^pytest/d;/^pytest-mock/d;/^torch/d;/^torchaudio/d;/^torchvision/d;/^xgboost/d;/^requests/d;/^tensorflow/d;/^keras/d;/^kornia/d;/^librosa/d;/^tqdm/d;/^timm/d;/^catboost/d;/^scikit-learn/d;/^GPy/d;/^lief/d' requirements_test.txt)
           pip install scipy==1.5.4
           pip install matplotlib==3.3.4
           pip install pandas==1.1.5
@@ -77,6 +77,7 @@ jobs:
           pip install catboost==1.1.1
           pip install scikit-learn==0.24.2
           pip install GPy==1.10.0
+          pip install lief==0.12.3
           pip list
       - name: Run ${{ matrix.name }} Tests
         run: pytest --cov-report=xml --cov=art --cov-append -q -vv tests/estimators/speech_recognition/test_tensorflow_lingvo.py --framework=${{ matrix.framework }} --durations=0

.github/workflows/ci-tensorflow-v1.yml

@@ -48,7 +48,7 @@ jobs:
           sudo apt-get update
           sudo apt-get -y -q install ffmpeg libavcodec-extra
           python -m pip install --upgrade pip setuptools wheel
-          pip install -q -r <(sed '/^pandas/d;/^scipy/d;/^matplotlib/d;/^xgboost/d;/^tensorflow/d;/^keras/d;/^jax/d;/^torch/d;/^Pillow/d;/^h5py/d;/^kornia/d;/^scikit-learn/d;/^pytest-mock/d;/^GPy/d' requirements_test.txt)
+          pip install -q -r <(sed '/^pandas/d;/^scipy/d;/^matplotlib/d;/^xgboost/d;/^tensorflow/d;/^keras/d;/^jax/d;/^torch/d;/^Pillow/d;/^h5py/d;/^kornia/d;/^scikit-learn/d;/^pytest-mock/d;/^GPy/d;/^lief/d' requirements_test.txt)
           pip install pandas==1.3.5
           pip install scipy==1.7.2
           pip install matplotlib==3.5.3
@@ -66,6 +66,7 @@ jobs:
           pip install scikit-learn==1.0.2
           pip install pytest-mock~=3.11.1
           pip install GPy~=1.10.0
+          pip install lief==0.12.3
           pip list
       - name: Run Tests
         run: ./run_tests.sh ${{ matrix.framework }}

art/attacks/evasion/pe_malware_attack.py

@@ -627,10 +627,11 @@ def get_peinfo(
         cleaned_dump = {}
 
         binary_load = lief.parse(filepath)  # pylint: disable=I1101
-        if binary_load is None:
-            raise ValueError("Failed to load binary.")
-        else:
+        if binary_load is not None:
             binary = binary_load
+        else:
+            raise ValueError("Failed to load binary.")
+
         for section in binary.sections:
             section_info = {}
             slack = section.sizeof_raw_data - section.virtual_size  # type: ignore
@@ -695,10 +696,10 @@ def insert_section(
             lief.logging.disable()
 
         binary_parse = lief.PE.parse(datapoint)
-        if binary_parse is None:
-            raise ValueError("Failed to load binary.")
-        else:
+        if binary_parse is not None:
             binary = binary_parse
+        else:
+            raise ValueError("Failed to load binary.")
 
         name_in_use = True
         while name_in_use: