[Gothic 1] bug tracking #622

Abendlied · 2024-05-13T10:42:42Z

Abendlied
May 13, 2024

Gothic 1 Bug List

13. Sleeper Temple Puzzles and Timers
13. multiple findings, all categorised as sleeper temple puzzles, traps and timings

17. Full map live simulation related
multiple findings, all categorised as full map live simulation related after a teleport

17.1 Bartholo not at pentagram but in kitchen room next to Gomez after old camp teleport, chapter 5 after retrieving ore armour from Xardas old tower
savegame: save_slot_15.sav.tar.gz note: all irrelevant NPCs pre-killed, makes testing easier.
no ticket created
screenshot: n/a
17.2 Stone not in prison but in smith area after old camp teleport, chapter 5 after retrieving ore armour from Xardas old tower
savegame: save_slot_15.sav.tar.gz (same as 17.1)
no ticket created
screenshot: n/a
17.3 Milten not at water mage pentagram after receiving Uriziel scroll from Xardas and teleporting to new camp.
savegame: save_slot_6.sav.tar.gz
no ticket created
screenshot: n/a

18. Magic Related
multiple magic findings
note items 8 (telekinesis) and 9 (leeper Temple Teleport Scroll) of this discussion thread left where they are for consistency

18.1 Destroy Undead instantly kills Grash-Varrag-Arushat (5th undead priest), long before player has Uriziel
savegame: save_slot_7.sav.tar.gz
ticket: [Gothic 1] Magic Quirks #661
screenshot: n/a
solution: fixed by merged PR Fix some Gothic 1 magic bugs #682 (thanks @thokkat!) that disables focusing enemies with destroy undead spell.
and PR Follow up fix for TARGET_TYPE #685 where damage cannot be applied.
18.2 Destroy Undead kills all undead and regular orcs and minecrawler warriors and Demons. Is that base game behaviour?
savegame: save_slot_4.sav.tar.gz
ticket: [Gothic 1] Magic Quirks #661
screenshot: n/a
solution: fixed by merged PR Fix some Gothic 1 magic bugs #682 (thanks @thokkat!) that disables focusing enemies with destroy undead spell.
and PR Follow up fix for TARGET_TYPE #685 where damage cannot be applied.
18.3 Transformation scrolls do not work, e.g. meat bug at old ruin with Gorn
savegame: save_slot_12.sav.tar.gz
ticket: [Gothic 1] Magic Quirks #661
screenshot: n/a
solution: potentially covered by merged PR Fix some Gothic 1 magic bugs #682
18.4 Attack spells focus on items, not only enemies
savegame: save_slot_15.sav.tar.gz
ticket: [Gothic 1] Magic Quirks #661
screenshot: equipped attack spell shows ranged puzzle trigger (even through the wall)
solution: potentially covered by merged PR Fix some Gothic 1 magic bugs #682
18.5 fire rain does not work properly, charge animation broken
savegame: save_slot_14.sav.tar.gz
ticket: [Gothic 1] Magic Quirks #661
mp4-video: 7 sec, 6.1 MiB: fire rain quirky animation
solution: fixed by merged PR Fix some Gothic 1 magic bugs #682 (verified it is working, thank you @thokkat!)
18.6 uriziel spell only damages focused NPC, charge animation broken
savegame: n/a
ticket: [Gothic 1] Magic Quirks #661
screenshot: n/a
solution: fixed by merged PR Fix some Gothic 1 magic bugs #682 (verified it is working, thank you @thokkat!)
18.7 pyrokinesis spell does not cause damage
savegame: save_slot_14.sav.tar.gz
mp4-video: 6 sec, 6.6 MiB: pyrokinesis no dmg, no
solution: not (yet) fixed by PR Fix some Gothic 1 magic bugs #682, still does no damage and shows no animation.
18.8 Ice wave does no damage, does not freeze enemies
savegame: save_slot_14.sav.tar.gz
mp4-video: 6 sec, 6.6 MiB: ice wave no freezing no dmg
solution: fixed by merged PR Fix some Gothic 1 magic bugs #682 (verified it is working, thank you @thokkat!)
18.9 control spell not implemented
savegame: n/a
no ticket created
screenshot: n/a
crashlog:

crashlog after control spell should end succesfully

> ---crashlog(std::terminate)--- > GPU: NVIDIA GeForce GTX 1050 > #1: std::unexpected() - /usr/lib/libstdc++.so.6(_ZSt10unexpectedv+0) [0x7e55a789752a] > #2: std::unexpected() - /usr/lib/libstdc++.so.6(+0xae2b6) [0x7e55a78ae2b6] > #3: std::enable_if, void>::type zenkit::DaedalusVm::allocate_instance(std::shared_ptr const&, zenkit::DaedalusSymbol*) - /home/abendlied/OpenGothic/build/opengothic/Gothic2Notr(_ZN6zenkit10DaedalusVm17allocate_instanceINS_4INpcEEENSt9enable_ifIX12is_base_of_vINS_16DaedalusInstanceET_EEvE4typeERKSt10shared_ptrIS5_EPNS_14DaedalusSymbolE+0x304) [0x598b97e8ef24] > #4: GameScript::initializeInstanceNpc(std::shared_ptr const&, unsigned long) - /home/abendlied/OpenGothic/build/opengothic/Gothic2Notr(_ZN10GameScript21initializeInstanceNpcERKSt10shared_ptrIN6zenkit4INpcEEm+0x50) [0x598b97e73860] > #5: Npc::commitSpell() - /home/abendlied/OpenGothic/build/opengothic/Gothic2Notr(_ZN3Npc11commitSpellEv+0x29b) [0x598b97fe167b] > #6: Npc::tickCast(unsigned long) - /home/abendlied/OpenGothic/build/opengothic/Gothic2Notr(_ZN3Npc8tickCastEm+0x337) [0x598b97fe1c77] > #7: Npc::tick(unsigned long) - /home/abendlied/OpenGothic/build/opengothic/Gothic2Notr(_ZN3Npc4tickEm+0x5f) [0x598b97fe216f] > #8: WorldObjects::tick(unsigned long, unsigned long) - /home/abendlied/OpenGothic/build/opengothic/Gothic2Notr(_ZN12WorldObjects4tickEmm+0x22d) [0x598b9800d35d] > #9: World::tick(unsigned long) - /home/abendlied/OpenGothic/build/opengothic/Gothic2Notr(_ZN5World4tickEm+0x1b) [0x598b97ffe34b] > #10: GameSession::tick(unsigned long) - /home/abendlied/OpenGothic/build/opengothic/Gothic2Notr(_ZN11GameSession4tickEm+0xc7) [0x598b97ebd357] > #11: MainWindow::tick() - /home/abendlied/OpenGothic/build/opengothic/Gothic2Notr(_ZN10MainWindow4tickEv+0x127) [0x598b97f68ef7] > #12: MainWindow::render() - /home/abendlied/OpenGothic/build/opengothic/Gothic2Notr(_ZN10MainWindow6renderEv+0x64) [0x598b97f6cec4] > #13: Tempest::X11Api::implProcessEvents(Tempest::SystemApi::AppCallBack&) - /home/abendlied/OpenGothic/build/opengothic/libTempest.so(_ZN7Tempest6X11Api17implProcessEventsERNS_9SystemApi11AppCallBackE+0x5e) [0x7e55a7d6282e] > #14: Tempest::X11Api::implExec(Tempest::SystemApi::AppCallBack&) - /home/abendlied/OpenGothic/build/opengothic/libTempest.so(_ZN7Tempest6X11Api8implExecERNS_9SystemApi11AppCallBackE+0x1b) [0x7e55a7d62f8b] > #15: main - /home/abendlied/OpenGothic/build/opengothic/Gothic2Notr(main+0x218) [0x598b97e05418]

solution: n/a

19. Outdated dialogue options are shown
savegame: save_slot_8.sav.tar.gz
no ticket created
screenshot: Player is firemage. Milten dialogue offers info about mage apprenticeship
20. Monsters with position bug default to map coordinate root (old camp dungeon) causing OC NPCs in fight mode
savegame: save_slot_9.sav.tar.gz
no ticket created
screenshot: snappers defaulted to OC dungeon
21. Baal Tyon does not accept prepared swamp weed (no dialogue option)
savegame: save_slot_15.sav.tar.gz
no ticket created
solution: fixed by merged PR Don't consider npc type for attitudes #660 (verified it is working, thank you once again @thokkat!)
22. Pickpocket skill (both level 1 and level 2) not implemented
savegame: n/a
no ticket created
screenshot: n/a

edit: moved list to first post, easier to follow up.

I know Gothic 1 is out of scope for the opengothic engine project. However, it does work extremely well by now, allowing play through without large problems.
For bugs in Gothic 1 using opengothic, how are we going to manage them here?

open a normal bug ticket with a Gotic 1 indicator?
open one ticket gathering Gothic 1 bugs potentially to work on in the future?
out of scope, no reason to track Gothic 1 bugs?

I am in favour of option 2 for bugs as it allows collection, allows link to PR of potential contributors.

For adaptations to G1, I am not sure how to handle things that are different in a "pure" G1 experience but work "the G2 way".
Examples:

inventory management with grid/table instead of single column
trading treats ore like gold, causing infinite ore availability for merchants

Should we gather those as well? I personally do not need those fixed but I notice them and it would probably be an easy task to write them down (for purists to be able to fix them)

Try · 2024-05-13T20:45:20Z

Try
May 13, 2024
Maintainer

Hi, @Abendlied !

We already have had some experience with combining way too may small bugs into a single long issue. While 'pure' №2 is not an good option, people may raise issue here first (or separated discussion, for that mater), end then I'll spawn issues from it.

Btw, for

inventory management with grid/table instead of single column
trading treats ore like gold, causing infinite ore availability for merchants

feel free to open issues and mark them as G1 :)

10 replies

Abendlied May 24, 2024
Author

Gathered multiple findings under 17 and categorised as full map live simulation related after a teleport

thokkat May 26, 2024
Collaborator

For reference, added a issue for 13. #637. 13.1 is fixed by #636.

15. is again script missing equip command. Vanilla game must have some automatic equip of best weapon.

Abendlied Jul 15, 2024
Author

For reference, added a issue for 13. #637. 13.1 is fixed by #636.

15. is again script missing equip command. Vanilla game must have some automatic equip of best weapon.

regarding 15, potentially related:
When Xardas inspects Uriziel for the first time, he wields it. Instead of Uriziel, in my case he equipped the highest damage melee weapon from his (trader) inventory:

thokkat Jul 26, 2024
Collaborator

Should work now. Vanilla equips best weapon instead of Uriziel directly. Problem was items were ranked by gold value instead of stats. This was fixed in 597c82b.

Abendlied Sep 14, 2024
Author

Should work now. Vanilla equips best weapon instead of Uriziel directly. Problem was items were ranked by gold value instead of stats. This was fixed in 597c82b.

Happens with charged URIZIEL as well, when speaking with lester.

I would assume similar root cause, only with charged weapon now.

savegame triggering sequence:
save_slot_10.sav.tar.gz

Abendlied · 2024-05-14T16:03:30Z

Abendlied
May 14, 2024
Author

Regarding item 6 (Tarrok), I see he is already immortal, so that would not help.

instance FreemineOrc(C_NPC)
{
	//-------- primary data --------
	name =	"Ork Sklave";
	guild =	GIL_NONE;  
	level =	3;
	flags = NPC_FLAG_IMMORTAL;
	voice =	17;
	ID	  =	2101;

	//---------	abilities --------
	attribute[ATR_STRENGTH]			=		90;
	attribute[ATR_DEXTERITY]		=		20;
	
	attribute[ATR_HITPOINTS_MAX]	=		250;
	attribute[ATR_HITPOINTS]		=		10;

	protection[PROT_EDGE]			=		15;
	protection[PROT_BLUNT]			=		15;
	protection[PROT_POINT]			=		5;
	protection[PROT_FIRE]			=		7;
	protection[PROT_MAGIC]			=		0;
//	talents					=		0;`

I am not really sure what happens but I think Tarrok is actually consuming the medicine. For the player (non-Orc), the medicine kills instantly. For Orcs it should restore to full HP.

INSTANCE	OrcMedicine(C_ITEM)
{
	name 				= "Ork-Medizin";
	mainflag 			= ITEM_KAT_POTIONS;
	flags 				= ITEM_MISSION;
	value 				= 0;	
	visual 				= "ITFO_POTION_STRENGTH_01.3DS";
	material 			= MAT_GLAS;
	on_state[0]			= UseOrcMedicine;
	scemeName			= "POTION";
	description			= name;
	TEXT[0]				= "Wirkung: unbekannt";
};
func void UseOrcMedicine ()
{
	if (C_NpcIsOrc(self))
	{
		self.attribute[ATR_HITPOINTS] = self.attribute[ATR_HITPOINTS_MAX];
	}
	else
	{
		Npc_ChangeAttribute	(self,ATR_HITPOINTS,-self.attribute[ATR_HITPOINTS_MAX]);
	};
};

0 replies

thokkat · 2024-05-14T16:32:59Z

thokkat
May 14, 2024
Collaborator

Guild is GIL_NONE which makes the orc check C_NpcIsOrc(self) fail. Need to check if in vanilla Tarrok is fully healed or health is unchanged due to immortality.

Ok check is failing in vanilla too but health is still restored...

3 replies

Abendlied May 14, 2024
Author

exactly @thokkat , this one is confusing. Other orc slaves are in guild GIL_ORCSLAVE. Potentially an oversight in the vanilla game.

instance Orc_2001_Sklave(Npc_Default)
{
	//-------- primary data --------
	
	name =							"Ork Sklave";
	slot =							"Orc Slave";
	guild =							GIL_ORCSLAVE;      
	level =							3;
	flags =							0;
	voice =							17;
	ID	  =							2001;

I want to check in vanilla G1 if Tarrok is down to 10HP, should be as fast check with entering the free mine (using k) and then taking control over Tarrok (using o) but currently I get Access violation after I uninstalled all kinds of fixes like union, community patch etc, preventing me from starting the game. Will get back after I fixed it on my side.

thokkat May 16, 2024
Collaborator

Tarrok has full health, so one bug covered another :D. I've pushed a PR to respect immortality which solves the freeze and Tarrok is no longer dying. Unfortunately health stays low, this can only be fixed by a script patch.

Abendlied May 21, 2024
Author

#631 fixes the Tarrok problem, works flawless now. Thanks @thokkat!

Abendlied · 2024-05-21T15:56:21Z

Abendlied
May 21, 2024
Author

11. Two handed run-attack is interpreted as a kick with kick animation

kick animation comes in all three 2h training modes. Damage seems equal to regular melee hit from my observations.

I added a video, 2 sec, 1.5 MiB:

2024-05-21.17-51-42.mp4

2 replies

thokkat Aug 12, 2024
Collaborator

2H doesn't even work in vanilla. Animation does not exist for humans only for orcs. Probably they just forgot to add it since it's working in G2. Fist run attack animation is used as fallback.

Abendlied Aug 12, 2024
Author

Interesting, thanks once again for checking, thokkat. Now that I think of it, G1 was intended as keyboard only, mouse control was only added weeks before release. With the original keyboard control setup I cannot even do a run attack in classic Gothic 1, as it is [CTRL] + [↑], for which I have to interrupt running. So technically I would always hit from a standing position.

If the animation does not exist in the base game, we can probably dismiss this item.

Abendlied · 2024-07-15T16:30:11Z

Abendlied
Jul 15, 2024
Author

Regarding 18. Magic

Destroy Undead:
Spells_Params.d lists damage for individual spells.
const int SPL_DAMAGE_MASSDEATH = 200; const int SPL_DAMAGE_BREATHOFDEATH = 100; const int SPL_DAMAGE_DESTROYUNDEAD = 9999;

effectively a one hit skill.
Can this be the reason why it even kills Grash-Varrag-Arushat (5th undead priest)? Or is this another immortal/important flag miss?

INSTANCE Spell_DestroyUndead(C_Spell_Proto) { time_per_mana = 250; damage_per_level = SPL_DAMAGE_DESTROYUNDEAD; spelltype = SPELL_NEUTRAL; damageType = DAM_MAGIC; targetCollectAlgo = TARGET_COLLECT_FOCUS_FALLBACK_NONE; targetCollectRange = 1500; // 15m targetCollectType = TARGET_TYPE_UNDEAD; };

I did not find how the check for tartegCollectType actually filters effectively.

Uriziel Magic
Spell_New1 is effectively an exact copy of BreathOfDead, so I guess the observed damage on the target is the intended behaviour. From my memory it was an area of effect damage spell but I might have confused it.

1 reply

thokkat Jul 28, 2024
Collaborator

I did not find how the check for tartegCollectType actually filters effectively.

From testing it seems this prevents target focus. Changing either priest guild to skeleton or targetCollectType to TARGET_TYPE_ORCS allows targeting and priest can be killed in vanilla. Use of TargetCollectType is unimplemented in OpenGothic because it's unused in Gothic 2.

High armor prevents other damage.

	protection	[PROT_BLUNT]		=	1000;
	protection	[PROT_EDGE]		=	1000;
	protection	[PROT_POINT]		=	1000;
	protection	[PROT_FIRE]		=	1000;
	protection	[PROT_FLY]		=	1000;
	protection	[PROT_MAGIC]		=	100;

thokkat · 2024-07-27T17:24:09Z

thokkat
Jul 27, 2024
Collaborator

19. is once again (surprise) a script bug. Checking for quest success instead of player guild.

FUNC INT DIA_Milten_WannaMage_Condition()
{
	if ( Npc_KnowsInfo(hero,DIA_Milten_PERM) && (CorKalom_BringMCQBalls != LOG_SUCCESS) )
	{
		return 1;
	};
};

21. is solved by #660.

2 replies

Abendlied Jul 28, 2024
Author

19. is once again (surprise) a script bug. Checking for quest success instead of player guild.
FUNC INT DIA_Milten_WannaMage_Condition()
{
	if ( Npc_KnowsInfo(hero,DIA_Milten_PERM) && (CorKalom_BringMCQBalls != LOG_SUCCESS) )
	{
		return 1;
	};
};

Thanks @thokkat, that makes sense! Instead they should test for && (Npc_GetTrueGuild (other)!=GIL_KDF), however they would need to test for GIL_STT (shadow) and GIL_GRD (guard) too alone from the old camp, plus also all possible NC and SC guilds. Probably they wanted to find a more elegant way and went with the quest, with this oversight.
Most elegant way I could think of is to check for Npc_GetTrueGuild != GIL_NONE.

Same with Thorus bribe (1000 ore) dialogue option:

{	
	if (Npc_KnowsInfo(hero,Info_Thorus_EnterCastle) && (Npc_GetTrueGuild (other)!=GIL_STT) && (Npc_GetTrueGuild (other)!=GIL_GRD) )
	{
		return 1;
	};
};

Does not have GIL_KDF as condition (or bandit amulet or SC):


FUNC INT Info_Thorus_Give1000Ore_Condition()
{	
	if (Npc_KnowsInfo(hero,Info_Thorus_BribeGuard))
	{
		return 1;
	};
};

Abendlied Aug 1, 2024
Author

21. is solved by #660.

works pefectly, also enabled all other missing dialog options for Baal Tyon. Thank you!

Try · 2025-04-20T23:01:29Z

Try
Apr 20, 2025
Maintainer

Noticed in G1:

func void  DIA_EXTRO_AVI ()
{
	PlayVideo ( "Extro.bik");
	PlayVideo ( "PlayerOut.bik");
	PlayVideo ( "Credits.bik");
	ExitGame(); //Beendet Spiel
};

Problem, that in opengothic ExitGame is immediate command and will halt the game as soon as executed. Videos, however are deferred, so they have no chance to do anything.

0 replies

[Gothic 1] bug tracking #622

Uh oh!

Uh oh!

Abendlied May 13, 2024

edit: moved list to first post, easier to follow up.

Replies: 7 comments · 18 replies

Uh oh!

Try May 13, 2024 Maintainer

Uh oh!

Abendlied May 24, 2024 Author

Uh oh!

thokkat May 26, 2024 Collaborator

Uh oh!

Abendlied Jul 15, 2024 Author

Uh oh!

thokkat Jul 26, 2024 Collaborator

Uh oh!

Abendlied Sep 14, 2024 Author

Uh oh!

Uh oh!

Abendlied May 14, 2024 Author

Uh oh!

Uh oh!

thokkat May 14, 2024 Collaborator

Uh oh!

Uh oh!

Abendlied May 14, 2024 Author

Uh oh!

thokkat May 16, 2024 Collaborator

Uh oh!

Abendlied May 21, 2024 Author

Uh oh!

Uh oh!

Abendlied May 21, 2024 Author

Uh oh!

thokkat Aug 12, 2024 Collaborator

Uh oh!

Abendlied Aug 12, 2024 Author

Uh oh!

Abendlied Jul 15, 2024 Author

Uh oh!

thokkat Jul 28, 2024 Collaborator

Uh oh!

thokkat Jul 27, 2024 Collaborator

Uh oh!

Uh oh!

Abendlied Jul 28, 2024 Author

Uh oh!

Abendlied Aug 1, 2024 Author

Uh oh!

Try Apr 20, 2025 Maintainer

Abendlied
May 13, 2024

Replies: 7 comments 18 replies

Try
May 13, 2024
Maintainer

Abendlied May 24, 2024
Author

thokkat May 26, 2024
Collaborator

Abendlied Jul 15, 2024
Author

thokkat Jul 26, 2024
Collaborator

Abendlied Sep 14, 2024
Author

Abendlied
May 14, 2024
Author

thokkat
May 14, 2024
Collaborator

Abendlied May 14, 2024
Author

thokkat May 16, 2024
Collaborator

Abendlied May 21, 2024
Author

Abendlied
May 21, 2024
Author

thokkat Aug 12, 2024
Collaborator

Abendlied Aug 12, 2024
Author

Abendlied
Jul 15, 2024
Author

thokkat Jul 28, 2024
Collaborator

thokkat
Jul 27, 2024
Collaborator

Abendlied Jul 28, 2024
Author

Abendlied Aug 1, 2024
Author

Try
Apr 20, 2025
Maintainer