Extracted helper to map feed results to post DTOs (#1385)

ref https://linear.app/ghost/issue/BER-2908/add-dummy-api-endpoint-to-start-vertical-integration

- in the context of introducing the global feed, extracted the mapping from a feed result to a post DTO, so that it can reused

Author: sagzy

src/http/api/feed.controller.ts

@@ -1,9 +1,14 @@
 import * as Sentry from '@sentry/node';
 
+import type { Account } from '@/account/account.entity';
 import { getAccountHandle } from '@/account/utils';
 import type { AppContext } from '@/app';
-import type { FeedService, FeedType } from '@/feed/feed.service';
-import type { PostDTO } from '@/http/api/types';
+import { parseURL } from '@/core/url';
+import type {
+    FeedService,
+    FeedType,
+    GetFeedDataResultRow,
+} from '@/feed/feed.service';
 import { APIRoute, RequireRoles } from '@/http/decorators/route.decorator';
 import { GhostRole } from '@/http/middleware/role-guard';
 import type { PostInteractionCountsService } from '@/post/post-interaction-counts.service';
@@ -63,7 +68,41 @@ export class FeedController {
             cursor,
         });
 
-        const posts: PostDTO[] = results.map((result) => {
+        const posts = this.mapFeedResultsToPostDTO(results, account);
+
+        // Request an update of the interaction counts for the posts in the
+        // feed - We do not await this as we do not want to increase the
+        // response time of the request
+        this.postInteractionCountsService
+            .requestUpdate(
+                ctx.get('site').host,
+                results.map((post) => post.post_id),
+            )
+            .catch((error) => {
+                Sentry.captureException(error);
+
+                ctx.get('logger').error(
+                    'Error requesting update of interaction counts for posts {error}',
+                    { error },
+                );
+            });
+
+        return new Response(
+            JSON.stringify({
+                posts,
+                next: nextCursor,
+            }),
+            {
+                status: 200,
+            },
+        );
+    }
+
+    private mapFeedResultsToPostDTO(
+        results: GetFeedDataResultRow[],
+        myAccount: Account,
+    ) {
+        return results.map((result) => {
             return {
                 id: result.post_ap_id,
                 type: result.post_type,
@@ -89,26 +128,22 @@ export class FeedController {
                 author: {
                     id: result.author_id.toString(),
                     handle: getAccountHandle(
-                        result.author_url
-                            ? new URL(result.author_url).host
-                            : '',
+                        parseURL(result.author_url)?.host ?? '',
                         result.author_username,
                     ),
                     name: result.author_name ?? '',
                     url: result.author_url ?? '',
                     avatarUrl: result.author_avatar_url ?? '',
                     followedByMe: result.author_followed_by_user === 1,
                 },
-                authoredByMe: result.author_id === account.id,
+                authoredByMe: result.author_id === myAccount.id,
                 repostCount: result.post_repost_count,
                 repostedByMe: result.post_reposted_by_user === 1,
                 repostedBy: result.reposter_id
                     ? {
                           id: result.reposter_id.toString(),
                           handle: getAccountHandle(
-                              result.reposter_url
-                                  ? new URL(result.reposter_url).host
-                                  : '',
+                              parseURL(result.reposter_url)?.host ?? '',
                               result.reposter_username,
                           ),
                           name: result.reposter_name ?? '',
@@ -119,32 +154,5 @@ export class FeedController {
                     : null,
             };
         });
-
-        // Request an update of the interaction counts for the posts in the
-        // feed - We do not await this as we do not want to increase the
-        // response time of the request
-        this.postInteractionCountsService
-            .requestUpdate(
-                ctx.get('site').host,
-                results.map((post) => post.post_id),
-            )
-            .catch((error) => {
-                Sentry.captureException(error);
-
-                ctx.get('logger').error(
-                    'Error requesting update of interaction counts for posts {error}',
-                    { error },
-                );
-            });
-
-        return new Response(
-            JSON.stringify({
-                posts,
-                next: nextCursor,
-            }),
-            {
-                status: 200,
-            },
-        );
     }
 }