Banned use of explicit any

We had this set to warning to allow our legacy code to pass lint, but this has
result in more uses of explicit any being added to the codebase. The approach
here is to add comments to allow the existing cases but ban all new cases.

Author: allouis

biome.json

@@ -28,9 +28,7 @@
         "noNonNullAssertion": "off"
       },
       "suspicious": {
-        "noConsoleLog": "off",
-        "noExplicitAny": "warn",
-        "noImplicitAnyLet": "warn"
+        "noConsoleLog": "off"
       }
     }
   },

cedar/query-runner/src/app.ts

@@ -43,6 +43,8 @@ const warmupPool = async () => {
     console.timeEnd('Warmup');
 };
 
+// TODO: Clean up the any type
+// biome-ignore lint/suspicious/noExplicitAny: Legacy code needs proper typing
 const timeQuery = async (query: string, args: any[]) => {
     //: { [key: string]: string }) => {
     const start = performance.now();
@@ -51,6 +53,8 @@ const timeQuery = async (query: string, args: any[]) => {
     return end - start;
 };
 
+// TODO: Clean up the any type
+// biome-ignore lint/suspicious/noExplicitAny: Legacy code needs proper typing
 const runQuery = async (query: string, args: any[]) => {
     // { [key: string]: string }) => {
     const runTimes: number[] = Array(SERIES_RUNS).fill(

src/activity-handlers/create.handler.ts

@@ -44,6 +44,8 @@ export class CreateHandler {
         const replyTarget = await object?.getReplyTarget();
 
         if (replyTarget?.id?.href) {
+            // TODO: Clean up the any type
+            // biome-ignore lint/suspicious/noExplicitAny: Legacy code needs proper typing
             const data = await ctx.data.globaldb.get<any>([
                 replyTarget.id.href,
             ]);

src/app.ts

@@ -297,6 +297,8 @@ function ensureCorrectContext<B, R>(
     return async (ctx: Context<ContextData>, b: B) => {
         const host = ctx.host;
         if (!ctx.data) {
+            // TODO: Clean up the any type
+            // biome-ignore lint/suspicious/noExplicitAny: Legacy code needs proper typing
             (ctx as any).data = {};
         }
         if (!ctx.data.globaldb) {

src/core/events.ts

@@ -1,6 +1,8 @@
 import EventEmitter from 'node:events';
 
 export class AsyncEvents extends EventEmitter {
+    // TODO: Clean up the any type
+    // biome-ignore lint/suspicious/noExplicitAny: Legacy code needs proper typing
     async emitAsync(eventName: string, ...args: any[]): Promise<boolean> {
         const handlers = this.listeners(eventName);
         if (handlers.length === 0) {

src/db.ts

@@ -25,6 +25,8 @@ export const client = Knex({
 });
 
 interface ActivityJsonLd {
+    // TODO: Clean up the any type
+    // biome-ignore lint/suspicious/noExplicitAny: Legacy code needs proper typing
     [key: string]: any;
 }
 

src/dispatchers.ts

@@ -377,6 +377,8 @@ export async function handleAnnoucedCreate(
     const replyTarget = await object?.getReplyTarget();
 
     if (replyTarget?.id?.href) {
+        // TODO: Clean up the any type
+        // biome-ignore lint/suspicious/noExplicitAny: Legacy code needs proper typing
         const data = await ctx.data.globaldb.get<any>([replyTarget.id.href]);
         const replyTargetAuthor = data?.attributedTo?.id;
         const inboxActor = await getUserData(ctx, 'index');
@@ -954,8 +956,12 @@ export async function likedDispatcher(
                         object:
                             | string
                             | {
+                                  // TODO: Clean up the any type
+                                  // biome-ignore lint/suspicious/noExplicitAny: Legacy code needs proper typing
                                   [key: string]: any;
                               };
+                        // TODO: Clean up the any type
+                        // biome-ignore lint/suspicious/noExplicitAny: Legacy code needs proper typing
                         [key: string]: any;
                     }>([result]);
 

src/dispatchers.unit.test.ts

@@ -28,6 +28,8 @@ vi.mock('./app', () => ({
 describe('dispatchers', () => {
     describe('actorDispatcher', () => {
         it(`returns null if the handle is not "${ACTOR_DEFAULT_HANDLE}"`, async () => {
+            // TODO: Clean up the any type
+            // biome-ignore lint/suspicious/noExplicitAny: Legacy code needs proper typing
             const ctx = {} as RequestContext<any>;
             const handle = 'anything';
 
@@ -42,6 +44,8 @@ describe('dispatchers', () => {
     });
 
     describe('likedDispatcher', () => {
+        // TODO: Clean up the any type
+        // biome-ignore lint/suspicious/noExplicitAny: Legacy code needs proper typing
         const likeActivities: Record<string, any> = {
             'https://example.com/like/123': {
                 '@context': [
@@ -81,6 +85,8 @@ describe('dispatchers', () => {
                     info: vi.fn(),
                 },
             },
+            // TODO: Clean up the any type
+            // biome-ignore lint/suspicious/noExplicitAny: Legacy code needs proper typing
         } as RequestContext<any>;
 
         beforeEach(() => {
@@ -147,6 +153,8 @@ describe('dispatchers', () => {
         it('hydrates the object of a like', async () => {
             const actorId = 'https://example.com/actor/123';
 
+            // TODO: Clean up the any type
+            // biome-ignore lint/suspicious/noExplicitAny: Legacy code needs proper typing
             const likeActivities: Record<string, any> = {
                 'https://example.com/like/123': {
                     '@context': [
@@ -262,6 +270,8 @@ describe('dispatchers', () => {
                     error: vi.fn(),
                 },
             },
+            // TODO: Clean up the any type
+            // biome-ignore lint/suspicious/noExplicitAny: Legacy code needs proper typing
         } as RequestContext<any>;
 
         beforeEach(() => {
@@ -328,6 +338,8 @@ describe('dispatchers', () => {
 
     describe('nodeInfoDispatcher', () => {
         it('returns the node info', async () => {
+            // TODO: Clean up the any type
+            // biome-ignore lint/suspicious/noExplicitAny: Legacy code needs proper typing
             const result = await nodeInfoDispatcher({} as RequestContext<any>);
 
             expect(result).toEqual({

src/helpers/activitypub/activity.ts

@@ -17,12 +17,16 @@ export interface ActivityObject {
     id: string;
     content: string;
     attachment?: ActivityObjectAttachment | ActivityObjectAttachment[];
+    // TODO: Clean up the any type
+    // biome-ignore lint/suspicious/noExplicitAny: Legacy code needs proper typing
     [key: string]: any;
 }
 
 export interface Activity {
     id: string;
     object: string | ActivityObject;
+    // TODO: Clean up the any type
+    // biome-ignore lint/suspicious/noExplicitAny: Legacy code needs proper typing
     [key: string]: any;
 }
 

src/helpers/user.ts

@@ -144,6 +144,8 @@ export async function getUserKeypair(
     ctx: Context<ContextData>,
     handle: string,
 ) {
+    // TODO: Clean up the any types
+    // biome-ignore lint/suspicious/noExplicitAny: Legacy code needs proper typing
     const existing = await ctx.data.db.get<{ publicKey: any; privateKey: any }>(
         ['keypair', handle],
     );