🐛 Handled BOM character for Unicode encoded file uploads (#17104)

fixes TryGhost/Ghost#16917
refs TryGhost/Ghost#16917 (comment)

Co-authored-by: Princi Vershwal <[email protected]>

Author: vershwal

packages/members-csv/lib/parse.js

@@ -15,11 +15,11 @@ module.exports = (path, headerMapping, defaultLabels = []) => {
         const csvParserStream = papaparse.parse(papaparse.NODE_STREAM_INPUT, {
             header: true,
             transformHeader(_header) {
-                if (!headerMapping || !Reflect.has(headerMapping, _header)) {
+                const cleanHeader = _header.replace(papaparse.BYTE_ORDER_MARK, ''); //Removing BOM characters for Unicode-based encodings
+                if (!headerMapping || !Reflect.has(headerMapping, cleanHeader)) {
                     return undefined;
                 }
-
-                return headerMapping[_header];
+                return headerMapping[cleanHeader];
             },
             transform(value, header) {
                 if (header === 'labels') {

packages/members-csv/test/fixtures/single-column-with-header-bom.csv

@@ -0,0 +1,3 @@
+email
+[email protected]
+[email protected]

packages/members-csv/test/parse.test.js

@@ -35,6 +35,24 @@ describe('parse', function () {
         assert.equal(result.length, 0);
     });
 
+    it('one column with bom', async function () {
+        const filePath = csvPath + 'single-column-with-header-bom.csv';
+        const result = await parse(filePath, DEFAULT_HEADER_MAPPING);
+
+        assert.ok(result);
+        assert.equal(result.length, 2);
+        assert.equal(result[0].email, '[email protected]');
+        assert.equal(result[1].email, '[email protected]');
+    });
+
+    it('one column with bom and without header mapping returns empty result', async function () {
+        const filePath = csvPath + 'single-column-with-header-bom.csv';
+        const result = await parse(filePath);
+
+        assert.ok(result);
+        assert.equal(result.length, 0);
+    });
+
     it('two columns, 1 filter', async function () {
         const filePath = csvPath + 'two-columns-with-header.csv';
         const result = await parse(filePath, DEFAULT_HEADER_MAPPING);