Included style attribute in early exit check

no-issue

The early exit optimization was filtering out the style attribute,
which meant HTML containing only style attributes with URLs (like
background-image: url(...)) would skip parsing entirely and not
have their URLs transformed.

Author: allouis

packages/url-utils/src/utils/html-transform.ts

@@ -4,7 +4,6 @@ const cheerio = require('cheerio');
 
 export const transformAttributes = ['href', 'src', 'srcset', 'style'];
 export const earlyExitMatchStr = transformAttributes
-    .filter(attr => attr !== 'style')
     .map(attr => `${attr}=`)
     .join('|');
 

packages/url-utils/test/unit/utils/html-relative-to-absolute.test.js

@@ -273,9 +273,12 @@ describe('utils: htmlRelativeToAbsolute()', function () {
             htmlRelativeToAbsolute('<img srcset="/image-4x.png 4x, /image-2x.png 2x">)', url, itemPath, options);
             cheerioLoadSpy.callCount.should.equal(3, 'srcset didn\'t trigger parse');
 
+            htmlRelativeToAbsolute('<div style="background-image: url(\'/image.png\')"></div>', url, itemPath, options);
+            cheerioLoadSpy.callCount.should.equal(4, 'style didn\'t trigger parse');
+
             options.assetsOnly = true;
             htmlRelativeToAbsolute('<a href="/my-post/">post</a>', url, itemPath, options);
-            cheerioLoadSpy.callCount.should.equal(3, 'href triggered parse when no url matches asset path');
+            cheerioLoadSpy.callCount.should.equal(4, 'href triggered parse when no url matches asset path');
         });
     });
 });