🐛 Fixed members import unsubscribing members when subscribe_to_emails is empty (#19658)

fixes ENG-611

- Previously, if an existing member with newsletter subscriptions was
imported, and `subscribe_to_emails` was blank/empty, the member would be
unsubscribed from all newsletters, which is not the expected behavior.
- This PR changes the behavior so if `subscribe_to_emails` is blank, it
will not unsubscribe existing members.

Author: cmraible

packages/members-csv/lib/unparse.js

@@ -14,53 +14,53 @@ const DEFAULT_COLUMNS = [
     'tiers'
 ];
 
-const unparse = (members, columns = DEFAULT_COLUMNS.slice()) => {
+const unparse = (rows, columns = DEFAULT_COLUMNS.slice()) => {
     columns = columns.map((column) => {
         if (column === 'subscribed') {
             return 'subscribed_to_emails';
         }
         return column;
     });
-    const mappedMembers = members.map((member) => {
-        if (member.error && !columns.includes('error')) {
+    const mappedRows = rows.map((row) => {
+        if (row.error && !columns.includes('error')) {
             columns.push('error');
         }
 
         let labels = '';
-        if (typeof member.labels === 'string') {
-            labels = member.labels;
-        } else if (Array.isArray(member.labels)) {
-            labels = member.labels.map((l) => {
+        if (typeof row.labels === 'string') {
+            labels = row.labels;
+        } else if (Array.isArray(row.labels)) {
+            labels = row.labels.map((l) => {
                 return typeof l === 'string' ? l : l.name;
             }).join(',');
         }
 
         let tiers = '';
 
-        if (Array.isArray(member.tiers)) {
-            tiers = member.tiers.map((tier) => {
+        if (Array.isArray(row.tiers)) {
+            tiers = row.tiers.map((tier) => {
                 return tier.name;
             }).join(',');
         }
 
         return {
-            id: member.id,
-            email: member.email,
-            name: member.name,
-            note: member.note,
-            subscribed_to_emails: member.subscribed || member.subscribed_to_emails ? true : false,
-            complimentary_plan: member.comped || member.complimentary_plan,
-            stripe_customer_id: _.get(member, 'subscriptions[0].customer.id') || member.stripe_customer_id,
-            created_at: member.created_at,
-            deleted_at: member.deleted_at,
+            id: row.id,
+            email: row.email,
+            name: row.name,
+            note: row.note,
+            subscribed_to_emails: 'subscribed' in row ? row.subscribed : row.subscribed_to_emails,
+            complimentary_plan: row.comped || row.complimentary_plan,
+            stripe_customer_id: _.get(row, 'subscriptions[0].customer.id') || row.stripe_customer_id,
+            created_at: row.created_at,
+            deleted_at: row.deleted_at,
             labels: labels,
             tiers: tiers,
-            import_tier: member.import_tier || null,
-            error: member.error || null
+            import_tier: row.import_tier || null,
+            error: row.error || null
         };
     });
 
-    return papaparse.unparse(mappedMembers, {
+    return papaparse.unparse(mappedRows, {
         columns
     });
 };

packages/members-csv/test/unparse.test.js

@@ -13,7 +13,7 @@ describe('unparse', function () {
 
         assert.ok(result);
 
-        const expected = `id,email,name,note,subscribed_to_emails,complimentary_plan,stripe_customer_id,created_at,deleted_at,labels,tiers\r\n,[email protected],Sam Memberino,Early supporter,false,,,,,,`;
+        const expected = `id,email,name,note,subscribed_to_emails,complimentary_plan,stripe_customer_id,created_at,deleted_at,labels,tiers\r\n,[email protected],Sam Memberino,Early supporter,,,,,,,`;
         assert.equal(result, expected);
     });