Skip to content

Remove weird pagination that read all posts regardless of the collections filter #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove weird pagination that read all posts regardless of the collections filter #72

wants to merge 1 commit into from

Conversation

davidfraser
Copy link

If I have a fairly standard collection that uses the index feed, it shows items on the second page as you scroll down that don't match it's filter. For example with the following routes.yaml:

routes:
  /: home

collections:
  /blog/:
    permalink: /blog/{year}/{month}/{slug}/
    filter: primary_tag:blog

Then items that don't have their primary tag as blog still appear. This seems to be fairly directly caused by this unfiltered #get on page 2 in the source code, which I don't see any reason for... (obviously I may be missing something, please say!)

@davidfraser davidfraser mentioned this pull request Jan 17, 2025
Closed
@davidfraser
Copy link
Author

I see that this is actually reported as #33

@davidfraser
Copy link
Author

@minimaluminium I saw you said in #33 (comment) that there was a special trick needed to make get queries work with advanced layout options.
But what I see here looks like a strange second page that uses a different query to the other pages. I can't find much explanation in the history as to why this is the case, it just looks like it's been inherited through a few files and originated here
Would you be able to perhaps explain why this is needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidfraser