jest > node:test

Author: PaulAdamDavis

.eslintrc.yaml

@@ -5,5 +5,3 @@ extends:
 parserOptions:
     ecmaVersion: 2020
     sourceType: module
-env:
-    jest: true

jest.config.js

@@ -16,16 +16,14 @@
   "scripts": {
     "dev": "node bin/cli.js",
     "gctools": "gctools",
-    "test:only": "node --experimental-vm-modules node_modules/jest/bin/jest.js",
-    "test": "node --experimental-vm-modules node_modules/jest/bin/jest.js && yarn lint",
+    "test:only": "node --test --experimental-test-module-mocks test/*.test.js",
+    "test": "node --test --experimental-test-module-mocks test/*.test.js && yarn lint",
     "lint": "eslint . --ext .js --cache",
     "update": "git pull origin main && yarn"
   },
   "devDependencies": {
     "eslint": "8.57.0",
-    "eslint-plugin-ghost": "3.4.4",
-    "jest": "30.2.0",
-    "jest-extended": "7.0.0"
+    "eslint-plugin-ghost": "3.4.4"
   },
   "dependencies": {
     "@inquirer/confirm": "3.2.0",

package.json

@@ -1,61 +1,84 @@
-import {jest} from '@jest/globals';
-import errors from '@tryghost/errors';
+import {describe, test, mock, before, beforeEach} from 'node:test';
+import assert from 'node:assert/strict';
 
 // Shared mockApi object
 const mockApi = {
     members: {
-        browse: jest.fn(),
-        edit: jest.fn()
+        browse: mock.fn(),
+        edit: mock.fn()
     }
 };
 
-describe('add-member-comp-from-csv', () => {
-    let fsUtils;
-    let getTiers;
-    let addMemberCompFromCsv;
-    let mockFsUtils;
-
-    beforeAll(async () => {
-        await jest.unstable_mockModule('@tryghost/mg-fs-utils', () => ({
-            default: {
-                csv: {
-                    parseCSV: jest.fn()
-                }
-            }
-        }));
+const mockParseCSV = mock.fn();
+const mockGetTiers = mock.fn();
+
+// Mock bluebird to use native Promise — avoids V8 structured clone
+// serialization issues with bluebird promise objects in node:test IPC
+const NativePromise = Promise;
+NativePromise.mapSeries = async (arr, fn) => {
+    const results = [];
+    for (let i = 0; i < arr.length; i++) {
+        results.push(await fn(arr[i], i));
+    }
+    return results;
+};
+NativePromise.delay = ms => new NativePromise(resolve => setTimeout(resolve, ms));
+mock.module('bluebird', {
+    defaultExport: NativePromise
+});
+
+mock.module('@tryghost/mg-fs-utils', {
+    defaultExport: {
+        csv: {
+            parseCSV: mockParseCSV
+        }
+    }
+});
 
-        await jest.unstable_mockModule('@tryghost/admin-api', () => ({
-            default: jest.fn(() => mockApi)
-        }));
+mock.module('@tryghost/admin-api', {
+    defaultExport: function GhostAdminAPI() {
+        return mockApi;
+    }
+});
+
+mock.module('../lib/admin-api-call.js', {
+    namedExports: {getTiers: mockGetTiers}
+});
+
+// Mock @tryghost/errors to avoid serialization issues with custom error classes
+// in the node:test child process IPC
+class MockInternalServerError extends Error {
+    constructor({message, context}) {
+        super(message);
+        this.context = context;
+    }
+}
+mock.module('@tryghost/errors', {
+    defaultExport: {InternalServerError: MockInternalServerError}
+});
 
-        await jest.unstable_mockModule('../lib/admin-api-call.js', () => ({
-            getTiers: jest.fn()
-        }));
+describe('add-member-comp-from-csv', () => {
+    let addMemberCompFromCsv;
 
-        fsUtils = (await import('@tryghost/mg-fs-utils')).default;
-        getTiers = (await import('../lib/admin-api-call.js')).getTiers;
+    before(async () => {
         addMemberCompFromCsv = (await import('../tasks/add-member-comp-from-csv.js')).default;
     });
 
     beforeEach(() => {
-        // Reset all mock functions
-        mockApi.members.browse.mockReset();
-        mockApi.members.edit.mockReset();
-        mockFsUtils = fsUtils;
-    });
-
-    afterEach(() => {
-        jest.clearAllMocks();
+        mockApi.members.browse.mock.resetCalls();
+        mockApi.members.edit.mock.resetCalls();
+        mockParseCSV.mock.resetCalls();
+        mockGetTiers.mock.resetCalls();
     });
 
     test('should successfully process valid CSV rows', async () => {
         const csvData = [
             {email: 'test1@example.com', expireAt: '2024-12-31', tierName: 'Premium'},
             {email: 'test2@example.com', expireAt: '2024-12-31', tierName: 'Basic'}
         ];
-        mockFsUtils.csv.parseCSV.mockResolvedValue(csvData);
+        mockParseCSV.mock.mockImplementation(() => Promise.resolve(csvData));
 
-        mockApi.members.browse.mockImplementation(({filter}) => {
+        mockApi.members.browse.mock.mockImplementation(({filter}) => {
             if (filter === 'email:test1@example.com') {
                 return Promise.resolve([{id: '1', email: 'test1@example.com'}]);
             }
@@ -69,9 +92,9 @@ describe('add-member-comp-from-csv', () => {
             {id: 'tier1', name: 'Premium'},
             {id: 'tier2', name: 'Basic'}
         ];
-        getTiers.mockImplementation(() => Promise.resolve(tiers));
+        mockGetTiers.mock.mockImplementation(() => Promise.resolve(tiers));
 
-        mockApi.members.edit.mockImplementation(({id}) => {
+        mockApi.members.edit.mock.mockImplementation(({id}) => {
             return Promise.resolve({
                 id,
                 email: id === '1' ? 'test1@example.com' : 'test2@example.com',
@@ -87,69 +110,70 @@ describe('add-member-comp-from-csv', () => {
 
         await task.run();
 
-        expect(mockApi.members.browse).toHaveBeenCalledTimes(2);
-        expect(mockApi.members.edit).toHaveBeenCalledTimes(2);
+        assert.strictEqual(mockApi.members.browse.mock.callCount(), 2);
+        assert.strictEqual(mockApi.members.edit.mock.callCount(), 2);
     });
 
     test('should handle missing members', async () => {
         const csvData = [
             {email: 'nonexistent@example.com', expireAt: '2024-12-31', tierName: 'Premium'}
         ];
-        mockFsUtils.csv.parseCSV.mockResolvedValue(csvData);
+        mockParseCSV.mock.mockImplementation(() => Promise.resolve(csvData));
 
-        mockApi.members.browse.mockResolvedValue([]);
+        mockApi.members.browse.mock.mockImplementation(() => Promise.resolve([]));
 
         const task = addMemberCompFromCsv.getTaskRunner({
             apiURL: 'http://localhost:2368',
             adminAPIKey: 'test-key',
             csvPath: 'test.csv'
         });
 
-        await expect(task.run()).rejects.toThrow('Failed to process some rows');
+        await assert.rejects(task.run(), /Failed to process some rows/);
     });
 
     test('should handle missing tiers', async () => {
         const csvData = [
             {email: 'test@example.com', expireAt: '2024-12-31', tierName: 'NonexistentTier'}
         ];
-        mockFsUtils.csv.parseCSV.mockResolvedValue(csvData);
+        mockParseCSV.mock.mockImplementation(() => Promise.resolve(csvData));
 
-        mockApi.members.browse.mockResolvedValue([{id: '1', email: 'test@example.com'}]);
+        mockApi.members.browse.mock.mockImplementation(() => Promise.resolve([{id: '1', email: 'test@example.com'}]));
 
         const tiers = [{id: 'tier1', name: 'Premium'}];
-        getTiers.mockImplementation(() => Promise.resolve(tiers));
+        mockGetTiers.mock.mockImplementation(() => Promise.resolve(tiers));
 
         const task = addMemberCompFromCsv.getTaskRunner({
             apiURL: 'http://localhost:2368',
             adminAPIKey: 'test-key',
             csvPath: 'test.csv'
         });
 
-        await expect(task.run()).rejects.toThrow('Failed to process some rows');
+        await assert.rejects(task.run(), /Failed to process some rows/);
     });
 
     test('should handle API errors', async () => {
         const csvData = [
             {email: 'test@example.com', expireAt: '2024-12-31', tierName: 'Premium'}
         ];
-        mockFsUtils.csv.parseCSV.mockResolvedValue(csvData);
+        mockParseCSV.mock.mockImplementation(() => Promise.resolve(csvData));
 
-        mockApi.members.browse.mockResolvedValue([{id: '1', email: 'test@example.com'}]);
+        mockApi.members.browse.mock.mockImplementation(() => Promise.resolve([{id: '1', email: 'test@example.com'}]));
 
         const tiers = [{id: 'tier1', name: 'Premium'}];
-        getTiers.mockImplementation(() => Promise.resolve(tiers));
+        mockGetTiers.mock.mockImplementation(() => Promise.resolve(tiers));
 
-        mockApi.members.edit.mockRejectedValue(new errors.ValidationError({
+        const validationError = new MockInternalServerError({
             message: 'Invalid data',
             context: 'The provided data is invalid'
-        }));
+        });
+        mockApi.members.edit.mock.mockImplementation(() => Promise.reject(validationError));
 
         const task = addMemberCompFromCsv.getTaskRunner({
             apiURL: 'http://localhost:2368',
             adminAPIKey: 'test-key',
             csvPath: 'test.csv'
         });
 
-        await expect(task.run()).rejects.toThrow('Failed to process some rows');
+        await assert.rejects(task.run(), /Failed to process some rows/);
     });
-}); 
+});