Skip to content

Commit 4f5b996

Browse files
authored
tests: fix backup tests (#1154)
tests: wait for the backup to complete before finishing it tests: only trigger internal backup (from main to temp tables) when version is larger or equal to 3.26
1 parent 9a0c292 commit 4f5b996

File tree

1 file changed

+15
-11
lines changed

1 file changed

+15
-11
lines changed

test/backup.test.js

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -151,22 +151,24 @@ describe('backup', function() {
151151
});
152152
});
153153

154-
(sqlite3.VERSION_NUMBER < 3007011 ? it.skip : it) ('can backup from temp to main', function(done) {
154+
(sqlite3.VERSION_NUMBER < 3026000 ? it.skip : it) ('can backup from temp to main', function(done) {
155155
db.exec("CREATE TEMP TABLE space (txt TEXT)", function(err) {
156156
if (err) throw err;
157157
db.exec("INSERT INTO space(txt) VALUES('monkey')", function(err) {
158158
if (err) throw err;
159159
var backup = db.backup('test/tmp/backup.db', 'temp', 'main', true, function(err) {
160160
if (err) throw err;
161-
backup.step(-1);
162-
backup.finish(function(err) {
161+
backup.step(-1, function(err) {
163162
if (err) throw err;
164-
var db2 = new sqlite3.Database('test/tmp/backup.db', function(err) {
163+
backup.finish(function(err) {
165164
if (err) throw err;
166-
db2.get("SELECT * FROM space", function(err, row) {
165+
var db2 = new sqlite3.Database('test/tmp/backup.db', function(err) {
167166
if (err) throw err;
168-
assert.equal(row.txt, 'monkey');
169-
db2.close(done);
167+
db2.get("SELECT * FROM space", function(err, row) {
168+
if (err) throw err;
169+
assert.equal(row.txt, 'monkey');
170+
db2.close(done);
171+
});
170172
});
171173
});
172174
});
@@ -175,13 +177,15 @@ describe('backup', function() {
175177
});
176178
});
177179

178-
(sqlite3.VERSION_NUMBER < 3007011 ? it.skip : it) ('can backup from main to temp', function(done) {
180+
(sqlite3.VERSION_NUMBER < 3026000 ? it.skip : it) ('can backup from main to temp', function(done) {
179181
var backup = db.backup('test/support/prepare.db', 'main', 'temp', false, function(err) {
180182
if (err) throw err;
181-
backup.step(-1);
182-
backup.finish(function(err) {
183+
backup.step(-1, function(err) {
183184
if (err) throw err;
184-
assertRowsMatchDb(db, 'temp.foo', db, 'main.foo', done);
185+
backup.finish(function(err) {
186+
if (err) throw err;
187+
assertRowsMatchDb(db, 'temp.foo', db, 'main.foo', done);
188+
});
185189
});
186190
});
187191
});

0 commit comments

Comments
 (0)