Show descriptions

Author: Tsingis

App/Api/Setup/ApiEndpoints.cs

@@ -1,14 +1,12 @@
-using System.Globalization;
 using Asp.Versioning;
-using Microsoft.OpenApi.Any;
 using Services;
 
 namespace Api.Setup;
 
 internal static class ApiEndpoints
 {
-    private static readonly OpenApiString ExampleFromDate = new(DateTime.Now.AddMonths(-1).ToString("yyyy-MM-dd", CultureInfo.InvariantCulture));
-    private static readonly OpenApiString ExampleToDate = new(DateTime.Now.ToString("yyyy-MM-dd", CultureInfo.InvariantCulture));
+    // private static readonly OpenApiString ExampleFromDate = new(DateTime.Now.AddMonths(-1).ToString("yyyy-MM-dd", CultureInfo.InvariantCulture));
+    // private static readonly OpenApiString ExampleToDate = new(DateTime.Now.ToString("yyyy-MM-dd", CultureInfo.InvariantCulture));
 
     public static void ConfigureEndpoints(this WebApplication app)
     {
@@ -21,8 +19,7 @@ public static void ConfigureEndpoints(this WebApplication app)
             .MapGroup("api/v{version:apiVersion}")
             .WithApiVersionSet(apiVersionSet);
 
-        ConfigureEndpoint(group, "/longestdownwardtrend",
-            "Get longest downward trend in days between given dates",
+        group.MapGet("/longestdownwardtrend",
             async (IMarketService service, DateOnly fromDate, DateOnly toDate) =>
             {
                 try
@@ -38,33 +35,33 @@ public static void ConfigureEndpoints(this WebApplication app)
                 {
                     return Results.Problem(statusCode: (int?)ex.StatusCode);
                 }
-            });
+            })
+            .WithDescription("Get longest downward trend in days between given dates");
 
-        ConfigureEndpoint(group, "/highestradingvolume",
-            "Get the date with the highest trading volume between given dates",
-            async (IMarketService service, DateOnly fromDate, DateOnly toDate) =>
-            {
-                try
+        group.MapGet("/highestradingvolume",
+                async (IMarketService service, DateOnly fromDate, DateOnly toDate) =>
                 {
-                    var result = await service.GetHighestTradingVolume(fromDate, toDate);
-                    if (result is null)
+                    try
                     {
-                        return Results.NoContent();
+                        var result = await service.GetHighestTradingVolume(fromDate, toDate);
+                        if (result is null)
+                        {
+                         return Results.NoContent();
+                        }
+                        return Results.Ok(new HighestTradingVolumeResponse
+                        (
+                            result.Value.Date,
+                            result.Value.Volume
+                        ));
                     }
-                    return Results.Ok(new HighestTradingVolumeResponse
-                    (
-                        result.Value.Date,
-                        result.Value.Volume
-                    ));
-                }
-                catch (HttpRequestException ex)
-                {
-                    return Results.Problem(statusCode: (int?)ex.StatusCode);
-                }
-            });
+                    catch (HttpRequestException ex)
+                    {
+                        return Results.Problem(statusCode: (int?)ex.StatusCode);
+                    }
+                })
+                .WithDescription("Get the date with the highest trading volume between given dates");
 
-        ConfigureEndpoint(group, "/buyandsell",
-            "Get pair of dates when it is best to buy and sell between given dates",
+        group.MapGet("/buyandsell",
             async (IMarketService service, DateOnly fromDate, DateOnly toDate) =>
             {
                 try
@@ -84,20 +81,21 @@ public static void ConfigureEndpoints(this WebApplication app)
                 {
                     return Results.Problem(statusCode: (int?)ex.StatusCode);
                 }
-            });
+            })
+            .WithDescription("Get pair of dates when it is best to buy and sell between given dates");
     }
 
-    private static void ConfigureEndpoint(RouteGroupBuilder group, string route, string summary, Delegate handler)
-    {
-        group.MapGet(route, handler)
-            .WithOpenApi(operation =>
-            {
-                operation.Summary = summary;
-                operation.Parameters[0].Example = ExampleFromDate;
-                operation.Parameters[^1].Example = ExampleToDate;
-                return operation;
-            });
-    }
+    // private static void ConfigureEndpoint(RouteGroupBuilder group, string route, string description, Delegate handler)
+    // {
+    //     group.MapGet(route, handler)
+    //         .WithDescription(description)
+    //         .WithOpenApi(operation =>
+    //         {
+    //             operation.Parameters[0].Example = ExampleFromDate;
+    //             operation.Parameters[^1].Example = ExampleToDate;
+    //             return operation;
+    //         });
+    // }
 }
 
 public record LongestDownwardTrendResponse(int Days);